From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konradybcio@gmail.com>
Cc: skrzynka@konradybcio.pl, Andy Gross <agross@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Kees Cook <keescook@chromium.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
DTML <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 06/12] arm64: dts: qcom: msm8994: Add SCM node
Date: Wed, 24 Jun 2020 00:29:27 -0700 [thread overview]
Message-ID: <20200624072927.GT128451@builder.lan> (raw)
In-Reply-To: <CAMS8qEXeFO0vNKHoJeDKKprdECFLVtXOWnphc6iRjOBigeFe1Q@mail.gmail.com>
On Tue 23 Jun 16:30 PDT 2020, Konrad Dybcio wrote:
> >Shouldn't this be "qcom,scm-msm8992", "qcom,scm" ?
> >
> >(Or rather "qcom,scm-msm8994", "qcom,scm")
>
> Some DTs only have the SoC-specific one, and some also
> have the generic one. But I can add the generic one if
> you wish.
>
> I went with 8992, as I added it in the 8992 series
> (gonna update that one soon, too, so we can get it merged)
> and I didn't want to needlessly duplicate it. Ideally maybe we
> could switch to just qcom,scm for clockless SCM compats?
>
It's fairly common practice to specify both a specific and a generic
compatible, this would allow us to in the driver do special handling of
the specific in the future if we need to - without having to update the
devicetree.
Regards,
Bjorn
next prev parent reply other threads:[~2020-06-24 7:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 22:47 [PATCH v2 00/12] MSM8994 peripheral enablement, DTS updates Konrad Dybcio
2020-06-23 22:48 ` [PATCH v2 01/12] arm64: dts: qcom: msm8994: Modernize the DTS style Konrad Dybcio
2020-06-23 23:04 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 02/12] arm64: dts: qcom: msm8994: Add SPMI PMIC arbiter device Konrad Dybcio
2020-06-23 23:15 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 03/12] arm64: dts: qcom: msm8994: Add a proper CPU map Konrad Dybcio
2020-06-23 23:16 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 04/12] arm64: dts: qcom: msm8994: Add support for SMD RPM Konrad Dybcio
2020-06-23 23:15 ` Bjorn Andersson
2020-06-23 23:34 ` Konrad Dybcio
2020-06-24 6:40 ` Bjorn Andersson
2020-06-24 15:03 ` Konrad Dybcio
2020-06-23 22:48 ` [PATCH v2 05/12] arm64: dts: qcom: msm8994: Add SDHCI1 node Konrad Dybcio
2020-06-23 23:17 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 06/12] arm64: dts: qcom: msm8994: Add SCM node Konrad Dybcio
2020-06-23 23:19 ` Bjorn Andersson
2020-06-23 23:30 ` Konrad Dybcio
2020-06-24 7:29 ` Bjorn Andersson [this message]
2020-06-23 22:48 ` [PATCH v2 07/12] arm64: dts: qcom: msm8994: Add I2C, SPI and BLSP DMA nodes Konrad Dybcio
2020-06-23 23:21 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 08/12] arm64: dts: qcom: msm8994: Add pmu node Konrad Dybcio
2020-06-23 23:22 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 09/12] arm64: dts: qcom: msm8994: Add PSCI node Konrad Dybcio
2020-06-23 23:22 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 10/12] arm64: dts: qcom: angler: Add qcom,msm-id and pmic-id Konrad Dybcio
2020-06-23 23:23 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 11/12] arm64: dts: qcom: Move msm8994-smd-rpm contents to lg-bullhead Konrad Dybcio
2020-06-23 23:24 ` Bjorn Andersson
2020-06-23 22:48 ` [PATCH v2 12/12] arm64: dts: qcom: Add support for Sony Xperia Z5 (SoMC Sumire-RoW) Konrad Dybcio
2020-06-23 23:27 ` Bjorn Andersson
2020-06-24 14:44 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624072927.GT128451@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=devicetree@vger.kernel.org \
--cc=keescook@chromium.org \
--cc=konradybcio@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=skrzynka@konradybcio.pl \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.