From: Kees Cook <keescook@chromium.org>
To: Alexander Popov <alex.popov@linux.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>,
Jann Horn <jannh@google.com>, Emese Revfy <re.emese@gmail.com>,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Masahiro Yamada <masahiroy@kernel.org>,
Michal Marek <michal.lkml@markovi.net>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>,
Jessica Yu <jeyu@kernel.org>,
Sven Schnelle <svens@stackframe.org>,
Iurii Zaikin <yzaikin@google.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Collingbourne <pcc@google.com>,
Naohiro Aota <naohiro.aota@wdc.com>,
Alexander Monakov <amonakov@ispras.ru>,
Mathias Krause <minipli@googlemail.com>,
PaX Team <pageexec@freemail.hu>,
Brad Spengler <spender@grsecurity.net>,
Laura Abbott <labbott@redhat.com>,
Florian Weimer <fweimer@redhat.com>,
kernel-hardening@lists.openwall.com,
linux-kbuild@vger.kernel.org, x86@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, gcc@gcc.gnu.org, notify@kernel.org
Subject: Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter
Date: Wed, 24 Jun 2020 07:41:16 -0700 [thread overview]
Message-ID: <202006240740.5AF6369E53@keescook> (raw)
In-Reply-To: <d7b118c1-0369-9aef-bd34-afc9bafc7e7b@linux.com>
On Wed, Jun 24, 2020 at 04:09:20PM +0300, Alexander Popov wrote:
> On 24.06.2020 15:53, Luis Chamberlain wrote:
> > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote:
> >> Add 'verbose' plugin parameter for stackleak gcc plugin.
> >> It can be used for printing additional info about the kernel code
> >> instrumentation.
> >>
> >> For using it add the following to scripts/Makefile.gcc-plugins:
> >> gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \
> >> += -fplugin-arg-stackleak_plugin-verbose
> >
> > Would be nice if we instead could pass an argument to make which lets
> > us enable this.
>
> This feature is useful only for debugging stackleak gcc plugin.
>
> The cflag that enables it is similar to -fplugin-arg-structleak_plugin-verbose,
> which is used for debugging the structleak plugin.
>
> This debugging feature clutters the kernel build output, I don't think that many
> people will use it. So IMO creating a separate argument for make is not really
> needed.
Yup, agreed. The precedent for plugin verbosity is via CONFIGs. They're
not really general purpose enough to justify a "make" argument.
--
Kees Cook
WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: Alexander Popov <alex.popov@linux.com>
Cc: x86@kernel.org, kernel-hardening@lists.openwall.com,
Catalin Marinas <catalin.marinas@arm.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Will Deacon <will@kernel.org>,
Naohiro Aota <naohiro.aota@wdc.com>,
Sven Schnelle <svens@stackframe.org>,
Masahiro Yamada <masahiroy@kernel.org>,
linux-kbuild@vger.kernel.org, Emese Revfy <re.emese@gmail.com>,
PaX Team <pageexec@freemail.hu>,
Iurii Zaikin <yzaikin@google.com>,
Mathias Krause <minipli@googlemail.com>,
Jann Horn <jannh@google.com>,
Alexander Monakov <amonakov@ispras.ru>,
Brad Spengler <spender@grsecurity.net>,
Thomas Gleixner <tglx@linutronix.de>,
Peter Collingbourne <pcc@google.com>,
Laura Abbott <labbott@redhat.com>,
linux-arm-kernel@lists.infradead.org, notify@kernel.org,
Florian Weimer <fweimer@redhat.com>,
gcc@gcc.gnu.org, Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Jessica Yu <jeyu@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Thiago Jung Bauermann <bauerman@linux.ibm.com>
Subject: Re: [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter
Date: Wed, 24 Jun 2020 07:41:16 -0700 [thread overview]
Message-ID: <202006240740.5AF6369E53@keescook> (raw)
In-Reply-To: <d7b118c1-0369-9aef-bd34-afc9bafc7e7b@linux.com>
On Wed, Jun 24, 2020 at 04:09:20PM +0300, Alexander Popov wrote:
> On 24.06.2020 15:53, Luis Chamberlain wrote:
> > On Wed, Jun 24, 2020 at 03:33:30PM +0300, Alexander Popov wrote:
> >> Add 'verbose' plugin parameter for stackleak gcc plugin.
> >> It can be used for printing additional info about the kernel code
> >> instrumentation.
> >>
> >> For using it add the following to scripts/Makefile.gcc-plugins:
> >> gcc-plugin-cflags-$(CONFIG_GCC_PLUGIN_STACKLEAK) \
> >> += -fplugin-arg-stackleak_plugin-verbose
> >
> > Would be nice if we instead could pass an argument to make which lets
> > us enable this.
>
> This feature is useful only for debugging stackleak gcc plugin.
>
> The cflag that enables it is similar to -fplugin-arg-structleak_plugin-verbose,
> which is used for debugging the structleak plugin.
>
> This debugging feature clutters the kernel build output, I don't think that many
> people will use it. So IMO creating a separate argument for make is not really
> needed.
Yup, agreed. The precedent for plugin verbosity is via CONFIGs. They're
not really general purpose enough to justify a "make" argument.
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-24 14:41 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 12:33 [PATCH v2 0/5] Improvements of the stackleak gcc plugin Alexander Popov
2020-06-24 12:33 ` Alexander Popov
2020-06-24 12:33 ` [PATCH v2 1/5] gcc-plugins/stackleak: Don't instrument itself Alexander Popov
2020-06-24 12:33 ` Alexander Popov
2020-06-24 14:52 ` Kees Cook
2020-06-24 14:52 ` Kees Cook
2020-06-24 12:33 ` [PATCH v2 2/5] ARM: vdso: Don't use gcc plugins for building vgettimeofday.c Alexander Popov
2020-06-24 12:33 ` Alexander Popov
2020-06-24 12:52 ` Luis Chamberlain
2020-06-24 12:52 ` Luis Chamberlain
2020-06-24 12:56 ` Alexander Popov
2020-06-24 12:56 ` Alexander Popov
2020-06-24 14:52 ` Kees Cook
2020-06-24 14:52 ` Kees Cook
2020-06-24 12:33 ` [PATCH v2 3/5] arm64: " Alexander Popov
2020-06-24 12:33 ` Alexander Popov
2020-06-24 12:41 ` Will Deacon
2020-06-24 12:41 ` Will Deacon
2020-06-24 14:46 ` Kees Cook
2020-06-24 14:46 ` Kees Cook
2020-06-24 12:33 ` [PATCH v2 4/5] gcc-plugins/stackleak: Use asm instrumentation to avoid useless register saving Alexander Popov
2020-06-24 12:33 ` Alexander Popov
2020-06-24 12:33 ` [PATCH v2 5/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter Alexander Popov
2020-06-24 12:33 ` Alexander Popov
2020-06-24 12:53 ` Luis Chamberlain
2020-06-24 12:53 ` Luis Chamberlain
2020-06-24 13:09 ` Alexander Popov
2020-06-24 13:09 ` Alexander Popov
2020-06-24 14:41 ` Kees Cook [this message]
2020-06-24 14:41 ` Kees Cook
2020-06-24 14:53 ` Kees Cook
2020-06-24 14:53 ` Kees Cook
2020-06-24 13:54 ` [PATCH v2 0/5] Improvements of the stackleak gcc plugin Will Deacon
2020-06-24 13:54 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006240740.5AF6369E53@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=amonakov@ispras.ru \
--cc=bauerman@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=fweimer@redhat.com \
--cc=gcc@gcc.gnu.org \
--cc=jannh@google.com \
--cc=jeyu@kernel.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=labbott@redhat.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=mcgrof@kernel.org \
--cc=michal.lkml@markovi.net \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=minipli@googlemail.com \
--cc=naohiro.aota@wdc.com \
--cc=notify@kernel.org \
--cc=pageexec@freemail.hu \
--cc=pcc@google.com \
--cc=re.emese@gmail.com \
--cc=spender@grsecurity.net \
--cc=svens@stackframe.org \
--cc=tglx@linutronix.de \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
--cc=yamada.masahiro@socionext.com \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.