From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: "Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>, Jonathan Corbet <corbet@lwn.net>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Alex Williamson <alex.williamson@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
iommu@lists.linux-foundation.org,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 3/5] iommu/uapi: Use named union for user data
Date: Wed, 24 Jun 2020 08:48:01 -0700 [thread overview]
Message-ID: <20200624084801.297c9c0b@jacob-builder> (raw)
In-Reply-To: <96f6d717-e9b3-2a6b-5cff-c38dbe97aa7c@linux.intel.com>
On Wed, 24 Jun 2020 14:29:57 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> > case IOMMU_CACHE_INV_TYPE_IOTLB:
> > /* HW will ignore LSB bits based on
> > address mask */ if (inv_info->granularity == IOMMU_INV_GRANU_ADDR &&
> > size &&
> > - (inv_info->addr_info.addr &
> > ((BIT(VTD_PAGE_SHIFT + size)) - 1))) {
> > + (inv_info->granu.addr_info.addr &
> > ((BIT(VTD_PAGE_SHIFT + size)) - 1))) {
>
> Nit: Keep it aligned. With this tweaked,
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
will do. Thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Jacob Pan <jacob.jun.pan@linux.intel.com>
To: Lu Baolu <baolu.lu@linux.intel.com>
Cc: iommu@lists.linux-foundation.org,
LKML <linux-kernel@vger.kernel.org>,
Joerg Roedel <joro@8bytes.org>,
Alex Williamson <alex.williamson@redhat.com>,
David Woodhouse <dwmw2@infradead.org>,
Yi Liu <yi.l.liu@intel.com>, "Tian, Kevin" <kevin.tian@intel.com>,
Raj Ashok <ashok.raj@intel.com>,
Christoph Hellwig <hch@infradead.org>,
Jean-Philippe Brucker <jean-philippe@linaro.com>,
Eric Auger <eric.auger@redhat.com>,
Jonathan Corbet <corbet@lwn.net>,
jacob.jun.pan@linux.intel.com
Subject: Re: [PATCH v3 3/5] iommu/uapi: Use named union for user data
Date: Wed, 24 Jun 2020 08:48:01 -0700 [thread overview]
Message-ID: <20200624084801.297c9c0b@jacob-builder> (raw)
In-Reply-To: <96f6d717-e9b3-2a6b-5cff-c38dbe97aa7c@linux.intel.com>
On Wed, 24 Jun 2020 14:29:57 +0800
Lu Baolu <baolu.lu@linux.intel.com> wrote:
> > case IOMMU_CACHE_INV_TYPE_IOTLB:
> > /* HW will ignore LSB bits based on
> > address mask */ if (inv_info->granularity == IOMMU_INV_GRANU_ADDR &&
> > size &&
> > - (inv_info->addr_info.addr &
> > ((BIT(VTD_PAGE_SHIFT + size)) - 1))) {
> > + (inv_info->granu.addr_info.addr &
> > ((BIT(VTD_PAGE_SHIFT + size)) - 1))) {
>
> Nit: Keep it aligned. With this tweaked,
>
> Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
will do. Thanks.
next prev parent reply other threads:[~2020-06-24 15:41 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 17:03 [PATCH v3 0/5] IOMMU user API enhancement Jacob Pan
2020-06-23 17:03 ` Jacob Pan
2020-06-23 17:03 ` [PATCH v3 1/5] docs: IOMMU user API Jacob Pan
2020-06-23 17:03 ` Jacob Pan
2020-06-26 22:19 ` Alex Williamson
2020-06-26 22:19 ` Alex Williamson
2020-06-29 23:05 ` Jacob Pan
2020-06-29 23:05 ` Jacob Pan
2020-06-30 2:52 ` Tian, Kevin
2020-06-30 2:52 ` Tian, Kevin
2020-06-30 17:39 ` Jacob Pan
2020-06-30 17:39 ` Jacob Pan
2020-07-07 21:40 ` Alex Williamson
2020-07-07 21:40 ` Alex Williamson
2020-07-08 15:21 ` Jacob Pan
2020-07-08 15:21 ` Jacob Pan
2020-06-23 17:03 ` [PATCH v3 2/5] iommu/uapi: Add argsz for user filled data Jacob Pan
2020-06-23 17:03 ` Jacob Pan
2020-06-23 17:03 ` [PATCH v3 3/5] iommu/uapi: Use named union for user data Jacob Pan
2020-06-23 17:03 ` Jacob Pan
2020-06-24 6:29 ` Lu Baolu
2020-06-24 6:29 ` Lu Baolu
2020-06-24 15:48 ` Jacob Pan [this message]
2020-06-24 15:48 ` Jacob Pan
2020-06-23 17:03 ` [PATCH v3 4/5] iommu/uapi: Handle data and argsz filled by users Jacob Pan
2020-06-23 17:03 ` Jacob Pan
2020-06-24 6:54 ` Lu Baolu
2020-06-24 6:54 ` Lu Baolu
2020-06-24 17:07 ` Jacob Pan
2020-06-24 17:07 ` Jacob Pan
2020-06-25 7:07 ` Lu Baolu
2020-06-25 7:07 ` Lu Baolu
2020-06-23 17:03 ` [PATCH v3 5/5] iommu/uapi: Support both kernel and user unbind guest PASID Jacob Pan
2020-06-23 17:03 ` Jacob Pan
2020-06-24 7:55 ` Lu Baolu
2020-06-24 7:55 ` Lu Baolu
2020-06-25 12:59 ` Lu Baolu
2020-06-25 12:59 ` Lu Baolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624084801.297c9c0b@jacob-builder \
--to=jacob.jun.pan@linux.intel.com \
--cc=alex.williamson@redhat.com \
--cc=ashok.raj@intel.com \
--cc=baolu.lu@linux.intel.com \
--cc=corbet@lwn.net \
--cc=dwmw2@infradead.org \
--cc=hch@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.com \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.