From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de
Subject: Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes
Date: Wed, 24 Jun 2020 10:53:29 +0100 [thread overview]
Message-ID: <20200624095329.GY1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200624070045.8878-1-s.hauer@pengutronix.de>
On Wed, Jun 24, 2020 at 09:00:44AM +0200, Sascha Hauer wrote:
> In mvneta_config_interface() the RGMII modes are catched by the default
> case which is an error return. The RGMII modes are valid modes for the
> driver, so instead of returning an error add a break statement to return
> successfully.
>
> This avoids this warning for non comphy SoCs which use RGMII, like
> SolidRun Clearfog:
>
> WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Fixes: b4748553f53f ("net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy")
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index af60001728481..c4552f868157c 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -3571,7 +3571,7 @@ static int mvneta_config_interface(struct mvneta_port *pp,
> MVNETA_HSGMII_SERDES_PROTO);
> break;
> default:
> - return -EINVAL;
> + break;
> }
> }
>
> --
> 2.27.0
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
kernel@pengutronix.de
Subject: Re: [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes
Date: Wed, 24 Jun 2020 10:53:29 +0100 [thread overview]
Message-ID: <20200624095329.GY1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <20200624070045.8878-1-s.hauer@pengutronix.de>
On Wed, Jun 24, 2020 at 09:00:44AM +0200, Sascha Hauer wrote:
> In mvneta_config_interface() the RGMII modes are catched by the default
> case which is an error return. The RGMII modes are valid modes for the
> driver, so instead of returning an error add a break statement to return
> successfully.
>
> This avoids this warning for non comphy SoCs which use RGMII, like
> SolidRun Clearfog:
>
> WARNING: CPU: 0 PID: 268 at drivers/net/ethernet/marvell/mvneta.c:3512 mvneta_start_dev+0x220/0x23c
>
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
Fixes: b4748553f53f ("net: ethernet: mvneta: Fix Serdes configuration for SoCs without comphy")
Reviewed-by: Russell King <rmk+kernel@armlinux.org.uk>
Thanks.
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index af60001728481..c4552f868157c 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -3571,7 +3571,7 @@ static int mvneta_config_interface(struct mvneta_port *pp,
> MVNETA_HSGMII_SERDES_PROTO);
> break;
> default:
> - return -EINVAL;
> + break;
> }
> }
>
> --
> 2.27.0
>
>
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2020-06-24 9:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 7:00 [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes Sascha Hauer
2020-06-24 7:00 ` Sascha Hauer
2020-06-24 7:00 ` [PATCH 2/2] net: ethernet: mvneta: Add back interface mode validation Sascha Hauer
2020-06-24 7:00 ` Sascha Hauer
2020-06-24 9:55 ` Russell King - ARM Linux admin
2020-06-24 9:55 ` Russell King - ARM Linux admin
2020-06-24 21:48 ` David Miller
2020-06-24 21:48 ` David Miller
2020-06-24 9:53 ` Russell King - ARM Linux admin [this message]
2020-06-24 9:53 ` [PATCH 1/2] net: ethernet: mvneta: Do not error out in non serdes modes Russell King - ARM Linux admin
2020-06-24 21:48 ` David Miller
2020-06-24 21:48 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624095329.GY1551@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.