Re: [PATCH v9 3/4] f2fs: Use generic casefolding support

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3258 bytes --]

Hi Daniel,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v5.8-rc2 next-20200623]
[cannot apply to ext4/dev f2fs/dev-test tytso-fscrypt/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use  as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Daniel-Rosenberg/Prepare-for-upcoming-Casefolding-Encryption-patches/20200624-123657
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 3e08a95294a4fb3702bb3d35ed08028433c37fe6
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   fs/f2fs/dir.c: In function 'f2fs_match_ci_name':
>> fs/f2fs/dir.c:220:43: warning: passing argument 1 of 'F2FS_SB' discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
     220 |  const struct f2fs_sb_info *sbi = F2FS_SB(sb);
         |                                           ^~
   In file included from fs/f2fs/dir.c:12:
   fs/f2fs/f2fs.h:1734:64: note: expected 'struct super_block *' but argument is of type 'const struct super_block *'
    1734 | static inline struct f2fs_sb_info *F2FS_SB(struct super_block *sb)
         |                                            ~~~~~~~~~~~~~~~~~~~~^~
   fs/f2fs/dir.c:220:29: warning: unused variable 'sbi' [-Wunused-variable]
     220 |  const struct f2fs_sb_info *sbi = F2FS_SB(sb);
         |                             ^~~

vim +220 fs/f2fs/dir.c

   210	
   211	#ifdef CONFIG_UNICODE
   212	/*
   213	 * Test whether a case-insensitive directory entry matches the filename
   214	 * being searched for.
   215	 */
   216	static bool f2fs_match_ci_name(const struct inode *dir, const struct qstr *name,
   217				       const u8 *de_name, u32 de_name_len)
   218	{
   219		const struct super_block *sb = dir->i_sb;
 > 220		const struct f2fs_sb_info *sbi = F2FS_SB(sb);
   221		const struct unicode_map *um = sb->s_encoding;
   222		struct qstr entry = QSTR_INIT(de_name, de_name_len);
   223		int res;
   224	
   225		res = utf8_strncasecmp_folded(um, name, &entry);
   226		if (res < 0) {
   227			/*
   228			 * In strict mode, ignore invalid names.  In non-strict mode,
   229			 * fall back to treating them as opaque byte sequences.
   230			 */
   231			if (sb_has_enc_strict_mode(sb) || name->len != entry.len)
   232				return false;
   233			return !memcmp(name->name, entry.name, name->len);
   234		}
   235		return res == 0;
   236	}
   237	#endif /* CONFIG_UNICODE */
   238	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 67045 bytes --]