From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: Theodore Ts'o <tytso@mit.edu>,
linux-ext4@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
Chao Yu <chao@kernel.org>,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org,
Andreas Dilger <adilger.kernel@dilger.ca>,
Jonathan Corbet <corbet@lwn.net>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>,
kernel-team@android.com
Subject: Re: [PATCH v9 1/4] unicode: Add utf8_casefold_hash
Date: Tue, 23 Jun 2020 22:37:29 -0700 [thread overview]
Message-ID: <20200624053729.GE844@sol.localdomain> (raw)
In-Reply-To: <20200624043341.33364-2-drosen@google.com>
On Tue, Jun 23, 2020 at 09:33:38PM -0700, Daniel Rosenberg wrote:
> This adds a case insensitive hash function to allow taking the hash
> without needing to allocate a casefolded copy of the string.
It would be helpful to add a few more details in this commit message.
Somewhat along the lines of: ->d_hash() for casefolding currently allocates
memory, it needs to use GFP_ATOMIC due to ->d_hash() being called in rcu-walk
mode, this is unreliable and inefficient, and this patch allows solving that
problem by removing the need to allocate memory.
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: kernel-team@android.com, Theodore Ts'o <tytso@mit.edu>,
Jonathan Corbet <corbet@lwn.net>,
Richard Weinberger <richard@nod.at>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [f2fs-dev] [PATCH v9 1/4] unicode: Add utf8_casefold_hash
Date: Tue, 23 Jun 2020 22:37:29 -0700 [thread overview]
Message-ID: <20200624053729.GE844@sol.localdomain> (raw)
In-Reply-To: <20200624043341.33364-2-drosen@google.com>
On Tue, Jun 23, 2020 at 09:33:38PM -0700, Daniel Rosenberg wrote:
> This adds a case insensitive hash function to allow taking the hash
> without needing to allocate a casefolded copy of the string.
It would be helpful to add a few more details in this commit message.
Somewhat along the lines of: ->d_hash() for casefolding currently allocates
memory, it needs to use GFP_ATOMIC due to ->d_hash() being called in rcu-walk
mode, this is unreliable and inefficient, and this patch allows solving that
problem by removing the need to allocate memory.
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Daniel Rosenberg <drosen@google.com>
Cc: kernel-team@android.com, Theodore Ts'o <tytso@mit.edu>,
Jonathan Corbet <corbet@lwn.net>,
Richard Weinberger <richard@nod.at>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Chao Yu <chao@kernel.org>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel@vger.kernel.org, Jaegeuk Kim <jaegeuk@kernel.org>,
linux-ext4@vger.kernel.org,
Gabriel Krisman Bertazi <krisman@collabora.com>
Subject: Re: [PATCH v9 1/4] unicode: Add utf8_casefold_hash
Date: Tue, 23 Jun 2020 22:37:29 -0700 [thread overview]
Message-ID: <20200624053729.GE844@sol.localdomain> (raw)
In-Reply-To: <20200624043341.33364-2-drosen@google.com>
On Tue, Jun 23, 2020 at 09:33:38PM -0700, Daniel Rosenberg wrote:
> This adds a case insensitive hash function to allow taking the hash
> without needing to allocate a casefolded copy of the string.
It would be helpful to add a few more details in this commit message.
Somewhat along the lines of: ->d_hash() for casefolding currently allocates
memory, it needs to use GFP_ATOMIC due to ->d_hash() being called in rcu-walk
mode, this is unreliable and inefficient, and this patch allows solving that
problem by removing the need to allocate memory.
- Eric
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2020-06-24 5:37 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 4:33 [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches Daniel Rosenberg
2020-06-24 4:33 ` Daniel Rosenberg
2020-06-24 4:33 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 4:33 ` [PATCH v9 1/4] unicode: Add utf8_casefold_hash Daniel Rosenberg
2020-06-24 4:33 ` Daniel Rosenberg
2020-06-24 4:33 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 5:13 ` Gabriel Krisman Bertazi
2020-06-24 5:13 ` Gabriel Krisman Bertazi
2020-06-24 5:13 ` [f2fs-dev] " Gabriel Krisman Bertazi
2020-06-24 5:37 ` Eric Biggers [this message]
2020-06-24 5:37 ` Eric Biggers
2020-06-24 5:37 ` [f2fs-dev] " Eric Biggers
2020-06-24 4:33 ` [PATCH v9 2/4] fs: Add standard casefolding support Daniel Rosenberg
2020-06-24 4:33 ` Daniel Rosenberg
2020-06-24 4:33 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 5:33 ` Gabriel Krisman Bertazi
2020-06-24 5:33 ` Gabriel Krisman Bertazi
2020-06-24 5:33 ` [f2fs-dev] " Gabriel Krisman Bertazi
2020-06-24 5:42 ` Eric Biggers
2020-06-24 5:42 ` Eric Biggers
2020-06-24 5:42 ` [f2fs-dev] " Eric Biggers
2020-06-24 5:57 ` Eric Biggers
2020-06-24 5:57 ` Eric Biggers
2020-06-24 5:57 ` [f2fs-dev] " Eric Biggers
2020-07-03 1:01 ` Daniel Rosenberg
2020-07-03 1:01 ` Daniel Rosenberg
2020-07-03 1:01 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-07-03 19:20 ` Eric Biggers
2020-07-03 19:20 ` Eric Biggers
2020-07-03 19:20 ` [f2fs-dev] " Eric Biggers
2020-06-24 4:33 ` [PATCH v9 3/4] f2fs: Use generic " Daniel Rosenberg
2020-06-24 4:33 ` Daniel Rosenberg
2020-06-24 4:33 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 6:34 ` kernel test robot
2020-06-24 9:55 ` kernel test robot
2020-06-24 10:01 ` kernel test robot
2020-06-24 4:33 ` [PATCH v9 4/4] ext4: " Daniel Rosenberg
2020-06-24 4:33 ` Daniel Rosenberg
2020-06-24 4:33 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 5:43 ` Gabriel Krisman Bertazi
2020-06-24 5:43 ` Gabriel Krisman Bertazi
2020-06-24 5:43 ` [f2fs-dev] " Gabriel Krisman Bertazi
2020-07-07 10:44 ` Daniel Rosenberg
2020-07-07 10:44 ` Daniel Rosenberg
2020-07-07 10:44 ` [f2fs-dev] " Daniel Rosenberg via Linux-f2fs-devel
2020-06-24 6:04 ` Eric Biggers
2020-06-24 6:04 ` Eric Biggers
2020-06-24 6:04 ` [f2fs-dev] " Eric Biggers
2020-06-24 5:34 ` [PATCH v9 0/4] Prepare for upcoming Casefolding/Encryption patches Eric Biggers
2020-06-24 5:34 ` Eric Biggers
2020-06-24 5:34 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624053729.GE844@sol.localdomain \
--to=ebiggers@kernel.org \
--cc=adilger.kernel@dilger.ca \
--cc=chao@kernel.org \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=krisman@collabora.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.