From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] ANDROID: ext4: fix boolreturn.cocci warnings
Date: Thu, 25 Jun 2020 09:59:09 +0800 [thread overview]
Message-ID: <20200625015909.GA14809@f467103b09cf> (raw)
In-Reply-To: <202006250904.pZzaW30W%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]
From: kernel test robot <lkp@intel.com>
fs/ext4/namei.c:1428:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool
Return statements in functions returning bool should use
true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci
Fixes: b10c4acd41e8 ("ANDROID: ext4: Handle casefolding with encryption")
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://android.googlesource.com/kernel/common android-4.14-stable
head: 6ccc4309743b5cd821584d30fc971dd375bb976c
commit: b10c4acd41e8b15cff1119e2100adf36b013b840 [1/2] ANDROID: ext4: Handle casefolding with encryption
namei.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1425,7 +1425,7 @@ static bool ext4_match(struct inode *par
if (hinfo.hash != EXT4_DIRENT_HASH(de) ||
hinfo.minor_hash !=
EXT4_DIRENT_MINOR_HASH(de))
- return 0;
+ return false;
}
return !ext4_ci_compare(parent, &cf, de->name,
de->name_len, true);
prev parent reply other threads:[~2020-06-25 1:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 1:59 [android-common:android-4.14-stable 1/2] fs/ext4/namei.c:1428:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool kernel test robot
2020-06-25 1:59 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625015909.GA14809@f467103b09cf \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.