All of lore.kernel.org
 help / color / mirror / Atom feed
* [android-common:android-4.14-stable 1/2] fs/ext4/namei.c:1428:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool
@ 2020-06-25  1:59 kernel test robot
  2020-06-25  1:59 ` [PATCH] ANDROID: ext4: fix boolreturn.cocci warnings kernel test robot
  0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-06-25  1:59 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 784 bytes --]

tree:   https://android.googlesource.com/kernel/common android-4.14-stable
head:   6ccc4309743b5cd821584d30fc971dd375bb976c
commit: b10c4acd41e8b15cff1119e2100adf36b013b840 [1/2] ANDROID: ext4: Handle casefolding with encryption
config: i386-randconfig-c001-20200624 (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


coccinelle warnings: (new ones prefixed by >>)

>> fs/ext4/namei.c:1428:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool

Please review and possibly fold the followup patch.

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 27443 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] ANDROID: ext4: fix boolreturn.cocci warnings
  2020-06-25  1:59 [android-common:android-4.14-stable 1/2] fs/ext4/namei.c:1428:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool kernel test robot
@ 2020-06-25  1:59 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-06-25  1:59 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

From: kernel test robot <lkp@intel.com>

fs/ext4/namei.c:1428:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: b10c4acd41e8 ("ANDROID: ext4: Handle casefolding with encryption")
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://android.googlesource.com/kernel/common android-4.14-stable
head:   6ccc4309743b5cd821584d30fc971dd375bb976c
commit: b10c4acd41e8b15cff1119e2100adf36b013b840 [1/2] ANDROID: ext4: Handle casefolding with encryption

 namei.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/ext4/namei.c
+++ b/fs/ext4/namei.c
@@ -1425,7 +1425,7 @@ static bool ext4_match(struct inode *par
 				if (hinfo.hash != EXT4_DIRENT_HASH(de) ||
 						hinfo.minor_hash !=
 						    EXT4_DIRENT_MINOR_HASH(de))
-					return 0;
+					return false;
 			}
 			return !ext4_ci_compare(parent, &cf, de->name,
 							de->name_len, true);

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-06-25  1:59 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-25  1:59 [android-common:android-4.14-stable 1/2] fs/ext4/namei.c:1428:12-13: WARNING: return of 0/1 in function 'ext4_match' with return type bool kernel test robot
2020-06-25  1:59 ` [PATCH] ANDROID: ext4: fix boolreturn.cocci warnings kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.