All of lore.kernel.org
 help / color / mirror / Atom feed
From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Sagi Grimberg <sagi@grimberg.me>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	Jens Axboe <axboe@fb.com>, Keith Busch <kbusch@kernel.org>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v2 0/2] remove workarounds for gcc bug wrt unnamed fields in initializers
Date: Thu, 25 Jun 2020 11:10:15 +0000	[thread overview]
Message-ID: <20200625111012.GA418830@localhost.localdomain> (raw)
In-Reply-To: <BYAPR04MB49655BD99E428B66EBB831E486950@BYAPR04MB4965.namprd04.prod.outlook.com>

On Wed, Jun 24, 2020 at 10:40:21PM +0000, Chaitanya Kulkarni wrote:
> Christoph, Sagi and Keith,
> 
> On 6/24/20 9:44 AM, Christoph Hellwig wrote:
> > This looks good to me, but I'd rather wait a few releases to
> > avoid too mush backporting pain.
> > 
> 
> Here is a summary, for longer explanation please have a look at the
> end [1] :-
> 
> Pros:
> 1. Code looks uniform and follows strict policy.
> 
> Cons:
> 1. Adds a tab + more char [1] which can lead to line breaks and that can
>     be avoided without following declare-init pattern, less bugs and
>     no pressure to fit the initializer in ~72 char given that we do have
>     some long names and who knows what is in the future.

[BEGIN being silly.. sorry guys, I couldn't resist.. :)]

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/checkpatch.pl?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144

Isn't 100 the new 80? ;)

[END being silly]
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme

WARNING: multiple messages have this Message-ID (diff)
From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
Cc: Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>,
	Sagi Grimberg <sagi@grimberg.me>, Jens Axboe <axboe@fb.com>,
	"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 0/2] remove workarounds for gcc bug wrt unnamed fields in initializers
Date: Thu, 25 Jun 2020 11:10:15 +0000	[thread overview]
Message-ID: <20200625111012.GA418830@localhost.localdomain> (raw)
In-Reply-To: <BYAPR04MB49655BD99E428B66EBB831E486950@BYAPR04MB4965.namprd04.prod.outlook.com>

On Wed, Jun 24, 2020 at 10:40:21PM +0000, Chaitanya Kulkarni wrote:
> Christoph, Sagi and Keith,
> 
> On 6/24/20 9:44 AM, Christoph Hellwig wrote:
> > This looks good to me, but I'd rather wait a few releases to
> > avoid too mush backporting pain.
> > 
> 
> Here is a summary, for longer explanation please have a look at the
> end [1] :-
> 
> Pros:
> 1. Code looks uniform and follows strict policy.
> 
> Cons:
> 1. Adds a tab + more char [1] which can lead to line breaks and that can
>     be avoided without following declare-init pattern, less bugs and
>     no pressure to fit the initializer in ~72 char given that we do have
>     some long names and who knows what is in the future.

[BEGIN being silly.. sorry guys, I couldn't resist.. :)]

https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/scripts/checkpatch.pl?id=bdc48fa11e46f867ea4d75fa59ee87a7f48be144

Isn't 100 the new 80? ;)

[END being silly]

  reply	other threads:[~2020-06-25 11:10 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-18 20:02 [PATCH v2 0/2] remove workarounds for gcc bug wrt unnamed fields in initializers Niklas Cassel
2020-06-18 20:02 ` Niklas Cassel
2020-06-18 20:02 ` [PATCH v2 1/2] nvme: " Niklas Cassel
2020-06-18 20:02   ` Niklas Cassel
2020-06-18 20:02 ` [PATCH v2 2/2] nvmet: " Niklas Cassel
2020-06-18 20:02   ` Niklas Cassel
2020-06-24 16:44 ` [PATCH v2 0/2] " Christoph Hellwig
2020-06-24 16:44   ` Christoph Hellwig
2020-06-24 16:57   ` Niklas Cassel
2020-06-24 16:57     ` Niklas Cassel
2020-06-24 17:02     ` Christoph Hellwig
2020-06-24 17:02       ` Christoph Hellwig
2020-06-24 17:08       ` Niklas Cassel
2020-06-24 17:08         ` Niklas Cassel
2020-06-24 22:40   ` Chaitanya Kulkarni
2020-06-24 22:40     ` Chaitanya Kulkarni
2020-06-25 11:10     ` Niklas Cassel [this message]
2020-06-25 11:10       ` Niklas Cassel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200625111012.GA418830@localhost.localdomain \
    --to=niklas.cassel@wdc.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@fb.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.