From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] regulator: devres: Fix issues with kerneldoc headers
Date: Thu, 25 Jun 2020 18:28:13 +0100 [thread overview]
Message-ID: <20200625172813.GD5686@sirena.org.uk> (raw)
In-Reply-To: <20200625163614.4001403-3-lee.jones@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 357 bytes --]
On Thu, Jun 25, 2020 at 05:36:06PM +0100, Lee Jones wrote:
> /**
> * devm_regulator_register - Resource managed regulator_register()
> + * @dev: device for regulator "consumer"
> * @regulator_desc: regulator to register
> * @config: runtime configuration for regulator
> *
That's an odd style you're using in your "change" here - why the quotes?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/10] regulator: devres: Fix issues with kerneldoc headers
Date: Thu, 25 Jun 2020 18:28:13 +0100 [thread overview]
Message-ID: <20200625172813.GD5686@sirena.org.uk> (raw)
In-Reply-To: <20200625163614.4001403-3-lee.jones@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 357 bytes --]
On Thu, Jun 25, 2020 at 05:36:06PM +0100, Lee Jones wrote:
> /**
> * devm_regulator_register - Resource managed regulator_register()
> + * @dev: device for regulator "consumer"
> * @regulator_desc: regulator to register
> * @config: runtime configuration for regulator
> *
That's an odd style you're using in your "change" here - why the quotes?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-06-26 12:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 16:36 [PATCH 00/10] Fix a bunch of W=1 warnings in Regulator Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 16:36 ` [PATCH 01/10] regulator: consumer: Supply missing prototypes for 3 core functions Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 16:36 ` [PATCH 02/10] regulator: devres: Fix issues with kerneldoc headers Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 17:28 ` Mark Brown [this message]
2020-06-25 17:28 ` Mark Brown
2020-06-25 18:42 ` Lee Jones
2020-06-25 18:42 ` Lee Jones
2020-06-25 18:45 ` Mark Brown
2020-06-25 18:45 ` Mark Brown
2020-06-25 16:36 ` [PATCH 03/10] regulator: of_regulator: Add missing colon for rdev kerneldoc argument Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 17:29 ` Mark Brown
2020-06-25 17:29 ` Mark Brown
2020-06-25 18:42 ` Lee Jones
2020-06-25 18:42 ` Lee Jones
2020-06-25 16:36 ` [PATCH 04/10] regulator: dbx500-prcmu: Remove unused function dbx500_regulator_testcase() Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 16:36 ` [PATCH 05/10] regulator: ab8500: Remove unused embedded struct expand_register Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 16:36 ` [PATCH 06/10] regulator: wm8350-regulator: Repair odd formatting in documentation Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 16:36 ` [PATCH 07/10] regulator: cpcap-regulator: Remove declared and set, but never used variable 'ignore' Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 16:36 ` [PATCH 08/10] regulator: cpcap-regulator: Demote kerneldoc header to standard comment Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 16:36 ` [PATCH 09/10] regulator: da9063-regulator: Fix .suspend 'initialized field overwritten' warnings Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 17:44 ` Mark Brown
2020-06-25 17:44 ` Mark Brown
2020-06-25 18:43 ` Lee Jones
2020-06-25 18:43 ` Lee Jones
2020-06-25 16:36 ` [PATCH 10/10] regulator: max14577-regulator: Demote kerneldoc header to standard comment Lee Jones
2020-06-25 16:36 ` Lee Jones
2020-06-25 19:58 ` [PATCH 00/10] Fix a bunch of W=1 warnings in Regulator Mark Brown
2020-06-25 19:58 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200625172813.GD5686@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.