From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH 13/22] snic: use tagset iter for traversing commands
Date: Fri, 26 Jun 2020 06:55:13 +0800 [thread overview]
Message-ID: <202006260620.ryY580jV%lkp@intel.com> (raw)
In-Reply-To: <20200625140124.17201-14-hare@suse.de>
[-- Attachment #1: Type: text/plain, Size: 7520 bytes --]
Hi Hannes,
I love your patch! Perhaps something to improve:
[auto build test WARNING on mkp-scsi/for-next]
[also build test WARNING on scsi/for-next block/for-next linus/master v5.8-rc2 next-20200625]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi-enable-reserved-commands-for-LLDDs/20200625-220401
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 8911a35180c6777188fefe0954a2451a2b91deaf)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/scsi/snic/snic_scsi.c:2444:18: warning: variable 'tag' is uninitialized when used here [-Wuninitialized]
sc, rqi, tag, CMD_FLAGS(sc));
^~~
drivers/scsi/snic/snic.h:149:40: note: expanded from macro 'SNIC_SCSI_DBG'
shost_printk(KERN_INFO, host, fmt, ##args);)
^~~~
include/scsi/scsi_host.h:712:52: note: expanded from macro 'shost_printk'
dev_printk(prefix, &(shost)->shost_gendev, fmt, ##a)
^
drivers/scsi/snic/snic.h:139:4: note: expanded from macro 'SNIC_CHECK_LOGGING'
CMD; \
^~~
drivers/scsi/snic/snic_scsi.c:2421:9: note: initialize the variable 'tag' to silence this warning
int tag;
^
= 0
1 warning generated.
vim +/tag +2444 drivers/scsi/snic/snic_scsi.c
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2413
43d12ab32f0fb6 Hannes Reinecke 2020-06-25 2414 static bool
43d12ab32f0fb6 Hannes Reinecke 2020-06-25 2415 snic_scsi_cleanup_iter(struct scsi_cmnd *sc, void *data, bool rsvd)
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2416 {
43d12ab32f0fb6 Hannes Reinecke 2020-06-25 2417 struct snic *snic = data;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2418 struct snic_req_info *rqi = NULL;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2419 spinlock_t *io_lock = NULL;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2420 unsigned long flags;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2421 int tag;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2422 u64 st_time = 0;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2423
43d12ab32f0fb6 Hannes Reinecke 2020-06-25 2424 io_lock = snic_io_lock_tag(snic, sc->request->tag);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2425 spin_lock_irqsave(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2426 if (unlikely(snic_tmreq_pending(sc))) {
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2427 /*
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2428 * When FW Completes reset w/o sending completions
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2429 * for outstanding ios.
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2430 */
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2431 snic_cmpl_pending_tmreq(snic, sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2432 spin_unlock_irqrestore(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2433
43d12ab32f0fb6 Hannes Reinecke 2020-06-25 2434 return true;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2435 }
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2436 rqi = (struct snic_req_info *) CMD_SP(sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2437 if (!rqi) {
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2438 spin_unlock_irqrestore(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2439 goto cleanup;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2440 }
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2441
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2442 SNIC_SCSI_DBG(snic->shost,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2443 "sc_clean: sc %p, rqi %p, tag %d flags 0x%llx\n",
c8806b6c9e824f Narsimhulu Musini 2015-05-29 @2444 sc, rqi, tag, CMD_FLAGS(sc));
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2445
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2446 CMD_SP(sc) = NULL;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2447 CMD_FLAGS(sc) |= SNIC_SCSI_CLEANUP;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2448 spin_unlock_irqrestore(io_lock, flags);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2449 st_time = rqi->start_time;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2450
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2451 SNIC_HOST_INFO(snic->shost,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2452 "sc_clean: Releasing rqi %p : flags 0x%llx\n",
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2453 rqi, CMD_FLAGS(sc));
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2454
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2455 snic_release_req_buf(snic, rqi, sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2456
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2457 cleanup:
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2458 sc->result = DID_TRANSPORT_DISRUPTED << 16;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2459 SNIC_HOST_INFO(snic->shost,
3f5c11a463fd87 Narsimhulu Musini 2016-03-17 2460 "sc_clean: DID_TRANSPORT_DISRUPTED for sc %p, Tag %d flags 0x%llx rqi %p duration %u msecs\n",
3f5c11a463fd87 Narsimhulu Musini 2016-03-17 2461 sc, sc->request->tag, CMD_FLAGS(sc), rqi,
3f5c11a463fd87 Narsimhulu Musini 2016-03-17 2462 jiffies_to_msecs(jiffies - st_time));
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2463
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2464 /* Update IO stats */
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2465 snic_stats_update_io_cmpl(&snic->s_stats);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2466
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2467 if (sc->scsi_done) {
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2468 SNIC_TRC(snic->shost->host_no, tag, (ulong) sc,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2469 jiffies_to_msecs(jiffies - st_time), 0,
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2470 SNIC_TRC_CMD(sc),
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2471 SNIC_TRC_CMD_STATE_FLAGS(sc));
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2472
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2473 sc->scsi_done(sc);
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2474 }
43d12ab32f0fb6 Hannes Reinecke 2020-06-25 2475 return true;
c8806b6c9e824f Narsimhulu Musini 2015-05-29 2476 }
43d12ab32f0fb6 Hannes Reinecke 2020-06-25 2477
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 75325 bytes --]
next prev parent reply other threads:[~2020-06-25 22:55 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 14:01 [PATCHv4 00/22] scsi: enable reserved commands for LLDDs Hannes Reinecke
2020-06-25 14:01 ` [PATCH 01/22] scsi: drop gdth driver Hannes Reinecke
2020-06-28 3:38 ` Bart Van Assche
2020-06-25 14:01 ` [PATCH 02/22] block: add flag for internal commands Hannes Reinecke
2020-06-28 3:43 ` Bart Van Assche
2020-06-28 10:13 ` Hannes Reinecke
2020-06-25 14:01 ` [PATCH 03/22] scsi: add scsi_{get,put}_internal_cmd() helper Hannes Reinecke
2020-06-28 3:48 ` Bart Van Assche
2020-06-28 9:02 ` Hannes Reinecke
2020-06-28 15:08 ` Bart Van Assche
2020-06-29 6:32 ` Hannes Reinecke
2020-06-29 14:24 ` John Garry
2020-06-29 14:38 ` Bart Van Assche
2020-06-25 14:01 ` [PATCH 04/22] fnic: use internal commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 05/22] fnic: use scsi_host_busy_iter() to traverse commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 06/22] fnic: check for started requests in fnic_wq_copy_cleanup_handler() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 07/22] csiostor: use internal command for LUN reset Hannes Reinecke
2020-06-25 14:01 ` [PATCH 08/22] scsi: implement reserved command handling Hannes Reinecke
2020-06-25 15:30 ` John Garry
2020-06-25 15:59 ` Hannes Reinecke
2020-06-25 14:01 ` [PATCH 09/22] scsi: use real inquiry data when initialising devices Hannes Reinecke
2020-06-25 14:01 ` [PATCH 10/22] scsi: Use dummy inquiry data for the host device Hannes Reinecke
2020-06-25 14:01 ` [PATCH 11/22] scsi: revamp host device handling Hannes Reinecke
2020-06-25 14:01 ` [PATCH 12/22] snic: use reserved commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 13/22] snic: use tagset iter for traversing commands Hannes Reinecke
2020-06-25 22:55 ` kernel test robot [this message]
2020-06-25 14:01 ` [PATCH 14/22] snic: check for started requests in snic_hba_reset_cmpl_handler() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 15/22] hpsa: move hpsa_hba_inquiry after scsi_add_host() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 16/22] hpsa: use reserved commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 17/22] hpsa: use scsi_host_busy_iter() to traverse outstanding commands Hannes Reinecke
2020-06-25 14:01 ` [PATCH 18/22] hpsa: drop refcount field from CommandList Hannes Reinecke
2020-06-25 14:01 ` [PATCH 19/22] aacraid: move scsi_add_host() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 20/22] aacraid: store target id in host_scribble Hannes Reinecke
2020-06-25 14:01 ` [PATCH 21/22] aacraid: use scsi_get_internal_cmd() Hannes Reinecke
2020-06-25 14:01 ` [PATCH 22/22] aacraid: use scsi_host_busy_iter() to traverse outstanding commands Hannes Reinecke
-- strict thread matches above, loose matches on Subject: below --
2020-06-29 7:19 [PATCHv5 00/22] scsi: enable reserved commands for LLDDs Hannes Reinecke
2020-06-29 7:20 ` [PATCH 13/22] snic: use tagset iter for traversing commands Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006260620.ryY580jV%lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.