All of lore.kernel.org
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable()
Date: Fri, 26 Jun 2020 10:35:08 +0000	[thread overview]
Message-ID: <20200626123508.0a726db3@collabora.com> (raw)
In-Reply-To: <20200626103401.GA314359@mwanda>

On Fri, 26 Jun 2020 13:34:01 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The problem is that the iterator is already at the list head so the
> list_for_each_entry_from() loop is a no-op and we don't call the
> the iter->funcs->post_disable() functions.  This should be
> list_for_each_entry() instead.
> 
> Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index eaf276978ee7..f92d0e92fa72 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -754,7 +754,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
>  
>  	vc4_dsi_ulps(dsi, true);
>  
> -	list_for_each_entry_from(iter, &dsi->bridge_chain, chain_node) {
> +	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
>  		if (iter->funcs->post_disable)
>  			iter->funcs->post_disable(iter);
>  	}

WARNING: multiple messages have this Message-ID (diff)
From: Boris Brezillon <boris.brezillon@collabora.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
	David Airlie <airlied@linux.ie>,
	kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable()
Date: Fri, 26 Jun 2020 12:35:08 +0200	[thread overview]
Message-ID: <20200626123508.0a726db3@collabora.com> (raw)
In-Reply-To: <20200626103401.GA314359@mwanda>

On Fri, 26 Jun 2020 13:34:01 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:

> The problem is that the iterator is already at the list head so the
> list_for_each_entry_from() loop is a no-op and we don't call the
> the iter->funcs->post_disable() functions.  This should be
> list_for_each_entry() instead.
> 
> Fixes: 033bfe7538a1 ("drm/vc4: dsi: Fix bridge chain handling")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com>

> ---
>  drivers/gpu/drm/vc4/vc4_dsi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
> index eaf276978ee7..f92d0e92fa72 100644
> --- a/drivers/gpu/drm/vc4/vc4_dsi.c
> +++ b/drivers/gpu/drm/vc4/vc4_dsi.c
> @@ -754,7 +754,7 @@ static void vc4_dsi_encoder_disable(struct drm_encoder *encoder)
>  
>  	vc4_dsi_ulps(dsi, true);
>  
> -	list_for_each_entry_from(iter, &dsi->bridge_chain, chain_node) {
> +	list_for_each_entry(iter, &dsi->bridge_chain, chain_node) {
>  		if (iter->funcs->post_disable)
>  			iter->funcs->post_disable(iter);
>  	}

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-06-26 10:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-26 10:34 [PATCH] drm/vc4: call ->post_disable() functions in vc4_dsi_encoder_disable() Dan Carpenter
2020-06-26 10:34 ` Dan Carpenter
2020-06-26 10:35 ` Boris Brezillon [this message]
2020-06-26 10:35   ` Boris Brezillon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200626123508.0a726db3@collabora.com \
    --to=boris.brezillon@collabora.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.