From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: Boris Brezillon <boris.brezillon@free-electrons.com>,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Ludovic Desroches <ludovic.desroches@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments
Date: Fri, 26 Jun 2020 22:56:58 +0200 [thread overview]
Message-ID: <20200626205658.GV131826@piout.net> (raw)
In-Reply-To: <20200625064619.2775707-10-lee.jones@linaro.org>
On 25/06/2020 07:46:18+0100, Lee Jones wrote:
> Kerneldoc valication gets confused if syntax isn't "@.*: ".
>
> Adding the missing colons squashes the following W=1 warnings:
>
> drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply'
> drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply'
>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: <stable@vger.kernel.org>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/atmel-smc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
> index 17bbe9d1fa740..4aac96d213369 100644
> --- a/drivers/mfd/atmel-smc.c
> +++ b/drivers/mfd/atmel-smc.c
> @@ -237,7 +237,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle);
> * atmel_smc_cs_conf_apply - apply an SMC CS conf
> * @regmap: the SMC regmap
> * @cs: the CS id
> - * @conf the SMC CS conf to apply
> + * @conf: the SMC CS conf to apply
> *
> * Applies an SMC CS configuration.
> * Only valid on at91sam9/avr32 SoCs.
> @@ -257,7 +257,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply);
> * @regmap: the HSMC regmap
> * @cs: the CS id
> * @layout: the layout of registers
> - * @conf the SMC CS conf to apply
> + * @conf: the SMC CS conf to apply
> *
> * Applies an SMC CS configuration.
> * Only valid on post-sama5 SoCs.
> --
> 2.25.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Lee Jones <lee.jones@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Nicolas Ferre <nicolas.ferre@microchip.com>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Boris Brezillon <boris.brezillon@free-electrons.com>
Subject: Re: [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments
Date: Fri, 26 Jun 2020 22:56:58 +0200 [thread overview]
Message-ID: <20200626205658.GV131826@piout.net> (raw)
In-Reply-To: <20200625064619.2775707-10-lee.jones@linaro.org>
On 25/06/2020 07:46:18+0100, Lee Jones wrote:
> Kerneldoc valication gets confused if syntax isn't "@.*: ".
>
> Adding the missing colons squashes the following W=1 warnings:
>
> drivers/mfd/atmel-smc.c:247: warning: Function parameter or member 'conf' not described in 'atmel_smc_cs_conf_apply'
> drivers/mfd/atmel-smc.c:268: warning: Function parameter or member 'conf' not described in 'atmel_hsmc_cs_conf_apply'
>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: <stable@vger.kernel.org>
> Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
> Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>
> Cc: Ludovic Desroches <ludovic.desroches@microchip.com>
> Cc: Boris Brezillon <boris.brezillon@free-electrons.com>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mfd/atmel-smc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/atmel-smc.c b/drivers/mfd/atmel-smc.c
> index 17bbe9d1fa740..4aac96d213369 100644
> --- a/drivers/mfd/atmel-smc.c
> +++ b/drivers/mfd/atmel-smc.c
> @@ -237,7 +237,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_set_cycle);
> * atmel_smc_cs_conf_apply - apply an SMC CS conf
> * @regmap: the SMC regmap
> * @cs: the CS id
> - * @conf the SMC CS conf to apply
> + * @conf: the SMC CS conf to apply
> *
> * Applies an SMC CS configuration.
> * Only valid on at91sam9/avr32 SoCs.
> @@ -257,7 +257,7 @@ EXPORT_SYMBOL_GPL(atmel_smc_cs_conf_apply);
> * @regmap: the HSMC regmap
> * @cs: the CS id
> * @layout: the layout of registers
> - * @conf the SMC CS conf to apply
> + * @conf: the SMC CS conf to apply
> *
> * Applies an SMC CS configuration.
> * Only valid on post-sama5 SoCs.
> --
> 2.25.1
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2020-06-26 20:58 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-25 6:46 [PATCH 00/10] Fix a bunch more W=1 warnings in MFD Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-06-25 6:46 ` [PATCH 01/10] mfd: wm8350-core: Supply description wm8350_reg_{un}lock args Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-06-25 6:56 ` Greg KH
2020-06-25 6:56 ` Greg KH
2020-06-25 7:13 ` Lee Jones
2020-06-25 7:13 ` Lee Jones
2020-06-25 9:45 ` Greg KH
2020-06-25 9:45 ` Greg KH
2020-06-25 13:34 ` Lee Jones
2020-06-25 13:34 ` Lee Jones
2020-06-25 13:24 ` Jonathan Corbet
2020-06-25 13:24 ` Jonathan Corbet
2020-06-25 13:38 ` Lee Jones
2020-06-25 13:38 ` Lee Jones
2020-06-25 6:46 ` [PATCH 02/10] mfd: mfd-core: Complete kerneldoc header for devm_mfd_add_devices() Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-07-01 19:33 ` Sasha Levin
2020-07-01 19:33 ` Sasha Levin
2020-07-02 6:36 ` Lee Jones
2020-07-02 6:36 ` Lee Jones
2020-07-10 14:02 ` Sasha Levin
2020-07-10 14:02 ` Sasha Levin
2020-06-25 6:46 ` [PATCH 03/10] mfd: db8500-prcmu: Add description for 'reset_reason' in kerneldoc Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-07-07 12:39 ` Linus Walleij
2020-07-07 12:39 ` Linus Walleij
2020-06-25 6:46 ` [PATCH 04/10] mfd: db8500-prcmu: Remove incorrect function header from .probe() function Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-07-07 12:39 ` Linus Walleij
2020-07-07 12:39 ` Linus Walleij
2020-06-25 6:46 ` [PATCH 05/10] mfd: omap-usb-host: Remove invalid use of kerneldoc syntax Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-06-25 6:46 ` [PATCH 06/10] mfd: omap-usb-host: Provide description for 'pdev' argument to .probe() Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-06-25 6:46 ` [PATCH 07/10] mfd: omap-usb-tll: " Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-06-25 6:46 ` [PATCH 08/10] mfd: atmel-smc: Silence comparison of unsigned expression < 0 is always false warning (W=1) Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-06-26 20:56 ` Alexandre Belloni
2020-06-26 20:56 ` Alexandre Belloni
2020-06-30 12:10 ` Lee Jones
2020-06-30 12:10 ` Lee Jones
2020-06-25 6:46 ` [PATCH 09/10] mfd: atmel-smc: Add missing colon(s) for 'conf' arguments Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-06-25 6:55 ` Greg KH
2020-06-25 6:55 ` Greg KH
2020-06-26 20:56 ` Alexandre Belloni [this message]
2020-06-26 20:56 ` Alexandre Belloni
2020-07-01 19:33 ` Sasha Levin
2020-07-01 19:33 ` Sasha Levin
2020-07-02 6:36 ` Lee Jones
2020-07-02 6:36 ` Lee Jones
2020-07-10 14:02 ` Sasha Levin
2020-07-10 14:02 ` Sasha Levin
2020-06-25 6:46 ` [PATCH 10/10] mfd: altera-sysmgr: Supply descriptions for 'np' and 'property' function args Lee Jones
2020-06-25 6:46 ` Lee Jones
2020-07-01 19:33 ` Sasha Levin
2020-07-01 19:33 ` Sasha Levin
2020-07-02 6:35 ` Lee Jones
2020-07-02 6:35 ` Lee Jones
2020-07-10 14:02 ` Sasha Levin
2020-07-10 14:02 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200626205658.GV131826@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@free-electrons.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ludovic.desroches@microchip.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.