All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: richard.gong@linux.intel.com, atull@kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code
Date: Sat, 27 Jun 2020 05:15:09 +0000	[thread overview]
Message-ID: <20200627051509.GC233327@kroah.com> (raw)
In-Reply-To: <20200626193720.949431-1-christophe.jaillet@wanadoo.fr>

On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote:
> Fix several error handling issues:

<snip>

When you have to list a bunch of different things you do in a driver,
that's a huge hint this needs to be broken up into multiple patches.

Please do that here.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: richard.gong@linux.intel.com, atull@kernel.org,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH V3] firmware: stratix10-svc: Fix some error handling code
Date: Sat, 27 Jun 2020 07:15:09 +0200	[thread overview]
Message-ID: <20200627051509.GC233327@kroah.com> (raw)
In-Reply-To: <20200626193720.949431-1-christophe.jaillet@wanadoo.fr>

On Fri, Jun 26, 2020 at 09:37:20PM +0200, Christophe JAILLET wrote:
> Fix several error handling issues:

<snip>

When you have to list a bunch of different things you do in a driver,
that's a huge hint this needs to be broken up into multiple patches.

Please do that here.

thanks,

greg k-h

  reply	other threads:[~2020-06-27  5:15 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  6:52 [PATCH 0/4 v2] firmware: stratix10-svc: Fix some error handling code Christophe JAILLET
2020-04-29  6:52 ` Christophe JAILLET
2020-04-29  6:52 ` [PATCH 1/4 v2] firmware: stratix10-svc: Fix genpool creation error handling Christophe JAILLET
2020-04-29  6:52   ` Christophe JAILLET
2020-04-29  9:50   ` Markus Elfring
2020-04-29  9:50     ` Markus Elfring
2020-04-29  6:52 ` [PATCH 2/4 v2] firmware: stratix10-svc: Unmap some previously memremap'ed memory Christophe JAILLET
2020-04-29  6:52   ` Christophe JAILLET
2020-05-05 14:43   ` Greg KH
2020-05-05 14:43     ` Greg KH
2020-05-05 15:09     ` Christophe JAILLET
2020-05-05 15:09       ` Christophe JAILLET
2020-04-29  6:52 ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_probe()' Christophe JAILLET
2020-04-29  6:52   ` Christophe JAILLET
2020-04-29 11:51   ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in stratix10_svc_drv_probe Markus Elfring
2020-04-29 11:51     ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in stratix10_svc_drv_probe() Markus Elfring
2020-05-05 13:46   ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_prob Richard Gong
2020-05-05 14:02     ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_probe()' Richard Gong
2020-05-05 15:15     ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_prob Christophe JAILLET
2020-05-05 15:15       ` [PATCH 3/4 v2] firmware: stratix10-svc: Fix some error handling paths in 'stratix10_svc_drv_probe()' Christophe JAILLET
2020-06-26 19:37       ` [PATCH V3] firmware: stratix10-svc: Fix some error handling code Christophe JAILLET
2020-06-26 19:37         ` Christophe JAILLET
2020-06-27  5:15         ` Greg KH [this message]
2020-06-27  5:15           ` Greg KH
2020-06-27  5:15         ` Greg KH
2020-06-27  5:15           ` Greg KH
2020-06-27  7:31           ` Marion & Christophe JAILLET
2020-06-27  7:31             ` Marion & Christophe JAILLET
2020-06-27  8:03             ` Greg KH
2020-06-27  8:03               ` Greg KH
2020-04-29  6:52 ` [PATCH 4/4 v2] firmware: stratix10-svc: Slightly simplify code Christophe JAILLET
2020-04-29  6:52   ` Christophe JAILLET
2020-04-29 12:41   ` Markus Elfring
2020-04-29 12:41     ` Markus Elfring
2020-05-01 15:40   ` Richard Gong
2020-05-01 15:40     ` Richard Gong
2020-05-01 15:48     ` Christophe JAILLET
2020-05-01 15:48       ` Christophe JAILLET
2020-05-01 16:55       ` Richard Gong
2020-05-01 16:55         ` Richard Gong
2020-05-02  8:49         ` Christophe JAILLET
2020-05-02  8:49           ` Christophe JAILLET
2020-05-05 14:18           ` Richard Gong
2020-05-05 14:18             ` Richard Gong
2020-05-06 10:04     ` Dan Carpenter
2020-05-06 10:04       ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200627051509.GC233327@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=atull@kernel.org \
    --cc=christophe.jaillet@wanadoo.fr \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=richard.gong@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.