From: Dan Carpenter <dan.carpenter@oracle.com>
To: Richard Weinberger <richard@nod.at>
Cc: linux-kernel@vger.kernel.org, sumit.semwal@linaro.org,
iommu@lists.linux-foundation.org, robin.murphy@arm.com,
hch@lst.de
Subject: Re: Passing NULL dev to dma_alloc_coherent() allowed or not?
Date: Sat, 27 Jun 2020 16:09:15 +0300 [thread overview]
Message-ID: <20200627130915.GF2571@kadam> (raw)
In-Reply-To: <1669515915.65540.1593258316061.JavaMail.zimbra@nod.at>
On Sat, Jun 27, 2020 at 01:45:16PM +0200, Richard Weinberger wrote:
> Hi!
>
> While porting on an old out-of-tree driver I noticed that dma_alloc_coherent()
> was used with dev being NULL.
>
> commit 148a97d5a02a62f81b5d6176f871c94a65e1f3af
> Author: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Wed Apr 24 17:24:37 2019 +0300
>
> dma-mapping: remove an unnecessary NULL check
>
> We already dereferenced "dev" when we called get_dma_ops() so this NULL
> check is too late. We're not supposed to pass NULL "dev" pointers to
> dma_alloc_attrs().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> says that dma_alloc_attrs() with dev being NULL is not allowed, but in
> include/linux/dma-mapping.h we have:
>
> static inline void *dma_alloc_coherent(struct device *dev, size_t size,
> dma_addr_t *dma_handle, gfp_t gfp)
> {
>
> return dma_alloc_attrs(dev, size, dma_handle, gfp,
> (gfp & __GFP_NOWARN) ? DMA_ATTR_NO_WARN : 0);
> }
>
> In Linus' tree I see at least three callers of dma_alloc_coherent() with a NULL device.
> drivers/staging/emxx_udc/emxx_udc.c:2596: ep->virt_buf = dma_alloc_coherent(NULL, PAGE_SIZE,
> drivers/tty/synclink.c:3667: info->buffer_list = dma_alloc_coherent(NULL, BUFFERLISTSIZE, &info->buffer_list_dma_addr, GFP_KERNEL);
> drivers/tty/synclink.c:3777: BufferList[i].virt_addr = dma_alloc_coherent(NULL, DMABUFFERSIZE, &BufferList[i].dma_addr, GFP_KERNEL);
>
> I think these callers are wrong.
> Can you please clarify?
The are wrong. It was slightly worse when I originally sent the patch
but we fixed comedi.
https://lkml.org/lkml/2019/4/24/668
regards,
dan carpenter
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Richard Weinberger <richard@nod.at>
Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
sumit.semwal@linaro.org, robin.murphy@arm.com,
m.szyprowski@samsung.com, hch@lst.de
Subject: Re: Passing NULL dev to dma_alloc_coherent() allowed or not?
Date: Sat, 27 Jun 2020 16:09:15 +0300 [thread overview]
Message-ID: <20200627130915.GF2571@kadam> (raw)
In-Reply-To: <1669515915.65540.1593258316061.JavaMail.zimbra@nod.at>
On Sat, Jun 27, 2020 at 01:45:16PM +0200, Richard Weinberger wrote:
> Hi!
>
> While porting on an old out-of-tree driver I noticed that dma_alloc_coherent()
> was used with dev being NULL.
>
> commit 148a97d5a02a62f81b5d6176f871c94a65e1f3af
> Author: Dan Carpenter <dan.carpenter@oracle.com>
> Date: Wed Apr 24 17:24:37 2019 +0300
>
> dma-mapping: remove an unnecessary NULL check
>
> We already dereferenced "dev" when we called get_dma_ops() so this NULL
> check is too late. We're not supposed to pass NULL "dev" pointers to
> dma_alloc_attrs().
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
>
> says that dma_alloc_attrs() with dev being NULL is not allowed, but in
> include/linux/dma-mapping.h we have:
>
> static inline void *dma_alloc_coherent(struct device *dev, size_t size,
> dma_addr_t *dma_handle, gfp_t gfp)
> {
>
> return dma_alloc_attrs(dev, size, dma_handle, gfp,
> (gfp & __GFP_NOWARN) ? DMA_ATTR_NO_WARN : 0);
> }
>
> In Linus' tree I see at least three callers of dma_alloc_coherent() with a NULL device.
> drivers/staging/emxx_udc/emxx_udc.c:2596: ep->virt_buf = dma_alloc_coherent(NULL, PAGE_SIZE,
> drivers/tty/synclink.c:3667: info->buffer_list = dma_alloc_coherent(NULL, BUFFERLISTSIZE, &info->buffer_list_dma_addr, GFP_KERNEL);
> drivers/tty/synclink.c:3777: BufferList[i].virt_addr = dma_alloc_coherent(NULL, DMABUFFERSIZE, &BufferList[i].dma_addr, GFP_KERNEL);
>
> I think these callers are wrong.
> Can you please clarify?
The are wrong. It was slightly worse when I originally sent the patch
but we fixed comedi.
https://lkml.org/lkml/2019/4/24/668
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-27 13:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-27 11:45 Passing NULL dev to dma_alloc_coherent() allowed or not? Richard Weinberger
2020-06-27 11:45 ` Richard Weinberger
2020-06-27 13:09 ` Dan Carpenter [this message]
2020-06-27 13:09 ` Dan Carpenter
2020-06-28 7:10 ` Christoph Hellwig
2020-06-28 7:10 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627130915.GF2571@kadam \
--to=dan.carpenter@oracle.com \
--cc=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=richard@nod.at \
--cc=robin.murphy@arm.com \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.