From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: 'Avri Altman' <avri.altman@wdc.com>,
"'James E.J. Bottomley'" <jejb@linux.ibm.com>,
"'Martin K. Petersen'" <martin.petersen@oracle.com>,
'Kukjin Kim' <kgene@kernel.org>,
'Krzysztof Kozlowski' <krzk@kernel.org>,
'Kiwoong Kim' <kwmad.kim@samsung.com>,
'Wei Yongjun' <weiyongjun1@huawei.com>,
linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check
Date: Sat, 27 Jun 2020 17:54:45 +0000 [thread overview]
Message-ID: <20200627175445.GG2571@kadam> (raw)
In-Reply-To: <041701d64ca7$70bafb80$5230f280$@samsung.com>
On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote:
> Hi Dan
>
> > -----Original Message-----
> > The "head" pointer can't be NULL because it points to an address in the
> middle
> > of a ufs_hba struct. Looking at this code, probably someone would wonder
> if
> > the intent was to check whether "hba" is NULL, but "hba"
> > isn't NULL and the check can just be removed.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> Please add Fixes: tag
> With that
> Acked-by: Alim Akhtar <alim.akhtar@samsung.com>
It's not a bug fix it's just a cleanup.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Alim Akhtar <alim.akhtar@samsung.com>
Cc: "'Avri Altman'" <avri.altman@wdc.com>,
"'James E.J. Bottomley'" <jejb@linux.ibm.com>,
"'Martin K. Petersen'" <martin.petersen@oracle.com>,
"'Kukjin Kim'" <kgene@kernel.org>,
"'Krzysztof Kozlowski'" <krzk@kernel.org>,
"'Kiwoong Kim'" <kwmad.kim@samsung.com>,
"'Wei Yongjun'" <weiyongjun1@huawei.com>,
linux-scsi@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check
Date: Sat, 27 Jun 2020 20:54:45 +0300 [thread overview]
Message-ID: <20200627175445.GG2571@kadam> (raw)
In-Reply-To: <041701d64ca7$70bafb80$5230f280$@samsung.com>
On Sat, Jun 27, 2020 at 10:51:44PM +0530, Alim Akhtar wrote:
> Hi Dan
>
> > -----Original Message-----
> > The "head" pointer can't be NULL because it points to an address in the
> middle
> > of a ufs_hba struct. Looking at this code, probably someone would wonder
> if
> > the intent was to check whether "hba" is NULL, but "hba"
> > isn't NULL and the check can just be removed.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> Please add Fixes: tag
> With that
> Acked-by: Alim Akhtar <alim.akhtar@samsung.com>
It's not a bug fix it's just a cleanup.
regards,
dan carpenter
next prev parent reply other threads:[~2020-06-27 17:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200626105156epcas5p191d18d66af6bd09a10635559461c0bc0@epcas5p1.samsung.com>
2020-06-26 10:51 ` [PATCH] scsi: ufs: ufs-exynos: Remove an unnecessary NULL check Dan Carpenter
2020-06-26 10:51 ` Dan Carpenter
2020-06-27 17:21 ` Alim Akhtar
2020-06-27 17:33 ` Alim Akhtar
2020-06-27 17:54 ` Dan Carpenter [this message]
2020-06-27 17:54 ` Dan Carpenter
2020-06-28 1:56 ` Alim Akhtar
2020-06-28 1:56 ` Alim Akhtar
2020-06-30 3:23 ` Martin K. Petersen
2020-06-30 3:23 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200627175445.GG2571@kadam \
--to=dan.carpenter@oracle.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=kwmad.kim@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.