* [PATCH 1/1] [dunfell][master]: don't select vulkan if directfb enabled.
@ 2020-06-28 3:33 maochenxi
2020-06-28 3:33 ` [PATCH] " Chenxi Mao
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: maochenxi @ 2020-06-28 3:33 UTC (permalink / raw)
To: openembedded-core; +Cc: chenxi.mao2013, Chenxi Mao
vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.
Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
---
.../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
index 7a227fed51..aee001e641 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
@@ -24,7 +24,7 @@ inherit gobject-introspection
PACKAGECONFIG ??= " \
${GSTREAMER_ORC} \
${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
- ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+ ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] [dunfell][master]: don't select vulkan if directfb enabled.
2020-06-28 3:33 [PATCH 1/1] [dunfell][master]: don't select vulkan if directfb enabled maochenxi
@ 2020-06-28 3:33 ` Chenxi Mao
2020-06-29 16:47 ` [OE-core] " Andre McCurdy
2020-06-28 4:02 ` ✗ patchtest: failure for [1/1,dunfell,master] : " Patchwork
2020-06-28 4:02 ` ✗ patchtest: failure for [1/1,dunfell,master] : don't select vulkan if directfb enabled. (rev2) Patchwork
2 siblings, 1 reply; 6+ messages in thread
From: Chenxi Mao @ 2020-06-28 3:33 UTC (permalink / raw)
To: openembedded-core; +Cc: chenxi.mao2013, Chenxi Mao
vulkan didn't support directfb at all.
So remove this configuration if directfb enabled.
Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
---
.../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
index 7a227fed51..aee001e641 100644
--- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
+++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
@@ -24,7 +24,7 @@ inherit gobject-introspection
PACKAGECONFIG ??= " \
${GSTREAMER_ORC} \
${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
- ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
+ ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [OE-core] [PATCH] [dunfell][master]: don't select vulkan if directfb enabled.
2020-06-28 3:33 ` [PATCH] " Chenxi Mao
@ 2020-06-29 16:47 ` Andre McCurdy
2020-06-30 1:34 ` Chenxi Mao
0 siblings, 1 reply; 6+ messages in thread
From: Andre McCurdy @ 2020-06-29 16:47 UTC (permalink / raw)
To: Chenxi Mao; +Cc: OE Core mailing list, chenxi.mao2013
On Sat, Jun 27, 2020 at 8:33 PM Chenxi Mao <maochenxi@eswin.com> wrote:
>
> vulkan didn't support directfb at all.
> So remove this configuration if directfb enabled.
This change doesn't look right. Passing two values to
bb.utils.filter() doesn't imply any dependency between them.
Can you explain what problem you have seen and how to reproduce it?
> Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
> Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
> ---
> .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
> index 7a227fed51..aee001e641 100644
> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
> @@ -24,7 +24,7 @@ inherit gobject-introspection
> PACKAGECONFIG ??= " \
> ${GSTREAMER_ORC} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
> - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
> bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
> --
> 2.25.1
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [OE-core] [PATCH] [dunfell][master]: don't select vulkan if directfb enabled.
2020-06-29 16:47 ` [OE-core] " Andre McCurdy
@ 2020-06-30 1:34 ` Chenxi Mao
0 siblings, 0 replies; 6+ messages in thread
From: Chenxi Mao @ 2020-06-30 1:34 UTC (permalink / raw)
To: Andre McCurdy; +Cc: OE Core mailing list, chenxi.mao2013
Hi Andre:
My reproduce step as below:
I enable directfb and vulkan id DISTRO_FEATURES with QT5.15
Then during vulkan build, it has error message show that the vulkan didn't support directfb.
If I remove vulkan in DISTRO_FEATURES, the build will be passed.
Chenxi
On 2020/6/30 上午12:47, Andre McCurdy wrote:
> On Sat, Jun 27, 2020 at 8:33 PM Chenxi Mao <maochenxi@eswin.com> wrote:
>> vulkan didn't support directfb at all.
>> So remove this configuration if directfb enabled.
> This change doesn't look right. Passing two values to
> bb.utils.filter() doesn't imply any dependency between them.
>
> Can you explain what problem you have seen and how to reproduce it?
>
>> Change-Id: Ia0af5d944e858fbb99a07fcd5f10ab831a93b2d0
>> Signed-off-by: Chenxi Mao <maochenxi@eswin.com>
>> ---
>> .../gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> index 7a227fed51..aee001e641 100644
>> --- a/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> +++ b/meta/recipes-multimedia/gstreamer/gstreamer1.0-plugins-bad_1.16.2.bb
>> @@ -24,7 +24,7 @@ inherit gobject-introspection
>> PACKAGECONFIG ??= " \
>> ${GSTREAMER_ORC} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'bluetooth', 'bluez', '', d)} \
>> - ${@bb.utils.filter('DISTRO_FEATURES', 'directfb vulkan', d)} \
>> + ${@bb.utils.filter('DISTRO_FEATURES', 'directfb', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'wayland', 'wayland', '', d)} \
>> ${@bb.utils.contains('DISTRO_FEATURES', 'opengl', 'gl', '', d)} \
>> bz2 closedcaption curl dash dtls hls rsvg sbc smoothstreaming sndfile \
>> --
>> 2.25.1
>>
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ patchtest: failure for [1/1,dunfell,master] : don't select vulkan if directfb enabled.
2020-06-28 3:33 [PATCH 1/1] [dunfell][master]: don't select vulkan if directfb enabled maochenxi
2020-06-28 3:33 ` [PATCH] " Chenxi Mao
@ 2020-06-28 4:02 ` Patchwork
2020-06-28 4:02 ` ✗ patchtest: failure for [1/1,dunfell,master] : don't select vulkan if directfb enabled. (rev2) Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-06-28 4:02 UTC (permalink / raw)
To: Chenxi Mao; +Cc: openembedded-core
== Series Details ==
Series: [1/1,dunfell,master] : don't select vulkan if directfb enabled.
Revision: 1
URL : https://patchwork.openembedded.org/series/24873/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Patch [1/1,dunfell,master] : don't select vulkan if directfb enabled.
Issue Shortlog does not follow expected format [test_shortlog_format]
Suggested fix Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 6+ messages in thread
* ✗ patchtest: failure for [1/1,dunfell,master] : don't select vulkan if directfb enabled. (rev2)
2020-06-28 3:33 [PATCH 1/1] [dunfell][master]: don't select vulkan if directfb enabled maochenxi
2020-06-28 3:33 ` [PATCH] " Chenxi Mao
2020-06-28 4:02 ` ✗ patchtest: failure for [1/1,dunfell,master] : " Patchwork
@ 2020-06-28 4:02 ` Patchwork
2 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-06-28 4:02 UTC (permalink / raw)
To: Chenxi Mao; +Cc: openembedded-core
== Series Details ==
Series: [1/1,dunfell,master] : don't select vulkan if directfb enabled. (rev2)
Revision: 2
URL : https://patchwork.openembedded.org/series/24873/
State : failure
== Summary ==
Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:
* Patch [dunfell,master] : don't select vulkan if directfb enabled.
Issue Shortlog does not follow expected format [test_shortlog_format]
Suggested fix Commit shortlog (first line of commit message) should follow the format "<target>: <summary>"
If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).
---
Guidelines: https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-06-30 1:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-28 3:33 [PATCH 1/1] [dunfell][master]: don't select vulkan if directfb enabled maochenxi
2020-06-28 3:33 ` [PATCH] " Chenxi Mao
2020-06-29 16:47 ` [OE-core] " Andre McCurdy
2020-06-30 1:34 ` Chenxi Mao
2020-06-28 4:02 ` ✗ patchtest: failure for [1/1,dunfell,master] : " Patchwork
2020-06-28 4:02 ` ✗ patchtest: failure for [1/1,dunfell,master] : don't select vulkan if directfb enabled. (rev2) Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.