From: Steven Rostedt <rostedt@goodmis.org>
To: kbuild-all@lists.01.org
Subject: Re: [trace:ftrace/ring-buffer-irq-timestamp 1/7] kernel/trace/trace.c:3356 trace_array_printk() warn: variable dereferenced before check 'tr' (see line 3353)
Date: Mon, 29 Jun 2020 09:05:12 -0400 [thread overview]
Message-ID: <20200629090512.53d19ec2@oasis.local.home> (raw)
In-Reply-To: <20200629105710.GN2549@kadam>
[-- Attachment #1: Type: text/plain, Size: 1653 bytes --]
On Mon, 29 Jun 2020 13:57:10 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git ftrace/ring-buffer-irq-timestamp
> head: 63afaf390ebc12f578d6bb4ced9ed4a35eab1c92
> commit: 0b10b8f570623d0a82ce29089b9be3b3f53e5bf2 [1/7] tracing: Only allow trace_array_printk() to be used by instances
> config: x86_64-randconfig-m001-20200629 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> smatch warnings:
> kernel/trace/trace.c:3356 trace_array_printk() warn: variable dereferenced before check 'tr' (see line 3353)
Thanks for the report.
As this is not in a upstream tree yet (it's only in my development
branch) and I'm going to fold the fix into the original commit. It
doesn't make sense to add a "Reported-by" because the issue that was
reported got fixed and folded, Reported-by is for issues that the patch
fixes not issues for the patch itself.
Should I just put in a "Reviewed-by: kernel test robot <lkp@intel.com>" and
"Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>" ?
-- Steve
>
> # https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git/commit/?id=0b10b8f570623d0a82ce29089b9be3b3f53e5bf2
> git remote add trace https://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git
> git remote update trace
> git checkout 0b10b8f570623d0a82ce29089b9be3b3f53e5bf2
> vim +/tr +3356 kernel/trace/trace.c
>
next prev parent reply other threads:[~2020-06-29 13:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 10:57 [trace:ftrace/ring-buffer-irq-timestamp 1/7] kernel/trace/trace.c:3356 trace_array_printk() warn: variable dereferenced before check 'tr' (see line 3353) Dan Carpenter
2020-06-29 10:57 ` Dan Carpenter
2020-06-29 13:05 ` Steven Rostedt [this message]
2020-06-29 13:50 ` Dan Carpenter
2020-06-29 13:50 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-06-29 7:50 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629090512.53d19ec2@oasis.local.home \
--to=rostedt@goodmis.org \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.