From: "Michael S. Tsirkin" <mst@redhat.com>
To: Andrew Jones <drjones@redhat.com>
Cc: peter.maydell@linaro.org, eric.auger@redhat.com,
philmd@redhat.com, qemu-devel@nongnu.org,
shannon.zhaosl@gmail.com, qemu-arm@nongnu.org,
ard.biesheuvel@arm.com, imammedo@redhat.com, lersek@redhat.com
Subject: Re: [PATCH 0/4] hw/arm/virt-acpi-build: Only expose flash on older machine types
Date: Mon, 29 Jun 2020 11:21:25 -0400 [thread overview]
Message-ID: <20200629112056-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20200629140938.17566-1-drjones@redhat.com>
On Mon, Jun 29, 2020 at 04:09:34PM +0200, Andrew Jones wrote:
> The flash device is exclusively for the host-controlled firmware, so
> we should not expose it to the OS. Exposing it risks the OS messing
> with it, which could break firmware runtime services and surprise the
> OS when all its changes disappear after reboot.
>
> This change was suggested by Ard and Laszlo.
>
> Patch 3/4 is the meat. The other patches deal with updating qtest.
acpi things:
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
> Thanks,
> drew
>
> Andrew Jones (4):
> tests/acpi: remove stale allowed tables
> tests/acpi: virt: allow DSDT acpi table changes
> hw/arm/virt-acpi-build: Only expose flash on older machine types
> tests/acpi: virt: update golden masters for DSDT
>
> hw/arm/virt-acpi-build.c | 5 ++++-
> hw/arm/virt.c | 3 +++
> include/hw/arm/virt.h | 1 +
> tests/data/acpi/virt/DSDT | Bin 5307 -> 5205 bytes
> tests/data/acpi/virt/DSDT.memhp | Bin 6668 -> 6566 bytes
> tests/data/acpi/virt/DSDT.numamem | Bin 5307 -> 5205 bytes
> tests/qtest/bios-tables-test-allowed-diff.h | 18 ------------------
> 7 files changed, 8 insertions(+), 19 deletions(-)
>
> --
> 2.25.4
next prev parent reply other threads:[~2020-06-29 15:21 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-29 14:09 [PATCH 0/4] hw/arm/virt-acpi-build: Only expose flash on older machine types Andrew Jones
2020-06-29 14:09 ` [PATCH 1/4] tests/acpi: remove stale allowed tables Andrew Jones
2020-06-29 15:06 ` Michael S. Tsirkin
2020-06-29 14:09 ` [PATCH 2/4] tests/acpi: virt: allow DSDT acpi table changes Andrew Jones
2020-06-29 14:09 ` [PATCH 3/4] hw/arm/virt-acpi-build: Only expose flash on older machine types Andrew Jones
2020-06-29 14:18 ` Philippe Mathieu-Daudé
2020-07-02 9:48 ` Laszlo Ersek
2020-07-02 9:53 ` Michael S. Tsirkin
2020-07-02 10:16 ` Peter Maydell
2020-07-02 11:13 ` Michael S. Tsirkin
2020-07-13 8:49 ` Igor Mammedov
2020-07-14 5:51 ` Andrew Jones
2020-07-14 8:57 ` Michael S. Tsirkin
2020-07-14 9:23 ` Andrew Jones
2020-07-14 9:31 ` Michael S. Tsirkin
2020-07-14 14:41 ` Igor Mammedov
2020-07-15 6:36 ` Andrew Jones
2020-07-15 9:37 ` Andrew Jones
2020-07-15 12:26 ` Laszlo Ersek
2020-07-15 13:05 ` Andrew Jones
2020-06-29 14:09 ` [PATCH 4/4] tests/acpi: virt: update golden masters for DSDT Andrew Jones
2020-07-02 9:49 ` Laszlo Ersek
2020-06-29 15:21 ` Michael S. Tsirkin [this message]
2020-07-02 19:26 ` [PATCH 0/4] hw/arm/virt-acpi-build: Only expose flash on older machine types Auger Eric
2020-07-03 13:02 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200629112056-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=ard.biesheuvel@arm.com \
--cc=drjones@redhat.com \
--cc=eric.auger@redhat.com \
--cc=imammedo@redhat.com \
--cc=lersek@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=shannon.zhaosl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.