From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [Intel-wired-lan] [next-queue] ixgbe: Add ethtool support to enable 2.5 and 5.0 Gbps support
Date: Tue, 30 Jun 2020 13:54:23 +0300 [thread overview]
Message-ID: <20200630105423.GO2549@kadam> (raw)
In-Reply-To: <20200626050228.1287009-1-jeffrey.t.kirsher@intel.com>
[-- Attachment #1: Type: text/plain, Size: 12205 bytes --]
Hi Jeff,
url: https://github.com/0day-ci/linux/commits/Jeff-Kirsher/ixgbe-Add-ethtool-support-to-enable-2-5-and-5-0-Gbps-support/20200626-130545
base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
config: x86_64-randconfig-m001-20200624 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c:475 ixgbe_set_link_ksettings() warn: if statement not indented
# https://github.com/0day-ci/linux/commit/6607c3800b28dc6f72dc1018bf23cfeabe5aefde
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 6607c3800b28dc6f72dc1018bf23cfeabe5aefde
vim +475 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 431 static int ixgbe_set_link_ksettings(struct net_device *netdev,
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 432 const struct ethtool_link_ksettings *cmd)
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 433 {
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 434 struct ixgbe_adapter *adapter = netdev_priv(netdev);
735441fb1a3b21 drivers/net/ixgbe/ixgbe_ethtool.c Ayyappan Veeraiyan 2008-02-01 435 struct ixgbe_hw *hw = &adapter->hw;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 436 u32 advertised, old;
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 437 s32 err = 0;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 438 u32 supported, advertising;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 439
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 440 ethtool_convert_link_mode_to_legacy_u32(&supported,
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 441 cmd->link_modes.supported);
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 442 ethtool_convert_link_mode_to_legacy_u32(&advertising,
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 443 cmd->link_modes.advertising);
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 444
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 445 if ((hw->phy.media_type == ixgbe_media_type_copper) ||
a380137900fca5 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-30 446 (hw->phy.multispeed_fiber)) {
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 447 /*
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 448 * this function does not support duplex forcing, but can
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 449 * limit the advertising of the adapter to the specified speed
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 450 */
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 451 if (advertising & ~supported)
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 452 return -EINVAL;
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 453
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 454 /* only allow one speed at a time if no autoneg */
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 455 if (!cmd->base.autoneg && hw->phy.multispeed_fiber) {
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 456 if (advertising ==
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 457 (ADVERTISED_10000baseT_Full |
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 458 ADVERTISED_1000baseT_Full))
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 459 return -EINVAL;
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 460 }
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 461
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 462 old = hw->phy.autoneg_advertised;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 463 advertised = 0;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 464 if (advertising & ADVERTISED_10000baseT_Full)
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 465 advertised |= IXGBE_LINK_SPEED_10GB_FULL;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 466
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 467 if (ethtool_link_ksettings_test_link_mode(cmd, advertising,
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 468 5000baseT_Full))
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 469 advertised |= IXGBE_LINK_SPEED_5GB_FULL;
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 470
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 471 if (ethtool_link_ksettings_test_link_mode(cmd, advertising,
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 472 2500baseT_Full))
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 473 advertised |= IXGBE_LINK_SPEED_2_5GB_FULL;
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 474
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 @475 if (ethtool_link_ksettings_test_link_mode(cmd, advertising,
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 476 1000baseT_Full))
There is no if statement here.
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 477 if (advertising & ADVERTISED_1000baseT_Full)
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 478 advertised |= IXGBE_LINK_SPEED_1GB_FULL;
Which probably means that it can never be 1GB link speed.
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 479
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 480 if (advertising & ADVERTISED_100baseT_Full)
2b642ca5e93fa1 drivers/net/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-03-04 481 advertised |= IXGBE_LINK_SPEED_100_FULL;
2b642ca5e93fa1 drivers/net/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-03-04 482
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 483 if (advertising & ADVERTISED_10baseT_Full)
b3eb4e1860f359 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Mark Rustad 2016-12-14 484 advertised |= IXGBE_LINK_SPEED_10_FULL;
b3eb4e1860f359 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Mark Rustad 2016-12-14 485
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 486 if (old == advertised)
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 487 return err;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 488 /* this sets the link speed and restarts auto-neg */
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 489 while (test_and_set_bit(__IXGBE_IN_SFP_INIT, &adapter->state))
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 490 usleep_range(1000, 2000);
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 491
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 492 hw->mac.autotry_restart = true;
fd0326f2cf9e5d drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Josh Hay 2012-12-15 493 err = hw->mac.ops.setup_link(hw, advertised, true);
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 494 if (err) {
396e799c3ac29f drivers/net/ixgbe/ixgbe_ethtool.c Emil Tantilov 2010-07-01 495 e_info(probe, "setup link failed with code %d\n", err);
fd0326f2cf9e5d drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Josh Hay 2012-12-15 496 hw->mac.ops.setup_link(hw, old, true);
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 497 }
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 498 clear_bit(__IXGBE_IN_SFP_INIT, &adapter->state);
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 499 } else {
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 500 /* in this case we currently only support 10Gb/FULL */
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 501 u32 speed = cmd->base.speed;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 502
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 503 if ((cmd->base.autoneg == AUTONEG_ENABLE) ||
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 504 (advertising != ADVERTISED_10000baseT_Full) ||
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 505 (speed + cmd->base.duplex != SPEED_10000 + DUPLEX_FULL))
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 506 return -EINVAL;
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 507 }
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 508
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 509 return err;
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 510 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33440 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-wired-lan] [next-queue] ixgbe: Add ethtool support to enable 2.5 and 5.0 Gbps support
Date: Tue, 30 Jun 2020 13:54:23 +0300 [thread overview]
Message-ID: <20200630105423.GO2549@kadam> (raw)
In-Reply-To: <20200626050228.1287009-1-jeffrey.t.kirsher@intel.com>
[-- Attachment #1: Type: text/plain, Size: 12205 bytes --]
Hi Jeff,
url: https://github.com/0day-ci/linux/commits/Jeff-Kirsher/ixgbe-Add-ethtool-support-to-enable-2-5-and-5-0-Gbps-support/20200626-130545
base: https://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue.git dev-queue
config: x86_64-randconfig-m001-20200624 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-13) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c:475 ixgbe_set_link_ksettings() warn: if statement not indented
# https://github.com/0day-ci/linux/commit/6607c3800b28dc6f72dc1018bf23cfeabe5aefde
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout 6607c3800b28dc6f72dc1018bf23cfeabe5aefde
vim +475 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 431 static int ixgbe_set_link_ksettings(struct net_device *netdev,
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 432 const struct ethtool_link_ksettings *cmd)
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 433 {
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 434 struct ixgbe_adapter *adapter = netdev_priv(netdev);
735441fb1a3b21 drivers/net/ixgbe/ixgbe_ethtool.c Ayyappan Veeraiyan 2008-02-01 435 struct ixgbe_hw *hw = &adapter->hw;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 436 u32 advertised, old;
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 437 s32 err = 0;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 438 u32 supported, advertising;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 439
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 440 ethtool_convert_link_mode_to_legacy_u32(&supported,
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 441 cmd->link_modes.supported);
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 442 ethtool_convert_link_mode_to_legacy_u32(&advertising,
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 443 cmd->link_modes.advertising);
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 444
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 445 if ((hw->phy.media_type == ixgbe_media_type_copper) ||
a380137900fca5 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-30 446 (hw->phy.multispeed_fiber)) {
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 447 /*
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 448 * this function does not support duplex forcing, but can
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 449 * limit the advertising of the adapter to the specified speed
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 450 */
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 451 if (advertising & ~supported)
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 452 return -EINVAL;
abcc80d26cc040 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-07-29 453
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 454 /* only allow one speed at a time if no autoneg */
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 455 if (!cmd->base.autoneg && hw->phy.multispeed_fiber) {
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 456 if (advertising ==
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 457 (ADVERTISED_10000baseT_Full |
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 458 ADVERTISED_1000baseT_Full))
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 459 return -EINVAL;
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 460 }
ed33ff66d8064e drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2013-08-30 461
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 462 old = hw->phy.autoneg_advertised;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 463 advertised = 0;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 464 if (advertising & ADVERTISED_10000baseT_Full)
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 465 advertised |= IXGBE_LINK_SPEED_10GB_FULL;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 466
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 467 if (ethtool_link_ksettings_test_link_mode(cmd, advertising,
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 468 5000baseT_Full))
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 469 advertised |= IXGBE_LINK_SPEED_5GB_FULL;
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 470
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 471 if (ethtool_link_ksettings_test_link_mode(cmd, advertising,
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 472 2500baseT_Full))
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 473 advertised |= IXGBE_LINK_SPEED_2_5GB_FULL;
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 474
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 @475 if (ethtool_link_ksettings_test_link_mode(cmd, advertising,
6607c3800b28dc drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Jeff Kirsher 2020-06-25 476 1000baseT_Full))
There is no if statement here.
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 477 if (advertising & ADVERTISED_1000baseT_Full)
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 478 advertised |= IXGBE_LINK_SPEED_1GB_FULL;
Which probably means that it can never be 1GB link speed.
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 479
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 480 if (advertising & ADVERTISED_100baseT_Full)
2b642ca5e93fa1 drivers/net/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-03-04 481 advertised |= IXGBE_LINK_SPEED_100_FULL;
2b642ca5e93fa1 drivers/net/ixgbe/ixgbe_ethtool.c Emil Tantilov 2011-03-04 482
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 483 if (advertising & ADVERTISED_10baseT_Full)
b3eb4e1860f359 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Mark Rustad 2016-12-14 484 advertised |= IXGBE_LINK_SPEED_10_FULL;
b3eb4e1860f359 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Mark Rustad 2016-12-14 485
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 486 if (old == advertised)
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 487 return err;
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 488 /* this sets the link speed and restarts auto-neg */
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 489 while (test_and_set_bit(__IXGBE_IN_SFP_INIT, &adapter->state))
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 490 usleep_range(1000, 2000);
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 491
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 492 hw->mac.autotry_restart = true;
fd0326f2cf9e5d drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Josh Hay 2012-12-15 493 err = hw->mac.ops.setup_link(hw, advertised, true);
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 494 if (err) {
396e799c3ac29f drivers/net/ixgbe/ixgbe_ethtool.c Emil Tantilov 2010-07-01 495 e_info(probe, "setup link failed with code %d\n", err);
fd0326f2cf9e5d drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Josh Hay 2012-12-15 496 hw->mac.ops.setup_link(hw, old, true);
0befdb3e0a26a8 drivers/net/ixgbe/ixgbe_ethtool.c Jesse Brandeburg 2008-10-31 497 }
e3215f0ac77ec2 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Emil Tantilov 2014-10-28 498 clear_bit(__IXGBE_IN_SFP_INIT, &adapter->state);
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 499 } else {
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 500 /* in this case we currently only support 10Gb/FULL */
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 501 u32 speed = cmd->base.speed;
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 502
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 503 if ((cmd->base.autoneg == AUTONEG_ENABLE) ||
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 504 (advertising != ADVERTISED_10000baseT_Full) ||
8704f21c8449d4 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c Philippe Reynes 2017-03-07 505 (speed + cmd->base.duplex != SPEED_10000 + DUPLEX_FULL))
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 506 return -EINVAL;
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 507 }
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 508
74766013a131f1 drivers/net/ixgbe/ixgbe_ethtool.c Mallikarjuna R Chilakala 2009-06-04 509 return err;
9a799d71034c4e drivers/net/ixgbe/ixgbe_ethtool.c Auke Kok 2007-09-15 510 }
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 33440 bytes --]
next prev parent reply other threads:[~2020-06-30 10:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-26 5:02 [Intel-wired-lan] [next-queue] ixgbe: Add ethtool support to enable 2.5 and 5.0 Gbps support Jeff Kirsher
2020-06-26 12:22 ` Piotr Skajewski
2020-06-30 10:54 ` Dan Carpenter [this message]
2020-06-30 10:54 ` Dan Carpenter
-- strict thread matches above, loose matches on Subject: below --
2020-06-26 17:37 kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630105423.GO2549@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.