* [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164
@ 2020-06-29 21:20 José Roberto de Souza
2020-06-29 21:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: José Roberto de Souza @ 2020-06-29 21:20 UTC (permalink / raw)
To: intel-gfx
This fix some possible corruptions.
BSpec: 52755
BSpec: 52890
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_pm.c | 8 +++++++-
2 files changed, 10 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 284af0c6439c..797e036fa695 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4170,6 +4170,9 @@ enum {
#define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560)
#define CGPSF_CLKGATE_DIS (1 << 3)
+#define SLICE_UNIT_LEVEL_CLOCK_GATING_CTL _MMIO(0x94D8)
+#define GS_UNIT_CLOCK_GATING_DIS REG_BIT(24)
+
/*
* Display engine regs
*/
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 2a32d6230795..86408173c435 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm/i915/intel_pm.c
@@ -7113,7 +7113,7 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
I915_WRITE(POWERGATE_ENABLE,
I915_READ(POWERGATE_ENABLE) | vd_pg_enable);
- /* Wa_1409825376:tgl (pre-prod)*/
+ /* Wa_1409825376:tgl (pre-prod) */
if (IS_TGL_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0))
I915_WRITE(GEN9_CLKGATE_DIS_3, I915_READ(GEN9_CLKGATE_DIS_3) |
TGL_VRH_GATING_DIS);
@@ -7121,6 +7121,12 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
/* Wa_14011059788:tgl */
intel_uncore_rmw(&dev_priv->uncore, GEN10_DFR_RATIO_EN_AND_CHICKEN,
0, DFR_DISABLE);
+
+ /* Wa_18011464164:tgl */
+ if (IS_TGL_REVID(dev_priv, TGL_REVID_B0, TGL_REVID_B0))
+ intel_uncore_rmw(&dev_priv->uncore,
+ SLICE_UNIT_LEVEL_CLOCK_GATING_CTL, 0,
+ GS_UNIT_CLOCK_GATING_DIS);
}
static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Implement WA 22010931296
2020-06-29 21:20 [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza
@ 2020-06-29 21:20 ` José Roberto de Souza
2020-06-30 14:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/tgl: Implement WA 18011464164 Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: José Roberto de Souza @ 2020-06-29 21:20 UTC (permalink / raw)
To: intel-gfx
Fix another set of corruption issues.
BSpec: 52758
BSpec: 52890
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/gt/intel_workarounds.c | 4 ++++
drivers/gpu/drm/i915/i915_reg.h | 1 +
2 files changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index 2da366821dda..c8bf09efd0dc 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -1677,6 +1677,10 @@ rcs_engine_wa_init(struct intel_engine_cs *engine, struct i915_wa_list *wal)
* Wa_14010229206:tgl
*/
wa_masked_en(wal, GEN9_ROW_CHICKEN4, GEN12_DISABLE_TDL_PUSH);
+
+ /* Wa_22010931296:tgl */
+ wa_write_or(wal, UNSLICE_UNIT_LEVEL_CLKGATE2,
+ TDSUNIT_CLKGATE_DIS);
}
if (IS_GEN(i915, 11)) {
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 797e036fa695..9b365fc7a644 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915/i915_reg.h
@@ -4165,6 +4165,7 @@ enum {
#define UNSLICE_UNIT_LEVEL_CLKGATE2 _MMIO(0x94e4)
#define VSUNIT_CLKGATE_DIS_TGL REG_BIT(19)
+#define TDSUNIT_CLKGATE_DIS REG_BIT(11)
#define PSDUNIT_CLKGATE_DIS REG_BIT(5)
#define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560)
--
2.27.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/tgl: Implement WA 18011464164
2020-06-29 21:20 [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza
2020-06-29 21:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza
@ 2020-06-30 14:12 ` Patchwork
2020-06-30 14:28 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
2020-06-30 17:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-06-30 14:12 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/tgl: Implement WA 18011464164
URL : https://patchwork.freedesktop.org/series/78912/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8677 -> Patchwork_18040
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/index.html
Known issues
------------
Here are the changes found in Patchwork_18040 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_cursor_legacy@basic-flip-after-cursor-atomic:
- fi-icl-u2: [PASS][1] -> [DMESG-WARN][2] ([i915#1982]) +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-after-cursor-atomic.html
#### Possible fixes ####
* igt@i915_module_load@reload:
- fi-byt-j1900: [DMESG-WARN][3] ([i915#1982]) -> [PASS][4]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/fi-byt-j1900/igt@i915_module_load@reload.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/fi-byt-j1900/igt@i915_module_load@reload.html
* igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
- fi-icl-u2: [DMESG-WARN][5] ([i915#1982]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/fi-icl-u2/igt@kms_cursor_legacy@basic-flip-before-cursor-legacy.html
#### Warnings ####
* igt@kms_flip@basic-flip-vs-modeset@a-dp1:
- fi-kbl-x1275: [DMESG-WARN][7] ([i915#62] / [i915#92]) -> [DMESG-WARN][8] ([i915#62] / [i915#92] / [i915#95]) +2 similar issues
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset@a-dp1.html
* igt@prime_vgem@basic-fence-flip:
- fi-kbl-x1275: [DMESG-WARN][9] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][10] ([i915#62] / [i915#92]) +3 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62
[i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (43 -> 37)
------------------------------
Additional (1): fi-tgl-u2
Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_8677 -> Patchwork_18040
CI-20190529: 20190529
CI_DRM_8677: 47bc281ce35e7872ee04238b2f5e81aeeeb2337b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18040: 2eb704061edc4ae027f42cdc7a36f73cfec9d7ce @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
2eb704061edc drm/i915/tgl: Implement WA 22010931296
98575b5b1bb3 drm/i915/tgl: Implement WA 18011464164
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164
2020-06-29 21:20 [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza
2020-06-29 21:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza
2020-06-30 14:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/tgl: Implement WA 18011464164 Patchwork
@ 2020-06-30 14:28 ` Ville Syrjälä
2020-07-01 1:01 ` Souza, Jose
2020-06-30 17:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
3 siblings, 1 reply; 6+ messages in thread
From: Ville Syrjälä @ 2020-06-30 14:28 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Mon, Jun 29, 2020 at 02:20:58PM -0700, José Roberto de Souza wrote:
> This fix some possible corruptions.
>
> BSpec: 52755
> BSpec: 52890
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 3 +++
> drivers/gpu/drm/i915/intel_pm.c | 8 +++++++-
> 2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 284af0c6439c..797e036fa695 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -4170,6 +4170,9 @@ enum {
> #define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560)
> #define CGPSF_CLKGATE_DIS (1 << 3)
>
> +#define SLICE_UNIT_LEVEL_CLOCK_GATING_CTL _MMIO(0x94D8)
> +#define GS_UNIT_CLOCK_GATING_DIS REG_BIT(24)
> +
> /*
> * Display engine regs
> */
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 2a32d6230795..86408173c435 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -7113,7 +7113,7 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
> I915_WRITE(POWERGATE_ENABLE,
> I915_READ(POWERGATE_ENABLE) | vd_pg_enable);
>
> - /* Wa_1409825376:tgl (pre-prod)*/
> + /* Wa_1409825376:tgl (pre-prod) */
> if (IS_TGL_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0))
> I915_WRITE(GEN9_CLKGATE_DIS_3, I915_READ(GEN9_CLKGATE_DIS_3) |
> TGL_VRH_GATING_DIS);
> @@ -7121,6 +7121,12 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
> /* Wa_14011059788:tgl */
> intel_uncore_rmw(&dev_priv->uncore, GEN10_DFR_RATIO_EN_AND_CHICKEN,
> 0, DFR_DISABLE);
> +
> + /* Wa_18011464164:tgl */
> + if (IS_TGL_REVID(dev_priv, TGL_REVID_B0, TGL_REVID_B0))
> + intel_uncore_rmw(&dev_priv->uncore,
> + SLICE_UNIT_LEVEL_CLOCK_GATING_CTL, 0,
> + GS_UNIT_CLOCK_GATING_DIS);
This looks like a gt w/a, so shouldn't be here preobably. We also have
a very similarly named register already at 0x94d4, so the register
name probably needs some work too.
> }
>
> static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)
> --
> 2.27.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/tgl: Implement WA 18011464164
2020-06-29 21:20 [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza
` (2 preceding siblings ...)
2020-06-30 14:28 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
@ 2020-06-30 17:26 ` Patchwork
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2020-06-30 17:26 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: series starting with [1/2] drm/i915/tgl: Implement WA 18011464164
URL : https://patchwork.freedesktop.org/series/78912/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8677_full -> Patchwork_18040_full
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_18040_full absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_18040_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_18040_full:
### IGT changes ###
#### Possible regressions ####
* igt@i915_selftest@live@execlists:
- shard-iclb: [PASS][1] -> [INCOMPLETE][2]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-iclb2/igt@i915_selftest@live@execlists.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-iclb1/igt@i915_selftest@live@execlists.html
Known issues
------------
Here are the changes found in Patchwork_18040_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd:
- shard-skl: [PASS][3] -> [FAIL][4] ([i915#1528])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl8/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl6/igt@gem_ctx_persistence@legacy-engines-mixed-process@bsd.html
* igt@i915_module_load@reload-with-fault-injection:
- shard-tglb: [PASS][5] -> [DMESG-WARN][6] ([i915#402])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-tglb5/igt@i915_module_load@reload-with-fault-injection.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-tglb8/igt@i915_module_load@reload-with-fault-injection.html
* igt@kms_big_fb@x-tiled-64bpp-rotate-0:
- shard-glk: [PASS][7] -> [DMESG-FAIL][8] ([i915#118] / [i915#95])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-glk1/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-glk8/igt@kms_big_fb@x-tiled-64bpp-rotate-0.html
* igt@kms_cursor_crc@pipe-b-cursor-64x64-random:
- shard-apl: [PASS][9] -> [DMESG-WARN][10] ([i915#1635] / [i915#95]) +15 similar issues
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl1/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl4/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
- shard-kbl: [PASS][11] -> [DMESG-WARN][12] ([i915#93] / [i915#95]) +3 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl7/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl4/igt@kms_cursor_crc@pipe-b-cursor-64x64-random.html
* igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge:
- shard-skl: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) +15 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl2/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl7/igt@kms_cursor_edge_walk@pipe-a-256x256-right-edge.html
* igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled:
- shard-glk: [PASS][15] -> [DMESG-WARN][16] ([i915#1982])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-glk8/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-glk5/igt@kms_draw_crc@draw-method-xrgb2101010-blt-untiled.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1:
- shard-skl: [PASS][17] -> [FAIL][18] ([i915#79])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl10/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl5/igt@kms_flip@flip-vs-expired-vblank-interruptible@a-edp1.html
* igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2:
- shard-glk: [PASS][19] -> [FAIL][20] ([i915#79])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-glk9/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-glk4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-hdmi-a2.html
* igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
- shard-kbl: [PASS][21] -> [DMESG-WARN][22] ([i915#180]) +7 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl6/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html
* igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary:
- shard-iclb: [PASS][23] -> [DMESG-WARN][24] ([i915#1982]) +2 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-iclb4/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-iclb3/igt@kms_frontbuffer_tracking@psr-shrfb-scaledprimary.html
* igt@kms_hdr@bpc-switch-suspend:
- shard-skl: [PASS][25] -> [FAIL][26] ([i915#1188])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl5/igt@kms_hdr@bpc-switch-suspend.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl7/igt@kms_hdr@bpc-switch-suspend.html
* igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [i915#265])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-constant-alpha-min.html
* igt@kms_prime@basic-crc@second-to-first:
- shard-kbl: [PASS][29] -> [DMESG-FAIL][30] ([i915#95])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl3/igt@kms_prime@basic-crc@second-to-first.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl1/igt@kms_prime@basic-crc@second-to-first.html
* igt@kms_psr@psr2_sprite_plane_move:
- shard-iclb: [PASS][31] -> [SKIP][32] ([fdo#109441])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-iclb5/igt@kms_psr@psr2_sprite_plane_move.html
* igt@kms_vblank@pipe-c-wait-idle:
- shard-kbl: [PASS][33] -> [DMESG-WARN][34] ([i915#1982])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl7/igt@kms_vblank@pipe-c-wait-idle.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl4/igt@kms_vblank@pipe-c-wait-idle.html
- shard-tglb: [PASS][35] -> [DMESG-WARN][36] ([i915#1982]) +1 similar issue
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-tglb6/igt@kms_vblank@pipe-c-wait-idle.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-tglb1/igt@kms_vblank@pipe-c-wait-idle.html
- shard-apl: [PASS][37] -> [DMESG-WARN][38] ([i915#1982])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl2/igt@kms_vblank@pipe-c-wait-idle.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl1/igt@kms_vblank@pipe-c-wait-idle.html
#### Possible fixes ####
* igt@gem_exec_nop@basic-parallel:
- shard-apl: [DMESG-WARN][39] ([i915#1635] / [i915#95]) -> [PASS][40] +19 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl2/igt@gem_exec_nop@basic-parallel.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl1/igt@gem_exec_nop@basic-parallel.html
* igt@i915_pm_dc@dc5-psr:
- shard-skl: [INCOMPLETE][41] ([i915#198]) -> [PASS][42]
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl4/igt@i915_pm_dc@dc5-psr.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl2/igt@i915_pm_dc@dc5-psr.html
* igt@i915_selftest@mock@requests:
- shard-apl: [INCOMPLETE][43] ([i915#1635] / [i915#2110]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl8/igt@i915_selftest@mock@requests.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl6/igt@i915_selftest@mock@requests.html
* igt@kms_big_fb@linear-64bpp-rotate-180:
- shard-glk: [DMESG-FAIL][45] ([i915#118] / [i915#95]) -> [PASS][46]
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-glk3/igt@kms_big_fb@linear-64bpp-rotate-180.html
* igt@kms_color@pipe-c-ctm-0-25:
- shard-skl: [DMESG-WARN][47] ([i915#1982]) -> [PASS][48] +6 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl5/igt@kms_color@pipe-c-ctm-0-25.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl7/igt@kms_color@pipe-c-ctm-0-25.html
* igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen:
- shard-skl: [FAIL][49] ([i915#54]) -> [PASS][50]
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl8/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl1/igt@kms_cursor_crc@pipe-c-cursor-256x85-onscreen.html
* igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled:
- shard-snb: [SKIP][51] ([fdo#109271]) -> [PASS][52] +3 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-snb1/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-snb4/igt@kms_draw_crc@draw-method-xrgb8888-mmap-gtt-xtiled.html
* igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2:
- shard-glk: [FAIL][53] ([i915#1928]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-glk6/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-glk2/igt@kms_flip@2x-plain-flip-fb-recreate@ab-hdmi-a1-hdmi-a2.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1:
- shard-kbl: [DMESG-WARN][55] ([i915#1982]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl6/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl6/igt@kms_flip@modeset-vs-vblank-race-interruptible@a-dp1.html
* igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1:
- shard-skl: [FAIL][57] ([i915#1928]) -> [PASS][58] +1 similar issue
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl9/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl6/igt@kms_flip@plain-flip-ts-check-interruptible@c-edp1.html
* igt@kms_frontbuffer_tracking@fbc-stridechange:
- shard-kbl: [DMESG-WARN][59] ([i915#93] / [i915#95]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-stridechange.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl1/igt@kms_frontbuffer_tracking@fbc-stridechange.html
* igt@kms_frontbuffer_tracking@psr-suspend:
- shard-tglb: [DMESG-WARN][61] ([i915#1982]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-tglb3/igt@kms_frontbuffer_tracking@psr-suspend.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-tglb2/igt@kms_frontbuffer_tracking@psr-suspend.html
* igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes:
- shard-kbl: [DMESG-WARN][63] ([i915#180]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl1/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl2/igt@kms_plane@plane-panning-bottom-right-suspend-pipe-a-planes.html
* igt@kms_plane_alpha_blend@pipe-c-coverage-7efc:
- shard-skl: [FAIL][65] ([fdo#108145] / [i915#265]) -> [PASS][66]
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl6/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl4/igt@kms_plane_alpha_blend@pipe-c-coverage-7efc.html
* igt@kms_psr@psr2_suspend:
- shard-iclb: [SKIP][67] ([fdo#109441]) -> [PASS][68] +3 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-iclb5/igt@kms_psr@psr2_suspend.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-iclb2/igt@kms_psr@psr2_suspend.html
* igt@kms_setmode@basic:
- shard-kbl: [FAIL][69] ([i915#31]) -> [PASS][70]
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl2/igt@kms_setmode@basic.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl2/igt@kms_setmode@basic.html
* igt@kms_universal_plane@universal-plane-gen9-features-pipe-a:
- shard-tglb: [DMESG-WARN][71] ([i915#402]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-tglb8/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-tglb1/igt@kms_universal_plane@universal-plane-gen9-features-pipe-a.html
* igt@perf_pmu@semaphore-busy@rcs0:
- shard-kbl: [FAIL][73] ([i915#1820]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl2/igt@perf_pmu@semaphore-busy@rcs0.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl2/igt@perf_pmu@semaphore-busy@rcs0.html
#### Warnings ####
* igt@gem_exec_reloc@basic-spin-others@vcs0:
- shard-snb: [WARN][75] ([i915#2036]) -> [WARN][76] ([i915#2021])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-snb2/igt@gem_exec_reloc@basic-spin-others@vcs0.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-snb4/igt@gem_exec_reloc@basic-spin-others@vcs0.html
* igt@kms_color_chamelium@pipe-a-ctm-max:
- shard-apl: [SKIP][77] ([fdo#109271] / [fdo#111827] / [i915#1635]) -> [SKIP][78] ([fdo#109271] / [fdo#111827])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl6/igt@kms_color_chamelium@pipe-a-ctm-max.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl8/igt@kms_color_chamelium@pipe-a-ctm-max.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][79] ([i915#180] / [i915#93] / [i915#95]) -> [DMESG-WARN][80] ([i915#93] / [i915#95])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl7/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_cursor_crc@pipe-d-cursor-512x512-random:
- shard-apl: [SKIP][81] ([fdo#109271]) -> [SKIP][82] ([fdo#109271] / [i915#1635]) +4 similar issues
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl8/igt@kms_cursor_crc@pipe-d-cursor-512x512-random.html
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl6/igt@kms_cursor_crc@pipe-d-cursor-512x512-random.html
* igt@kms_dp_dsc@basic-dsc-enable-edp:
- shard-iclb: [SKIP][83] ([fdo#109349]) -> [DMESG-WARN][84] ([i915#1226])
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-iclb5/igt@kms_dp_dsc@basic-dsc-enable-edp.html
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-iclb2/igt@kms_dp_dsc@basic-dsc-enable-edp.html
* igt@kms_frontbuffer_tracking@fbc-suspend:
- shard-kbl: [DMESG-WARN][85] ([i915#93] / [i915#95]) -> [DMESG-WARN][86] ([i915#180] / [i915#93] / [i915#95])
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-kbl2/igt@kms_frontbuffer_tracking@fbc-suspend.html
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-kbl3/igt@kms_frontbuffer_tracking@fbc-suspend.html
* igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu:
- shard-apl: [SKIP][87] ([fdo#109271] / [i915#1635]) -> [SKIP][88] ([fdo#109271]) +6 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl4/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl2/igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-cpu.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-skl: [DMESG-FAIL][89] ([fdo#108145] / [i915#1982]) -> [FAIL][90] ([fdo#108145] / [i915#265])
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-skl8/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-skl6/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant:
- shard-apl: [DMESG-FAIL][91] ([fdo#108145] / [i915#1635] / [i915#95]) -> [DMESG-FAIL][92] ([fdo#108145] / [i915#1635] / [i915#1982] / [i915#95])
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl7/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl1/igt@kms_plane_alpha_blend@pipe-a-coverage-vs-premult-vs-constant.html
* igt@runner@aborted:
- shard-iclb: ([FAIL][93], [FAIL][94]) ([i915#2110]) -> ([FAIL][95], [FAIL][96]) ([i915#1580] / [i915#2110])
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-iclb6/igt@runner@aborted.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-iclb6/igt@runner@aborted.html
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-iclb4/igt@runner@aborted.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-iclb1/igt@runner@aborted.html
- shard-apl: ([FAIL][97], [FAIL][98], [FAIL][99]) ([fdo#109271] / [i915#1610] / [i915#1635] / [i915#716]) -> [FAIL][100] ([fdo#109271] / [i915#1635] / [i915#716])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl4/igt@runner@aborted.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl7/igt@runner@aborted.html
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8677/shard-apl8/igt@runner@aborted.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/shard-apl7/igt@runner@aborted.html
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109349]: https://bugs.freedesktop.org/show_bug.cgi?id=109349
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118
[i915#1188]: https://gitlab.freedesktop.org/drm/intel/issues/1188
[i915#1226]: https://gitlab.freedesktop.org/drm/intel/issues/1226
[i915#1528]: https://gitlab.freedesktop.org/drm/intel/issues/1528
[i915#1580]: https://gitlab.freedesktop.org/drm/intel/issues/1580
[i915#1610]: https://gitlab.freedesktop.org/drm/intel/issues/1610
[i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635
[i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180
[i915#1820]: https://gitlab.freedesktop.org/drm/intel/issues/1820
[i915#1928]: https://gitlab.freedesktop.org/drm/intel/issues/1928
[i915#198]: https://gitlab.freedesktop.org/drm/intel/issues/198
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2021]: https://gitlab.freedesktop.org/drm/intel/issues/2021
[i915#2036]: https://gitlab.freedesktop.org/drm/intel/issues/2036
[i915#2110]: https://gitlab.freedesktop.org/drm/intel/issues/2110
[i915#265]: https://gitlab.freedesktop.org/drm/intel/issues/265
[i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31
[i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402
[i915#54]: https://gitlab.freedesktop.org/drm/intel/issues/54
[i915#716]: https://gitlab.freedesktop.org/drm/intel/issues/716
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#93]: https://gitlab.freedesktop.org/drm/intel/issues/93
[i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95
Participating hosts (11 -> 11)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_8677 -> Patchwork_18040
CI-20190529: 20190529
CI_DRM_8677: 47bc281ce35e7872ee04238b2f5e81aeeeb2337b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5718: af1ef32bfae90bcdbaf1b5d84c61ff4e04368505 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_18040: 2eb704061edc4ae027f42cdc7a36f73cfec9d7ce @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18040/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164
2020-06-30 14:28 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
@ 2020-07-01 1:01 ` Souza, Jose
0 siblings, 0 replies; 6+ messages in thread
From: Souza, Jose @ 2020-07-01 1:01 UTC (permalink / raw)
To: ville.syrjala@linux.intel.com; +Cc: intel-gfx@lists.freedesktop.org
On Tue, 2020-06-30 at 17:28 +0300, Ville Syrjälä wrote:
> On Mon, Jun 29, 2020 at 02:20:58PM -0700, José Roberto de Souza wrote:
> > This fix some possible corruptions.
> >
> > BSpec: 52755
> > BSpec: 52890
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> > ---
> > drivers/gpu/drm/i915/i915_reg.h | 3 +++
> > drivers/gpu/drm/i915/intel_pm.c | 8 +++++++-
> > 2 files changed, 10 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> > index 284af0c6439c..797e036fa695 100644
> > --- a/drivers/gpu/drm/i915/i915_reg.h
> > +++ b/drivers/gpu/drm/i915/i915_reg.h
> > @@ -4170,6 +4170,9 @@ enum {
> > #define INF_UNIT_LEVEL_CLKGATE _MMIO(0x9560)
> > #define CGPSF_CLKGATE_DIS (1 << 3)
> >
> > +#define SLICE_UNIT_LEVEL_CLOCK_GATING_CTL _MMIO(0x94D8)
> > +#define GS_UNIT_CLOCK_GATING_DIS REG_BIT(24)
> > +
> > /*
> > * Display engine regs
> > */
> > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> > index 2a32d6230795..86408173c435 100644
> > --- a/drivers/gpu/drm/i915/intel_pm.c
> > +++ b/drivers/gpu/drm/i915/intel_pm.c
> > @@ -7113,7 +7113,7 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
> > I915_WRITE(POWERGATE_ENABLE,
> > I915_READ(POWERGATE_ENABLE) | vd_pg_enable);
> >
> > - /* Wa_1409825376:tgl (pre-prod)*/
> > + /* Wa_1409825376:tgl (pre-prod) */
> > if (IS_TGL_REVID(dev_priv, TGL_REVID_A0, TGL_REVID_A0))
> > I915_WRITE(GEN9_CLKGATE_DIS_3, I915_READ(GEN9_CLKGATE_DIS_3) |
> > TGL_VRH_GATING_DIS);
> > @@ -7121,6 +7121,12 @@ static void tgl_init_clock_gating(struct drm_i915_private *dev_priv)
> > /* Wa_14011059788:tgl */
> > intel_uncore_rmw(&dev_priv->uncore, GEN10_DFR_RATIO_EN_AND_CHICKEN,
> > 0, DFR_DISABLE);
> > +
> > + /* Wa_18011464164:tgl */
> > + if (IS_TGL_REVID(dev_priv, TGL_REVID_B0, TGL_REVID_B0))
> > + intel_uncore_rmw(&dev_priv->uncore,
> > + SLICE_UNIT_LEVEL_CLOCK_GATING_CTL, 0,
> > + GS_UNIT_CLOCK_GATING_DIS);
>
> This looks like a gt w/a, so shouldn't be here preobably. We also have
> a very similarly named register already at 0x94d4, so the register
> name probably needs some work too.
We register in the same class as this one being set in clock_gating functions and as this one have "CustomGTIIs_ContextSaved: true" we don't need to
worry about reprogram it after a reset.About the name you are right, renaming to SLICE_UNIT_LEVEL_CLKGATE_CTL_94D8 as BSpec adds the offset to the
name as there is a bunch of SLICE_UNIT_LEVEL_CLKGATE_CTL registers.
>
> > }
> >
> > static void cnp_init_clock_gating(struct drm_i915_private *dev_priv)
> > --
> > 2.27.0
> >
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-01 1:07 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-29 21:20 [Intel-gfx] [PATCH 1/2] drm/i915/tgl: Implement WA 18011464164 José Roberto de Souza
2020-06-29 21:20 ` [Intel-gfx] [PATCH 2/2] drm/i915/tgl: Implement WA 22010931296 José Roberto de Souza
2020-06-30 14:12 ` [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/tgl: Implement WA 18011464164 Patchwork
2020-06-30 14:28 ` [Intel-gfx] [PATCH 1/2] " Ville Syrjälä
2020-07-01 1:01 ` Souza, Jose
2020-06-30 17:26 ` [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.