* [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled
@ 2020-06-09 10:28 Paul Barker
2020-06-23 8:12 ` Paul Barker
0 siblings, 1 reply; 10+ messages in thread
From: Paul Barker @ 2020-06-09 10:28 UTC (permalink / raw)
To: meta-arago
This change fixes the following error seen at parse time when the
meta-arago-distro layer is present but sysvinit is not in
DISTRO_FEATURES:
ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES
ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb
Signed-off-by: Paul Barker <pbarker@konsulko.com>
---
.../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb
index 2eb2d777..a6e21745 100644
--- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb
+++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb
@@ -1,3 +1,8 @@
+python __anonymous() {
+ if not "sysvinit" in d.getVar("DISTRO_FEATURES").split():
+ raise bb.parse.SkipRecipe("sysvinit is not enabled")
+}
+
require recipes-core/packagegroups/packagegroup-core-boot.bb
PR = "r0"
--
2.26.2
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-09 10:28 [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled Paul Barker @ 2020-06-23 8:12 ` Paul Barker 2020-06-29 22:43 ` Denys Dmytriyenko 0 siblings, 1 reply; 10+ messages in thread From: Paul Barker @ 2020-06-23 8:12 UTC (permalink / raw) To: meta-arago On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > This change fixes the following error seen at parse time when the > meta-arago-distro layer is present but sysvinit is not in > DISTRO_FEATURES: > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > --- > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > index 2eb2d777..a6e21745 100644 > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > @@ -1,3 +1,8 @@ > +python __anonymous() { > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > +} > + > require recipes-core/packagegroups/packagegroup-core-boot.bb > > PR = "r0" > -- > 2.26.2 > Ping. -- Paul Barker Konsulko Group ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-23 8:12 ` Paul Barker @ 2020-06-29 22:43 ` Denys Dmytriyenko 2020-06-30 2:03 ` Denys Dmytriyenko 0 siblings, 1 reply; 10+ messages in thread From: Denys Dmytriyenko @ 2020-06-29 22:43 UTC (permalink / raw) To: Paul Barker; +Cc: meta-arago On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > This change fixes the following error seen at parse time when the > > meta-arago-distro layer is present but sysvinit is not in > > DISTRO_FEATURES: > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > --- > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > index 2eb2d777..a6e21745 100644 > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > @@ -1,3 +1,8 @@ > > +python __anonymous() { > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > +} > > + > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > PR = "r0" > > -- > > 2.26.2 > > > > Ping. Thanks, I'll merge it shortly. -- Denys ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-29 22:43 ` Denys Dmytriyenko @ 2020-06-30 2:03 ` Denys Dmytriyenko 2020-06-30 13:12 ` Paul Barker 0 siblings, 1 reply; 10+ messages in thread From: Denys Dmytriyenko @ 2020-06-30 2:03 UTC (permalink / raw) To: Paul Barker; +Cc: meta-arago On Mon, Jun 29, 2020 at 06:43:02PM -0400, Denys Dmytriyenko wrote: > On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > > > This change fixes the following error seen at parse time when the > > > meta-arago-distro layer is present but sysvinit is not in > > > DISTRO_FEATURES: > > > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > > --- > > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > > 1 file changed, 5 insertions(+) > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > index 2eb2d777..a6e21745 100644 > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > @@ -1,3 +1,8 @@ > > > +python __anonymous() { > > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > > +} > > > + > > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > > > PR = "r0" > > > -- > > > 2.26.2 > > > > > > > Ping. > > Thanks, I'll merge it shortly. Actually, should this simply use REQUIRED_DISTRO_FEATURES from features_check.bbclass? -- Denys ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-30 2:03 ` Denys Dmytriyenko @ 2020-06-30 13:12 ` Paul Barker 2020-06-30 15:11 ` Denys Dmytriyenko 0 siblings, 1 reply; 10+ messages in thread From: Paul Barker @ 2020-06-30 13:12 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-arago On Tue, 30 Jun 2020 at 03:03, Denys Dmytriyenko <denys@ti.com> wrote: > > On Mon, Jun 29, 2020 at 06:43:02PM -0400, Denys Dmytriyenko wrote: > > On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > > > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > > > > > This change fixes the following error seen at parse time when the > > > > meta-arago-distro layer is present but sysvinit is not in > > > > DISTRO_FEATURES: > > > > > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > > > --- > > > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > > > 1 file changed, 5 insertions(+) > > > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > index 2eb2d777..a6e21745 100644 > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > @@ -1,3 +1,8 @@ > > > > +python __anonymous() { > > > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > > > +} > > > > + > > > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > > > > > PR = "r0" > > > > -- > > > > 2.26.2 > > > > > > > > > > Ping. > > > > Thanks, I'll merge it shortly. > > Actually, should this simply use REQUIRED_DISTRO_FEATURES from > features_check.bbclass? Actually, yes, that should work. We just need to set REQUIRED_DISTRO_FEATURES and inherit features_check before `require recipes-core/packagegroups/packagegroup-core-boot.bb` as that's where the error is raised. In an ideal world a packagegroup recipe really should not be changing VIRTUAL-RUNTIME values, those should be set at the distro conf level or in a multiconfig. I assume there's a good reason for setting these in this recipe, maybe it just needs adding in a comment. Thanks, -- Paul Barker Konsulko Group ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-30 13:12 ` Paul Barker @ 2020-06-30 15:11 ` Denys Dmytriyenko 2020-06-30 15:35 ` Paul Barker 0 siblings, 1 reply; 10+ messages in thread From: Denys Dmytriyenko @ 2020-06-30 15:11 UTC (permalink / raw) To: Paul Barker; +Cc: meta-arago On Tue, Jun 30, 2020 at 02:12:30PM +0100, Paul Barker wrote: > On Tue, 30 Jun 2020 at 03:03, Denys Dmytriyenko <denys@ti.com> wrote: > > > > On Mon, Jun 29, 2020 at 06:43:02PM -0400, Denys Dmytriyenko wrote: > > > On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > > > > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > > > > > > > This change fixes the following error seen at parse time when the > > > > > meta-arago-distro layer is present but sysvinit is not in > > > > > DISTRO_FEATURES: > > > > > > > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > > > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > > > > --- > > > > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > index 2eb2d777..a6e21745 100644 > > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > @@ -1,3 +1,8 @@ > > > > > +python __anonymous() { > > > > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > > > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > > > > +} > > > > > + > > > > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > > > > > > > PR = "r0" > > > > > -- > > > > > 2.26.2 > > > > > > > > > > > > > Ping. > > > > > > Thanks, I'll merge it shortly. > > > > Actually, should this simply use REQUIRED_DISTRO_FEATURES from > > features_check.bbclass? > > Actually, yes, that should work. We just need to set > REQUIRED_DISTRO_FEATURES and inherit features_check before `require > recipes-core/packagegroups/packagegroup-core-boot.bb` as that's where > the error is raised. > > In an ideal world a packagegroup recipe really should not be changing > VIRTUAL-RUNTIME values, those should be set at the distro conf level > or in a multiconfig. I assume there's a good reason for setting these > in this recipe, maybe it just needs adding in a comment. The distro sets them to systemd by default and most images are built with systemd. But we also need a tiny image with sysvinit built w/o overriding the defaults. -- Denys ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-30 15:11 ` Denys Dmytriyenko @ 2020-06-30 15:35 ` Paul Barker 2020-06-30 15:50 ` Denys Dmytriyenko 0 siblings, 1 reply; 10+ messages in thread From: Paul Barker @ 2020-06-30 15:35 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-arago On Tue, 30 Jun 2020 at 16:11, Denys Dmytriyenko <denys@ti.com> wrote: > > On Tue, Jun 30, 2020 at 02:12:30PM +0100, Paul Barker wrote: > > On Tue, 30 Jun 2020 at 03:03, Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > On Mon, Jun 29, 2020 at 06:43:02PM -0400, Denys Dmytriyenko wrote: > > > > On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > > > > > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > > > > > > > > > This change fixes the following error seen at parse time when the > > > > > > meta-arago-distro layer is present but sysvinit is not in > > > > > > DISTRO_FEATURES: > > > > > > > > > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > > > > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > > > > > --- > > > > > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > index 2eb2d777..a6e21745 100644 > > > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > @@ -1,3 +1,8 @@ > > > > > > +python __anonymous() { > > > > > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > > > > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > > > > > +} > > > > > > + > > > > > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > > > > > > > > > PR = "r0" > > > > > > -- > > > > > > 2.26.2 > > > > > > > > > > > > > > > > Ping. > > > > > > > > Thanks, I'll merge it shortly. > > > > > > Actually, should this simply use REQUIRED_DISTRO_FEATURES from > > > features_check.bbclass? > > > > Actually, yes, that should work. We just need to set > > REQUIRED_DISTRO_FEATURES and inherit features_check before `require > > recipes-core/packagegroups/packagegroup-core-boot.bb` as that's where > > the error is raised. > > > > In an ideal world a packagegroup recipe really should not be changing > > VIRTUAL-RUNTIME values, those should be set at the distro conf level > > or in a multiconfig. I assume there's a good reason for setting these > > in this recipe, maybe it just needs adding in a comment. > > The distro sets them to systemd by default and most images are built with > systemd. But we also need a tiny image with sysvinit built w/o overriding > the defaults. That sounds like it should be done by an `arago-tiny` distro rather than by image/packagegroup recipes. When building this image you've still got systemd in DISTRO_FEATURES and so some applications may be built in a way that requires systemd. -- Paul Barker Konsulko Group ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-30 15:35 ` Paul Barker @ 2020-06-30 15:50 ` Denys Dmytriyenko 2020-08-14 22:30 ` Denys Dmytriyenko 0 siblings, 1 reply; 10+ messages in thread From: Denys Dmytriyenko @ 2020-06-30 15:50 UTC (permalink / raw) To: Paul Barker; +Cc: meta-arago On Tue, Jun 30, 2020 at 04:35:21PM +0100, Paul Barker wrote: > On Tue, 30 Jun 2020 at 16:11, Denys Dmytriyenko <denys@ti.com> wrote: > > > > On Tue, Jun 30, 2020 at 02:12:30PM +0100, Paul Barker wrote: > > > On Tue, 30 Jun 2020 at 03:03, Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > > > On Mon, Jun 29, 2020 at 06:43:02PM -0400, Denys Dmytriyenko wrote: > > > > > On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > > > > > > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > > > > > > > > > > > This change fixes the following error seen at parse time when the > > > > > > > meta-arago-distro layer is present but sysvinit is not in > > > > > > > DISTRO_FEATURES: > > > > > > > > > > > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > > > > > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > > > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > > > > > > --- > > > > > > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > index 2eb2d777..a6e21745 100644 > > > > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > @@ -1,3 +1,8 @@ > > > > > > > +python __anonymous() { > > > > > > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > > > > > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > > > > > > +} > > > > > > > + > > > > > > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > > > > > > > > > > > PR = "r0" > > > > > > > -- > > > > > > > 2.26.2 > > > > > > > > > > > > > > > > > > > Ping. > > > > > > > > > > Thanks, I'll merge it shortly. > > > > > > > > Actually, should this simply use REQUIRED_DISTRO_FEATURES from > > > > features_check.bbclass? > > > > > > Actually, yes, that should work. We just need to set > > > REQUIRED_DISTRO_FEATURES and inherit features_check before `require > > > recipes-core/packagegroups/packagegroup-core-boot.bb` as that's where > > > the error is raised. > > > > > > In an ideal world a packagegroup recipe really should not be changing > > > VIRTUAL-RUNTIME values, those should be set at the distro conf level > > > or in a multiconfig. I assume there's a good reason for setting these > > > in this recipe, maybe it just needs adding in a comment. > > > > The distro sets them to systemd by default and most images are built with > > systemd. But we also need a tiny image with sysvinit built w/o overriding > > the defaults. > > That sounds like it should be done by an `arago-tiny` distro rather > than by image/packagegroup recipes. When building this image you've > still got systemd in DISTRO_FEATURES and so some applications may be > built in a way that requires systemd. A new distro is not going to work in this case - tiny image is needed along the side of other systemd images and may be packaged and used inside as initramfs and demo rootfs for Jailhouse or other hypervisors. -- Denys ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-06-30 15:50 ` Denys Dmytriyenko @ 2020-08-14 22:30 ` Denys Dmytriyenko 2020-10-19 19:15 ` Paul Barker 0 siblings, 1 reply; 10+ messages in thread From: Denys Dmytriyenko @ 2020-08-14 22:30 UTC (permalink / raw) To: Paul Barker; +Cc: meta-arago On Tue, Jun 30, 2020 at 11:50:49AM -0400, Denys Dmytriyenko wrote: > On Tue, Jun 30, 2020 at 04:35:21PM +0100, Paul Barker wrote: > > On Tue, 30 Jun 2020 at 16:11, Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > On Tue, Jun 30, 2020 at 02:12:30PM +0100, Paul Barker wrote: > > > > On Tue, 30 Jun 2020 at 03:03, Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > > > > > On Mon, Jun 29, 2020 at 06:43:02PM -0400, Denys Dmytriyenko wrote: > > > > > > On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > > > > > > > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > > > > > > > > > > > > > This change fixes the following error seen at parse time when the > > > > > > > > meta-arago-distro layer is present but sysvinit is not in > > > > > > > > DISTRO_FEATURES: > > > > > > > > > > > > > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > > > > > > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > > > > > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > > > > > > > --- > > > > > > > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > index 2eb2d777..a6e21745 100644 > > > > > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > @@ -1,3 +1,8 @@ > > > > > > > > +python __anonymous() { > > > > > > > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > > > > > > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > > > > > > > +} > > > > > > > > + > > > > > > > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > > > > > > > > > > > > > PR = "r0" > > > > > > > > -- > > > > > > > > 2.26.2 > > > > > > > > > > > > > > > > > > > > > > Ping. > > > > > > > > > > > > Thanks, I'll merge it shortly. > > > > > > > > > > Actually, should this simply use REQUIRED_DISTRO_FEATURES from > > > > > features_check.bbclass? > > > > > > > > Actually, yes, that should work. We just need to set > > > > REQUIRED_DISTRO_FEATURES and inherit features_check before `require > > > > recipes-core/packagegroups/packagegroup-core-boot.bb` as that's where > > > > the error is raised. > > > > > > > > In an ideal world a packagegroup recipe really should not be changing > > > > VIRTUAL-RUNTIME values, those should be set at the distro conf level > > > > or in a multiconfig. I assume there's a good reason for setting these > > > > in this recipe, maybe it just needs adding in a comment. > > > > > > The distro sets them to systemd by default and most images are built with > > > systemd. But we also need a tiny image with sysvinit built w/o overriding > > > the defaults. > > > > That sounds like it should be done by an `arago-tiny` distro rather > > than by image/packagegroup recipes. When building this image you've > > still got systemd in DISTRO_FEATURES and so some applications may be > > built in a way that requires systemd. > > A new distro is not going to work in this case - tiny image is needed along > the side of other systemd images and may be packaged and used inside as > initramfs and demo rootfs for Jailhouse or other hypervisors. Paul, Any updates on this? Do you still need it? Do you have a patch with REQUIRED_DISTRO_FEATURES as discussed above? -- Denys ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled 2020-08-14 22:30 ` Denys Dmytriyenko @ 2020-10-19 19:15 ` Paul Barker 0 siblings, 0 replies; 10+ messages in thread From: Paul Barker @ 2020-10-19 19:15 UTC (permalink / raw) To: Denys Dmytriyenko; +Cc: meta-arago On Fri, 14 Aug 2020 at 23:30, Denys Dmytriyenko <denys@ti.com> wrote: > > On Tue, Jun 30, 2020 at 11:50:49AM -0400, Denys Dmytriyenko wrote: > > On Tue, Jun 30, 2020 at 04:35:21PM +0100, Paul Barker wrote: > > > On Tue, 30 Jun 2020 at 16:11, Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > > > On Tue, Jun 30, 2020 at 02:12:30PM +0100, Paul Barker wrote: > > > > > On Tue, 30 Jun 2020 at 03:03, Denys Dmytriyenko <denys@ti.com> wrote: > > > > > > > > > > > > On Mon, Jun 29, 2020 at 06:43:02PM -0400, Denys Dmytriyenko wrote: > > > > > > > On Tue, Jun 23, 2020 at 09:12:00AM +0100, Paul Barker wrote: > > > > > > > > On Tue, 9 Jun 2020 at 11:28, Paul Barker <pbarker@konsulko.com> wrote: > > > > > > > > > > > > > > > > > > This change fixes the following error seen at parse time when the > > > > > > > > > meta-arago-distro layer is present but sysvinit is not in > > > > > > > > > DISTRO_FEATURES: > > > > > > > > > > > > > > > > > > ERROR: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb: Please ensure that your setting of VIRTUAL-RUNTIME_init_manager (sysvinit) matches the entries enabled in DISTRO_FEATURES > > > > > > > > > ERROR: Failed to parse recipe: .../meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > > > > > > > > > > Signed-off-by: Paul Barker <pbarker@konsulko.com> > > > > > > > > > --- > > > > > > > > > .../packagegroups/packagegroup-arago-sysvinit-boot.bb | 5 +++++ > > > > > > > > > 1 file changed, 5 insertions(+) > > > > > > > > > > > > > > > > > > diff --git a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > index 2eb2d777..a6e21745 100644 > > > > > > > > > --- a/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > +++ b/meta-arago-distro/recipes-core/packagegroups/packagegroup-arago-sysvinit-boot.bb > > > > > > > > > @@ -1,3 +1,8 @@ > > > > > > > > > +python __anonymous() { > > > > > > > > > + if not "sysvinit" in d.getVar("DISTRO_FEATURES").split(): > > > > > > > > > + raise bb.parse.SkipRecipe("sysvinit is not enabled") > > > > > > > > > +} > > > > > > > > > + > > > > > > > > > require recipes-core/packagegroups/packagegroup-core-boot.bb > > > > > > > > > > > > > > > > > > PR = "r0" > > > > > > > > > -- > > > > > > > > > 2.26.2 > > > > > > > > > > > > > > > > > > > > > > > > > Ping. > > > > > > > > > > > > > > Thanks, I'll merge it shortly. > > > > > > > > > > > > Actually, should this simply use REQUIRED_DISTRO_FEATURES from > > > > > > features_check.bbclass? > > > > > > > > > > Actually, yes, that should work. We just need to set > > > > > REQUIRED_DISTRO_FEATURES and inherit features_check before `require > > > > > recipes-core/packagegroups/packagegroup-core-boot.bb` as that's where > > > > > the error is raised. > > > > > > > > > > In an ideal world a packagegroup recipe really should not be changing > > > > > VIRTUAL-RUNTIME values, those should be set at the distro conf level > > > > > or in a multiconfig. I assume there's a good reason for setting these > > > > > in this recipe, maybe it just needs adding in a comment. > > > > > > > > The distro sets them to systemd by default and most images are built with > > > > systemd. But we also need a tiny image with sysvinit built w/o overriding > > > > the defaults. > > > > > > That sounds like it should be done by an `arago-tiny` distro rather > > > than by image/packagegroup recipes. When building this image you've > > > still got systemd in DISTRO_FEATURES and so some applications may be > > > built in a way that requires systemd. > > > > A new distro is not going to work in this case - tiny image is needed along > > the side of other systemd images and may be packaged and used inside as > > initramfs and demo rootfs for Jailhouse or other hypervisors. > > Paul, > > Any updates on this? Do you still need it? > Do you have a patch with REQUIRED_DISTRO_FEATURES as discussed above? Now I've resolved the issues with my other patch I'm confident this change is good. I'll resubmit the patch using REQUIRED_DISTRO_FEATURES. Thanks, -- Paul Barker Konsulko Group ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-10-19 19:18 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2020-06-09 10:28 [master/dunfell][PATCH] packagegroup-arago-sysvinit-boot: Skip recipe if sysvinit is not enabled Paul Barker 2020-06-23 8:12 ` Paul Barker 2020-06-29 22:43 ` Denys Dmytriyenko 2020-06-30 2:03 ` Denys Dmytriyenko 2020-06-30 13:12 ` Paul Barker 2020-06-30 15:11 ` Denys Dmytriyenko 2020-06-30 15:35 ` Paul Barker 2020-06-30 15:50 ` Denys Dmytriyenko 2020-08-14 22:30 ` Denys Dmytriyenko 2020-10-19 19:15 ` Paul Barker
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.