From: Tomasz Figa <tfiga@chromium.org>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
shengnan.wang@mediatek.com, louis.kuo@mediatek.com,
bgolaszewski@baylibre.com, sj.huang@mediatek.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
sakari.ailus@linux.intel.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH V11 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver
Date: Tue, 30 Jun 2020 17:07:46 +0000 [thread overview]
Message-ID: <20200630170746.GD1212092@chromium.org> (raw)
In-Reply-To: <20200630024942.20891-3-dongchun.zhu@mediatek.com>
Hi Dongchun,
On Tue, Jun 30, 2020 at 10:49:42AM +0800, Dongchun Zhu wrote:
> Add a V4L2 sub-device driver for OV02A10 image sensor.
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
> MAINTAINERS | 1 +
> drivers/media/i2c/Kconfig | 13 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov02a10.c | 1052 +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 1067 insertions(+)
> create mode 100644 drivers/media/i2c/ov02a10.c
Thank you for the patch. Please see my comments inline.
[snip]
> +static int ov02a10_entity_init_cfg(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg)
> +{
> + struct v4l2_subdev_format fmt = {
> + .which = cfg ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE,
As we discussed before, this function is never called with cfg == NULL.
Perhaps what we need here is to call ov02a10_set_fmt() twice, once for
V4L2_SUBDEV_FORMAT_ACTIVE and then for V4L2_SUBDEV_FORMAT_TRY?
Sakari, would that be a proper implementation of this function?
> + .format = {
> + .width = 1600,
> + .height = 1200,
> + }
> + };
> +
> + ov02a10_set_fmt(sd, cfg, &fmt);
> +
> + return 0;
[snip]
With this and Sakari's comment about the initial state of the reset pin
fixed, feel free to add my
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tfiga@chromium.org>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: mark.rutland@arm.com, drinkcat@chromium.org,
andriy.shevchenko@linux.intel.com, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linus.walleij@linaro.org,
shengnan.wang@mediatek.com, louis.kuo@mediatek.com,
bgolaszewski@baylibre.com, sj.huang@mediatek.com,
robh+dt@kernel.org, linux-mediatek@lists.infradead.org,
sakari.ailus@linux.intel.com, matthias.bgg@gmail.com,
bingbu.cao@intel.com, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH V11 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver
Date: Tue, 30 Jun 2020 17:07:46 +0000 [thread overview]
Message-ID: <20200630170746.GD1212092@chromium.org> (raw)
In-Reply-To: <20200630024942.20891-3-dongchun.zhu@mediatek.com>
Hi Dongchun,
On Tue, Jun 30, 2020 at 10:49:42AM +0800, Dongchun Zhu wrote:
> Add a V4L2 sub-device driver for OV02A10 image sensor.
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
> MAINTAINERS | 1 +
> drivers/media/i2c/Kconfig | 13 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov02a10.c | 1052 +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 1067 insertions(+)
> create mode 100644 drivers/media/i2c/ov02a10.c
Thank you for the patch. Please see my comments inline.
[snip]
> +static int ov02a10_entity_init_cfg(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg)
> +{
> + struct v4l2_subdev_format fmt = {
> + .which = cfg ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE,
As we discussed before, this function is never called with cfg == NULL.
Perhaps what we need here is to call ov02a10_set_fmt() twice, once for
V4L2_SUBDEV_FORMAT_ACTIVE and then for V4L2_SUBDEV_FORMAT_TRY?
Sakari, would that be a proper implementation of this function?
> + .format = {
> + .width = 1600,
> + .height = 1200,
> + }
> + };
> +
> + ov02a10_set_fmt(sd, cfg, &fmt);
> +
> + return 0;
[snip]
With this and Sakari's comment about the initial state of the reset pin
fixed, feel free to add my
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Figa <tfiga@chromium.org>
To: Dongchun Zhu <dongchun.zhu@mediatek.com>
Cc: linus.walleij@linaro.org, bgolaszewski@baylibre.com,
mchehab@kernel.org, andriy.shevchenko@linux.intel.com,
robh+dt@kernel.org, mark.rutland@arm.com,
sakari.ailus@linux.intel.com, drinkcat@chromium.org,
matthias.bgg@gmail.com, bingbu.cao@intel.com,
srv_heupstream@mediatek.com, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, sj.huang@mediatek.com,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
louis.kuo@mediatek.com, shengnan.wang@mediatek.com
Subject: Re: [PATCH V11 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver
Date: Tue, 30 Jun 2020 17:07:46 +0000 [thread overview]
Message-ID: <20200630170746.GD1212092@chromium.org> (raw)
In-Reply-To: <20200630024942.20891-3-dongchun.zhu@mediatek.com>
Hi Dongchun,
On Tue, Jun 30, 2020 at 10:49:42AM +0800, Dongchun Zhu wrote:
> Add a V4L2 sub-device driver for OV02A10 image sensor.
>
> Signed-off-by: Dongchun Zhu <dongchun.zhu@mediatek.com>
> ---
> MAINTAINERS | 1 +
> drivers/media/i2c/Kconfig | 13 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov02a10.c | 1052 +++++++++++++++++++++++++++++++++++++++++++
> 4 files changed, 1067 insertions(+)
> create mode 100644 drivers/media/i2c/ov02a10.c
Thank you for the patch. Please see my comments inline.
[snip]
> +static int ov02a10_entity_init_cfg(struct v4l2_subdev *sd,
> + struct v4l2_subdev_pad_config *cfg)
> +{
> + struct v4l2_subdev_format fmt = {
> + .which = cfg ? V4L2_SUBDEV_FORMAT_TRY : V4L2_SUBDEV_FORMAT_ACTIVE,
As we discussed before, this function is never called with cfg == NULL.
Perhaps what we need here is to call ov02a10_set_fmt() twice, once for
V4L2_SUBDEV_FORMAT_ACTIVE and then for V4L2_SUBDEV_FORMAT_TRY?
Sakari, would that be a proper implementation of this function?
> + .format = {
> + .width = 1600,
> + .height = 1200,
> + }
> + };
> +
> + ov02a10_set_fmt(sd, cfg, &fmt);
> +
> + return 0;
[snip]
With this and Sakari's comment about the initial state of the reset pin
fixed, feel free to add my
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
next prev parent reply other threads:[~2020-06-30 17:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 2:49 [PATCH V11 0/2] media: i2c: Add support for 0V02A10 sensor Dongchun Zhu
2020-06-30 2:49 ` Dongchun Zhu
2020-06-30 2:49 ` Dongchun Zhu
2020-06-30 2:49 ` [PATCH V11 1/2] media: dt-bindings: media: i2c: Document OV02A10 bindings Dongchun Zhu
2020-06-30 2:49 ` Dongchun Zhu
2020-06-30 2:49 ` Dongchun Zhu
2020-06-30 16:59 ` Tomasz Figa
2020-06-30 16:59 ` Tomasz Figa
2020-06-30 16:59 ` Tomasz Figa
2020-06-30 2:49 ` [PATCH V11 2/2] media: i2c: ov02a10: Add OV02A10 image sensor driver Dongchun Zhu
2020-06-30 2:49 ` Dongchun Zhu
2020-06-30 2:49 ` Dongchun Zhu
2020-06-30 9:54 ` Sakari Ailus
2020-06-30 9:54 ` Sakari Ailus
2020-06-30 9:54 ` Sakari Ailus
2020-06-30 14:19 ` Tomasz Figa
2020-06-30 14:19 ` Tomasz Figa
2020-06-30 14:19 ` Tomasz Figa
2020-06-30 14:21 ` Tomasz Figa
2020-06-30 14:21 ` Tomasz Figa
2020-06-30 14:21 ` Tomasz Figa
2020-06-30 14:37 ` Andy Shevchenko
2020-06-30 14:37 ` Andy Shevchenko
2020-06-30 14:37 ` Andy Shevchenko
2020-06-30 14:40 ` Tomasz Figa
2020-06-30 14:40 ` Tomasz Figa
2020-06-30 14:40 ` Tomasz Figa
2020-07-01 7:58 ` Dongchun Zhu
2020-07-01 7:58 ` Dongchun Zhu
2020-07-01 7:58 ` Dongchun Zhu
2020-06-30 17:07 ` Tomasz Figa [this message]
2020-06-30 17:07 ` Tomasz Figa
2020-06-30 17:07 ` Tomasz Figa
2020-06-30 18:47 ` Sakari Ailus
2020-06-30 18:47 ` Sakari Ailus
2020-06-30 18:47 ` Sakari Ailus
2020-07-01 8:47 ` Dongchun Zhu
2020-07-01 8:47 ` Dongchun Zhu
2020-07-01 8:47 ` Dongchun Zhu
2020-07-01 9:00 ` Sakari Ailus
2020-07-01 9:00 ` Sakari Ailus
2020-07-01 9:00 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630170746.GD1212092@chromium.org \
--to=tfiga@chromium.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bgolaszewski@baylibre.com \
--cc=bingbu.cao@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dongchun.zhu@mediatek.com \
--cc=drinkcat@chromium.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=louis.kuo@mediatek.com \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=shengnan.wang@mediatek.com \
--cc=sj.huang@mediatek.com \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.