All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sidong Yang <realwakka@gmail.com>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Haneen Mohammed <hamohammed.sa@gmail.com>,
	David Airlie <airlied@linux.ie>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Sidong Yang <realwakka@gmail.com>
Subject: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail
Date: Wed,  1 Jul 2020 15:31:34 +0000	[thread overview]
Message-ID: <20200701153134.4187-1-realwakka@gmail.com> (raw)

there is an error when igt test is run continuously. vkms_atomic_commit_tail()
need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of
vblank events. without this code, next atomic commit will not enable vblank
and raise timeout error.

Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
 drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 1e8b2169d834..10b9be67a068 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -93,6 +93,8 @@ static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state)
 		flush_work(&vkms_state->composer_work);
 	}
 
+	drm_atomic_helper_wait_for_vblanks(dev, old_state);
+
 	drm_atomic_helper_cleanup_planes(dev, old_state);
 }
 
-- 
2.17.1

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Sidong Yang <realwakka@gmail.com>
To: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
Cc: Sidong Yang <realwakka@gmail.com>,
	Emil Velikov <emil.l.velikov@gmail.com>,
	Haneen Mohammed <hamohammed.sa@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail
Date: Wed,  1 Jul 2020 15:31:34 +0000	[thread overview]
Message-ID: <20200701153134.4187-1-realwakka@gmail.com> (raw)

there is an error when igt test is run continuously. vkms_atomic_commit_tail()
need to call drm_atomic_helper_wait_for_vblanks() for give up ownership of
vblank events. without this code, next atomic commit will not enable vblank
and raise timeout error.

Signed-off-by: Sidong Yang <realwakka@gmail.com>
---
 drivers/gpu/drm/vkms/vkms_drv.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
index 1e8b2169d834..10b9be67a068 100644
--- a/drivers/gpu/drm/vkms/vkms_drv.c
+++ b/drivers/gpu/drm/vkms/vkms_drv.c
@@ -93,6 +93,8 @@ static void vkms_atomic_commit_tail(struct drm_atomic_state *old_state)
 		flush_work(&vkms_state->composer_work);
 	}
 
+	drm_atomic_helper_wait_for_vblanks(dev, old_state);
+
 	drm_atomic_helper_cleanup_planes(dev, old_state);
 }
 
-- 
2.17.1


             reply	other threads:[~2020-07-01 15:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01 15:31 Sidong Yang [this message]
2020-07-01 15:31 ` [PATCH] drm/vkms: add wait_for_vblanks in atomic_commit_tail Sidong Yang
2020-07-02 13:13 ` Daniel Vetter
2020-07-02 13:13   ` Daniel Vetter
2020-07-10 17:05   ` Melissa Wen
2020-07-10 17:05     ` Melissa Wen
2020-07-13 16:06     ` Daniel Vetter
2020-07-13 16:06       ` Daniel Vetter
2020-07-14 10:20       ` Melissa Wen
2020-07-14 10:20         ` Melissa Wen
2020-07-14 10:39         ` Melissa Wen
2020-07-14 10:39           ` Melissa Wen
2020-07-14 14:09           ` Daniel Vetter
2020-07-14 14:09             ` Daniel Vetter
2020-07-14 18:35             ` Melissa Wen
2020-07-14 18:35               ` Melissa Wen
2020-07-15  8:17               ` Daniel Vetter
2020-07-15  8:17                 ` Daniel Vetter
2020-07-15 12:43                 ` Sidong Yang
2020-07-15 12:43                   ` Sidong Yang
2020-07-15 15:57                   ` Melissa Wen
2020-07-15 15:57                     ` Melissa Wen
2020-07-15 16:08                     ` Daniel Vetter
2020-07-15 16:08                       ` Daniel Vetter
2020-07-21  5:33                       ` Sidong Yang
2020-07-21  5:33                         ` Sidong Yang
2020-07-21  6:44                         ` Daniel Vetter
2020-07-21  6:44                           ` Daniel Vetter
2020-07-21 12:59                           ` Melissa Wen
2020-07-21 12:59                             ` Melissa Wen
2020-07-21 13:58                             ` Daniel Vetter
2020-07-21 13:58                               ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200701153134.4187-1-realwakka@gmail.com \
    --to=realwakka@gmail.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=hamohammed.sa@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rodrigosiqueiramelo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.