From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: hulkcommits@huawei.com, Hulk Robot <hulkci@huawei.com>,
linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH -next] f2fs: make __allocate_new_segment() static
Date: Wed, 1 Jul 2020 09:16:18 -0700 [thread overview]
Message-ID: <20200701161618.GC1724572@google.com> (raw)
In-Reply-To: <20200701152858.50516-1-weiyongjun1@huawei.com>
On 07/01, Wei Yongjun wrote:
> From: Hulk Robot <hulkci@huawei.com>
>
> From: Hulk Robot <hulkci@huawei.com>
>
> Fix sparse build warning:
>
> fs/f2fs/segment.c:2736:6: warning:
> symbol '__allocate_new_segment' was not declared. Should it be static?
It was fixed.
https://lore.kernel.org/linux-f2fs-devel/20200701042222.GA1539525@google.com/T/#m9667447e4d37672e26dee7e30896d129eac1c479
>
> Signed-off-by: Hulk Robot <hulkci@huawei.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index b45e473508a9..c35614d255e1 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2733,7 +2733,7 @@ void f2fs_allocate_segment_for_resize(struct f2fs_sb_info *sbi, int type,
> up_read(&SM_I(sbi)->curseg_lock);
> }
>
> -void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> +static void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> {
> struct curseg_info *curseg = CURSEG_I(sbi, type);
> unsigned int old_segno;
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
WARNING: multiple messages have this Message-ID (diff)
From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: hulkcommits@huawei.com, Chao Yu <chao@kernel.org>,
Hulk Robot <hulkci@huawei.com>,
linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] f2fs: make __allocate_new_segment() static
Date: Wed, 1 Jul 2020 09:16:18 -0700 [thread overview]
Message-ID: <20200701161618.GC1724572@google.com> (raw)
In-Reply-To: <20200701152858.50516-1-weiyongjun1@huawei.com>
On 07/01, Wei Yongjun wrote:
> From: Hulk Robot <hulkci@huawei.com>
>
> From: Hulk Robot <hulkci@huawei.com>
>
> Fix sparse build warning:
>
> fs/f2fs/segment.c:2736:6: warning:
> symbol '__allocate_new_segment' was not declared. Should it be static?
It was fixed.
https://lore.kernel.org/linux-f2fs-devel/20200701042222.GA1539525@google.com/T/#m9667447e4d37672e26dee7e30896d129eac1c479
>
> Signed-off-by: Hulk Robot <hulkci@huawei.com>
> ---
> fs/f2fs/segment.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
> index b45e473508a9..c35614d255e1 100644
> --- a/fs/f2fs/segment.c
> +++ b/fs/f2fs/segment.c
> @@ -2733,7 +2733,7 @@ void f2fs_allocate_segment_for_resize(struct f2fs_sb_info *sbi, int type,
> up_read(&SM_I(sbi)->curseg_lock);
> }
>
> -void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> +static void __allocate_new_segment(struct f2fs_sb_info *sbi, int type)
> {
> struct curseg_info *curseg = CURSEG_I(sbi, type);
> unsigned int old_segno;
next prev parent reply other threads:[~2020-07-01 16:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-01 15:28 [f2fs-dev] [PATCH -next] f2fs: make __allocate_new_segment() static Wei Yongjun
2020-07-01 15:28 ` Wei Yongjun
2020-07-01 16:16 ` Jaegeuk Kim [this message]
2020-07-01 16:16 ` Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200701161618.GC1724572@google.com \
--to=jaegeuk@kernel.org \
--cc=hulkci@huawei.com \
--cc=hulkcommits@huawei.com \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.