From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Pankaj Dubey <pankaj.dubey@samsung.com>
Subject: Re: [PATCH 3/4] arm64: dts: exynos: Align DMA controller bus node name with dtschema
Date: Thu, 2 Jul 2020 08:01:15 +0200 [thread overview]
Message-ID: <20200702060115.GB4175@kozik-lap> (raw)
In-Reply-To: <3c1eb3fe-8eef-1f91-ff4e-3081a871fc80@samsung.com>
On Tue, Jun 30, 2020 at 09:34:52AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 29.06.2020 22:44, Krzysztof Kozlowski wrote:
> > AMBA is a bus so name the node with DMA controllers just as "bus" to fix
> > dtschema warnings like:
> >
> > amba: $nodename:0: 'amba' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Do we really need a separate 'bus' for those DMA controllers?
>
> IMHO they are not different from the hw perspective from the other
> devices available on the SoC. A separate bus is a historical thing, they
> work fine when moved directly under the 'soc' node. The separate bus
> only mimics the way Linux organizes its drivers. This comment affects
> both ARM and ARM64.
Good point, other boards keep them under SoC usually. Thanks for
feedback.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Sylwester Nawrocki <snawrocki@kernel.org>,
Pankaj Dubey <pankaj.dubey@samsung.com>,
linux-kernel@vger.kernel.org,
Chanwoo Choi <cw00.choi@samsung.com>,
Rob Herring <robh+dt@kernel.org>, Kukjin Kim <kgene@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] arm64: dts: exynos: Align DMA controller bus node name with dtschema
Date: Thu, 2 Jul 2020 08:01:15 +0200 [thread overview]
Message-ID: <20200702060115.GB4175@kozik-lap> (raw)
In-Reply-To: <3c1eb3fe-8eef-1f91-ff4e-3081a871fc80@samsung.com>
On Tue, Jun 30, 2020 at 09:34:52AM +0200, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 29.06.2020 22:44, Krzysztof Kozlowski wrote:
> > AMBA is a bus so name the node with DMA controllers just as "bus" to fix
> > dtschema warnings like:
> >
> > amba: $nodename:0: 'amba' does not match '^(bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$'
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Do we really need a separate 'bus' for those DMA controllers?
>
> IMHO they are not different from the hw perspective from the other
> devices available on the SoC. A separate bus is a historical thing, they
> work fine when moved directly under the 'soc' node. The separate bus
> only mimics the way Linux organizes its drivers. This comment affects
> both ARM and ARM64.
Good point, other boards keep them under SoC usually. Thanks for
feedback.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-02 6:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200629205534epcas5p33eb7cbdff4aee986d2e509e0c79cf952@epcas5p3.samsung.com>
2020-06-29 20:44 ` [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7 Krzysztof Kozlowski
2020-06-29 20:44 ` Krzysztof Kozlowski
2020-06-29 20:44 ` [PATCH 2/4] arm64: dts: exynos: Remove generic arm,armv8-pmuv3 compatible Krzysztof Kozlowski
2020-06-29 20:44 ` [PATCH 2/4] arm64: dts: exynos: Remove generic arm, armv8-pmuv3 compatible Krzysztof Kozlowski
2020-06-29 20:44 ` [PATCH 3/4] arm64: dts: exynos: Align DMA controller bus node name with dtschema Krzysztof Kozlowski
2020-06-29 20:44 ` Krzysztof Kozlowski
2020-06-30 7:34 ` Marek Szyprowski
2020-06-30 7:34 ` Marek Szyprowski
2020-07-02 6:01 ` Krzysztof Kozlowski [this message]
2020-07-02 6:01 ` Krzysztof Kozlowski
2020-06-29 20:44 ` [PATCH 4/4] ARM: " Krzysztof Kozlowski
2020-06-29 20:44 ` Krzysztof Kozlowski
2020-06-30 15:24 ` [PATCH 1/4] arm64: dts: exynos: Add PWM interrupts on Exynos7 Alim Akhtar
2020-06-30 15:24 ` Alim Akhtar
2020-07-02 6:00 ` 'Krzysztof Kozlowski'
2020-07-02 6:00 ` 'Krzysztof Kozlowski'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702060115.GB4175@kozik-lap \
--to=krzk@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=pankaj.dubey@samsung.com \
--cc=robh+dt@kernel.org \
--cc=snawrocki@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.