From: Lee Jones <lee.jones@linaro.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Gene Chen <gene_chen@richtek.com>,
lars@metafoo.de, pmeerw@pmeerw.net, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, cy_huang@richtek.com,
benjamin.chao@mediatek.com, Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org, jacek.anaszewski@gmail.com,
pavel@ucw.cz, knaack.h@gmx.de, matthias.bgg@gmail.com,
shufan_lee@richtek.com, jic23@kernel.org, dmurphy@ti.com
Subject: Re: [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC
Date: Thu, 2 Jul 2020 11:27:48 +0100 [thread overview]
Message-ID: <20200702102748.GS1179328@dell> (raw)
In-Reply-To: <CAE+NS35Kj_H9uSgBiff4hogTWmwh6z+vmPNWDh_yU1=p68xQZA@mail.gmail.com>
On Thu, 02 Jul 2020, Gene Chen wrote:
> Lee Jones <lee.jones@linaro.org> 於 2020年7月1日 週三 下午3:16寫道：
> >
> > On Fri, 19 Jun 2020, Gene Chen wrote:
> >
> > > From: Gene Chen <gene_chen@richtek.com>
> > >
> > > imlement i2c R/W with CRC when access sub-device PMIC and LDO part
> >
> > Please use proper grammar, including capital letters at the start of
> > the sentence and for abbreviations such as "I2C" and full stops.
> >
> > Also this doesn't make sense to me. Please elaborate.
> >
>
> ACK
>
> > > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > > ---
> > > drivers/mfd/Kconfig | 1 +
> > > drivers/mfd/mt6360-core.c | 541 +++++++++++++++++++++++++++++----------------
> >
> > This patch is doing way too much wacky stuff all at once, making it
> > very difficult to review. Please break it up into functional pieces
> > and submit as separate logical patches (in a set of course).
> >
>
> If I understand correctly, I need to separate patch[2/4] but not
> entire mt6362-core.c into several patches.
Yes please.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Gene Chen <gene_chen@richtek.com>,
lars@metafoo.de, pmeerw@pmeerw.net, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, cy_huang@richtek.com,
benjamin.chao@mediatek.com, Mark Brown <broonie@kernel.org>,
linux-mediatek@lists.infradead.org, jacek.anaszewski@gmail.com,
pavel@ucw.cz, knaack.h@gmx.de, matthias.bgg@gmail.com,
shufan_lee@richtek.com, jic23@kernel.org, dmurphy@ti.com
Subject: Re: [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC
Date: Thu, 2 Jul 2020 11:27:48 +0100 [thread overview]
Message-ID: <20200702102748.GS1179328@dell> (raw)
In-Reply-To: <CAE+NS35Kj_H9uSgBiff4hogTWmwh6z+vmPNWDh_yU1=p68xQZA@mail.gmail.com>
On Thu, 02 Jul 2020, Gene Chen wrote:
> Lee Jones <lee.jones@linaro.org> 於 2020年7月1日 週三 下午3:16寫道：
> >
> > On Fri, 19 Jun 2020, Gene Chen wrote:
> >
> > > From: Gene Chen <gene_chen@richtek.com>
> > >
> > > imlement i2c R/W with CRC when access sub-device PMIC and LDO part
> >
> > Please use proper grammar, including capital letters at the start of
> > the sentence and for abbreviations such as "I2C" and full stops.
> >
> > Also this doesn't make sense to me. Please elaborate.
> >
>
> ACK
>
> > > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > > ---
> > > drivers/mfd/Kconfig | 1 +
> > > drivers/mfd/mt6360-core.c | 541 +++++++++++++++++++++++++++++----------------
> >
> > This patch is doing way too much wacky stuff all at once, making it
> > very difficult to review. Please break it up into functional pieces
> > and submit as separate logical patches (in a set of course).
> >
>
> If I understand correctly, I need to separate patch[2/4] but not
> entire mt6362-core.c into several patches.
Yes please.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: jic23@kernel.org, jacek.anaszewski@gmail.com, pavel@ucw.cz,
matthias.bgg@gmail.com, knaack.h@gmx.de, lars@metafoo.de,
pmeerw@pmeerw.net, dmurphy@ti.com, lgirdwood@gmail.com,
Mark Brown <broonie@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Gene Chen <gene_chen@richtek.com>,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC
Date: Thu, 2 Jul 2020 11:27:48 +0100 [thread overview]
Message-ID: <20200702102748.GS1179328@dell> (raw)
In-Reply-To: <CAE+NS35Kj_H9uSgBiff4hogTWmwh6z+vmPNWDh_yU1=p68xQZA@mail.gmail.com>
On Thu, 02 Jul 2020, Gene Chen wrote:
> Lee Jones <lee.jones@linaro.org> 於 2020年7月1日 週三 下午3:16寫道：
> >
> > On Fri, 19 Jun 2020, Gene Chen wrote:
> >
> > > From: Gene Chen <gene_chen@richtek.com>
> > >
> > > imlement i2c R/W with CRC when access sub-device PMIC and LDO part
> >
> > Please use proper grammar, including capital letters at the start of
> > the sentence and for abbreviations such as "I2C" and full stops.
> >
> > Also this doesn't make sense to me. Please elaborate.
> >
>
> ACK
>
> > > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > > ---
> > > drivers/mfd/Kconfig | 1 +
> > > drivers/mfd/mt6360-core.c | 541 +++++++++++++++++++++++++++++----------------
> >
> > This patch is doing way too much wacky stuff all at once, making it
> > very difficult to review. Please break it up into functional pieces
> > and submit as separate logical patches (in a set of course).
> >
>
> If I understand correctly, I need to separate patch[2/4] but not
> entire mt6362-core.c into several patches.
Yes please.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-02 10:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-19 11:53 [PATCH v2 0/4] dt-bindings: mfd: Add bindings for the Mediatek MT6360 Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-19 11:53 ` [PATCH v2 1/4] dt-bindings: mfd: Add bindings for the Mediatek MT6360 PMIC Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-22 10:24 ` Lee Jones
2020-06-19 11:53 ` [PATCH v2 2/4] mfd: mt6360: implement i2c R/W with CRC Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-07-01 7:16 ` Lee Jones
2020-07-01 7:16 ` Lee Jones
2020-07-01 7:16 ` Lee Jones
2020-07-02 8:29 ` Gene Chen
2020-07-02 8:29 ` Gene Chen
2020-07-02 8:29 ` Gene Chen
2020-07-02 10:27 ` Lee Jones [this message]
2020-07-02 10:27 ` Lee Jones
2020-07-02 10:27 ` Lee Jones
2020-06-19 11:53 ` [PATCH v2 3/4] iio: adc: mt6360: Add ADC driver for MT6360 Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-20 17:03 ` Jonathan Cameron
2020-06-20 17:03 ` Jonathan Cameron
2020-06-20 17:03 ` Jonathan Cameron
2020-06-19 11:53 ` [PATCH v2 4/4] regulator: mt6360: Add support for MT6360 regulator Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-19 11:53 ` Gene Chen
2020-06-20 16:55 ` [PATCH v2 0/4] dt-bindings: mfd: Add bindings for the Mediatek MT6360 Jonathan Cameron
2020-06-20 16:55 ` Jonathan Cameron
2020-06-20 16:55 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200702102748.GS1179328@dell \
--to=lee.jones@linaro.org \
--cc=benjamin.chao@mediatek.com \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=dmurphy@ti.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=jacek.anaszewski@gmail.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=pavel@ucw.cz \
--cc=pmeerw@pmeerw.net \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.