From: Wolfram Sang <wsa@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: jz4780: remove redundant assignment to variable i
Date: Sat, 04 Jul 2020 06:32:17 +0000 [thread overview]
Message-ID: <20200704063217.GG1041@kunai> (raw)
In-Reply-To: <20200610125901.1134204-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Wed, Jun 10, 2020 at 01:59:01PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable i is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
What about 'ret'? Doesn't the same reasoning apply for it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@kernel.org>
To: Colin King <colin.king@canonical.com>
Cc: Paul Cercueil <paul@crapouillou.net>,
linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] i2c: jz4780: remove redundant assignment to variable i
Date: Sat, 4 Jul 2020 08:32:17 +0200 [thread overview]
Message-ID: <20200704063217.GG1041@kunai> (raw)
In-Reply-To: <20200610125901.1134204-1-colin.king@canonical.com>
[-- Attachment #1: Type: text/plain, Size: 461 bytes --]
On Wed, Jun 10, 2020 at 01:59:01PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable i is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
What about 'ret'? Doesn't the same reasoning apply for it?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-04 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 12:59 [PATCH] i2c: jz4780: remove redundant assignment to variable i Colin King
2020-06-10 12:59 ` Colin King
2020-07-04 6:32 ` Wolfram Sang [this message]
2020-07-04 6:32 ` Wolfram Sang
2020-07-06 23:52 ` Paul Cercueil
2020-07-06 23:52 ` Paul Cercueil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200704063217.GG1041@kunai \
--to=wsa@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.