All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] mt6625l: fix returnvar.cocci warnings
Date: Mon, 06 Jul 2020 14:41:12 +0800	[thread overview]
Message-ID: <20200706064112.GA31062@9cf1f7d5106f> (raw)
In-Reply-To: <202007061455.Nn14Bg8E%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]

From: kernel test robot <lkp@intel.com>

drivers/misc/mediatek/connectivity/common/common_detect/drv_init/bluetooth_drv_init.c:25:5-10: Unneeded variable: "i_ret". Return "- 1" on line 35


 Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: 5a3d075a983c ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/frank-w/BPI-R2-4.14 5.8-wifi
head:   4b8951570a4f2ef564d134f5aa8779fd067af1c9
commit: 5a3d075a983c166a2a4294c272b47698e24c97c6 [5/11] mt6625l: include wifi-folder

Please take the patch only if it's a positive warning. Thanks!

 bluetooth_drv_init.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/misc/mediatek/connectivity/common/common_detect/drv_init/bluetooth_drv_init.c
+++ b/drivers/misc/mediatek/connectivity/common/common_detect/drv_init/bluetooth_drv_init.c
@@ -22,7 +22,6 @@
 
 int do_bluetooth_drv_init(int chip_id)
 {
-	int i_ret = -1;
 #if 0
 #if defined(CONFIG_MTK_COMBO_BT) || defined(CONFIG_MTK_COMBO_BT_HCI)
 	WMT_DETECT_INFO_FUNC("start to do bluetooth driver init\n");
@@ -32,5 +31,5 @@ int do_bluetooth_drv_init(int chip_id)
 	WMT_DETECT_INFO_FUNC("CONFIG_MTK_COMBO_BT is not defined\n");
 #endif
 #endif
-	return i_ret;
+	return -1;
 }

  parent reply	other threads:[~2020-07-06  6:41 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-06  6:41 [frank-w-bpi-r2-4.14:5.8-wifi 5/11] drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c:88:34-35: WARNING: Use ARRAY_SIZE kernel test robot
2020-07-06  6:41 ` [PATCH] mt6625l: fix boolconv.cocci warnings kernel test robot
2020-07-06  6:41 ` [PATCH] mt6625l: fix eno.cocci warnings kernel test robot
2020-07-06  6:41 ` [PATCH] mt6625l: fix platform_no_drv_owner.cocci warnings kernel test robot
2020-07-06  6:41 ` kernel test robot [this message]
2020-07-06  6:41 ` [PATCH] mt6625l: fix returnvar.cocci warnings kernel test robot
2020-07-06  6:41 ` kernel test robot
2020-07-06  6:41 ` kernel test robot
2020-07-06  6:41 ` kernel test robot
2020-07-06  6:41 ` kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2020-07-12 12:19 [frank-w-bpi-r2-4.14:5.8-rc 5/38] drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/assoc.c:1549:44-45: WARNING: Use ARRAY_SIZE kernel test robot
2020-07-12 12:19 ` [PATCH] mt6625l: fix returnvar.cocci warnings kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706064112.GA31062@9cf1f7d5106f \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.