From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] mt6625l: fix returnvar.cocci warnings
Date: Mon, 06 Jul 2020 14:41:15 +0800 [thread overview]
Message-ID: <20200706064115.GA31323@9cf1f7d5106f> (raw)
In-Reply-To: <202007061455.Nn14Bg8E%lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2213 bytes --]
From: kernel test robot <lkp@intel.com>
drivers/misc/mediatek/btif/common/mtk_btif.c:958:5-10: Unneeded variable: "i_ret". Return "0" on line 967
drivers/misc/mediatek/btif/common/mtk_btif.c:2082:5-10: Unneeded variable: "i_ret". Return "0" on line 2085
drivers/misc/mediatek/btif/common/mtk_btif.c:2430:5-10: Unneeded variable: "i_ret". Return "0" on line 2444
Remove unneeded variable used to store return value.
Generated by: scripts/coccinelle/misc/returnvar.cocci
Fixes: 5a3d075a983c ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp@intel.com>
---
tree: https://github.com/frank-w/BPI-R2-4.14 5.8-wifi
head: 4b8951570a4f2ef564d134f5aa8779fd067af1c9
commit: 5a3d075a983c166a2a4294c272b47698e24c97c6 [5/11] mt6625l: include wifi-folder
Please take the patch only if it's a positive warning. Thanks!
mtk_btif.c | 11 +++--------
1 file changed, 3 insertions(+), 8 deletions(-)
--- a/drivers/misc/mediatek/btif/common/mtk_btif.c
+++ b/drivers/misc/mediatek/btif/common/mtk_btif.c
@@ -955,7 +955,6 @@ int _btif_irq_reg(P_MTK_BTIF_IRQ_STR p_i
int _btif_irq_free(P_MTK_BTIF_IRQ_STR p_irq, void *data)
{
- int i_ret = 0;
unsigned int eint_num = p_irq->irq_id;
if ((p_irq->is_irq_sup) && (p_irq->reg_flag)) {
@@ -964,7 +963,7 @@ int _btif_irq_free(P_MTK_BTIF_IRQ_STR p_
p_irq->reg_flag = false;
}
/*do nothing for this operation*/
- return i_ret;
+ return 0;
}
int _btif_irq_ctrl(P_MTK_BTIF_IRQ_STR p_irq, bool en)
@@ -2079,10 +2078,8 @@ static ENUM_BTIF_STATE _btif_state_get(p
static int _btif_state_release(p_mtk_btif p_btif)
{
- int i_ret = 0;
-
BTIF_MUTEX_UNLOCK(&(p_btif->state_mtx));
- return i_ret;
+ return 0;
}
static int _btif_state_deinit(p_mtk_btif p_btif)
@@ -2427,8 +2424,6 @@ btm_init_err:
static int _btif_tx_ctx_deinit(p_mtk_btif p_btif)
{
- int i_ret = 0;
-
if (p_btif->tx_ctx == BTIF_TX_SINGLE_CTX) {
if (p_btif->p_tx_wq) {
destroy_workqueue(p_btif->p_tx_wq);
@@ -2441,7 +2436,7 @@ static int _btif_tx_ctx_deinit(p_mtk_bti
p_btif->p_tx_fifo = NULL;
}
}
- return i_ret;
+ return 0;
}
static int _btif_rx_btm_init(p_mtk_btif p_btif)
next prev parent reply other threads:[~2020-07-06 6:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-06 6:41 [frank-w-bpi-r2-4.14:5.8-wifi 5/11] drivers/misc/mediatek/connectivity/common/common_detect/sdio_detect.c:88:34-35: WARNING: Use ARRAY_SIZE kernel test robot
2020-07-06 6:41 ` [PATCH] mt6625l: fix boolconv.cocci warnings kernel test robot
2020-07-06 6:41 ` [PATCH] mt6625l: fix eno.cocci warnings kernel test robot
2020-07-06 6:41 ` [PATCH] mt6625l: fix platform_no_drv_owner.cocci warnings kernel test robot
2020-07-06 6:41 ` [PATCH] mt6625l: fix returnvar.cocci warnings kernel test robot
2020-07-06 6:41 ` kernel test robot
2020-07-06 6:41 ` kernel test robot
2020-07-06 6:41 ` kernel test robot [this message]
2020-07-06 6:41 ` kernel test robot
2020-07-06 6:41 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2020-07-12 12:19 [frank-w-bpi-r2-4.14:5.8-rc 5/38] drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/assoc.c:1549:44-45: WARNING: Use ARRAY_SIZE kernel test robot
2020-07-12 12:19 ` [PATCH] mt6625l: fix returnvar.cocci warnings kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200706064115.GA31323@9cf1f7d5106f \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.