* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. [not found] <1593416584-24145-1-git-send-email-vasundhara-v.volam@broadcom.com> @ 2020-07-05 18:03 ` Stephen Hemminger 2020-07-06 6:34 ` Jiri Pirko 2020-07-08 9:40 ` Vasundhara Volam 0 siblings, 2 replies; 8+ messages in thread From: Stephen Hemminger @ 2020-07-05 18:03 UTC (permalink / raw) To: Vasundhara Volam; +Cc: netdev, dsahern, davem, jiri, kuba, michael.chan On Mon, 29 Jun 2020 13:13:04 +0530 Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: > Add support for reading board serial_number to devlink info > subcommand. Example: > > $ devlink dev info pci/0000:af:00.0 -jp > { > "info": { > "pci/0000:af:00.0": { > "driver": "bnxt_en", > "serial_number": "00-10-18-FF-FE-AD-1A-00", > "board.serial_number": "433551F+172300000", > "versions": { > "fixed": { > "board.id": "7339763 Rev 0.", > "asic.id": "16D7", > "asic.rev": "1" > }, > "running": { > "fw": "216.1.216.0", > "fw.psid": "0.0.0", > "fw.mgmt": "216.1.192.0", > "fw.mgmt.api": "1.10.1", > "fw.ncsi": "0.0.0.0", > "fw.roce": "216.1.16.0" > } > } > } > } > } Although this is valid JSON, many JSON style guides do not allow for periods in property names. This is done so libraries can use dot notation to reference objects. Also the encoding of PCI is problematic ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. 2020-07-05 18:03 ` [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand Stephen Hemminger @ 2020-07-06 6:34 ` Jiri Pirko 2020-07-06 16:33 ` Stephen Hemminger 2020-07-08 9:40 ` Vasundhara Volam 1 sibling, 1 reply; 8+ messages in thread From: Jiri Pirko @ 2020-07-06 6:34 UTC (permalink / raw) To: Stephen Hemminger Cc: Vasundhara Volam, netdev, dsahern, davem, jiri, kuba, michael.chan Sun, Jul 05, 2020 at 08:03:01PM CEST, stephen@networkplumber.org wrote: >On Mon, 29 Jun 2020 13:13:04 +0530 >Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: > >> Add support for reading board serial_number to devlink info >> subcommand. Example: >> >> $ devlink dev info pci/0000:af:00.0 -jp >> { >> "info": { >> "pci/0000:af:00.0": { >> "driver": "bnxt_en", >> "serial_number": "00-10-18-FF-FE-AD-1A-00", >> "board.serial_number": "433551F+172300000", >> "versions": { >> "fixed": { >> "board.id": "7339763 Rev 0.", >> "asic.id": "16D7", >> "asic.rev": "1" >> }, >> "running": { >> "fw": "216.1.216.0", >> "fw.psid": "0.0.0", >> "fw.mgmt": "216.1.192.0", >> "fw.mgmt.api": "1.10.1", >> "fw.ncsi": "0.0.0.0", >> "fw.roce": "216.1.16.0" >> } >> } >> } >> } >> } > >Although this is valid JSON, many JSON style guides do not allow >for periods in property names. This is done so libraries can use >dot notation to reference objects. > >Also the encoding of PCI is problematic Well, besides board.serial_number, this is what we have right now... > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. 2020-07-06 6:34 ` Jiri Pirko @ 2020-07-06 16:33 ` Stephen Hemminger 0 siblings, 0 replies; 8+ messages in thread From: Stephen Hemminger @ 2020-07-06 16:33 UTC (permalink / raw) To: Jiri Pirko Cc: Vasundhara Volam, netdev, dsahern, davem, jiri, kuba, michael.chan On Mon, 6 Jul 2020 08:34:50 +0200 Jiri Pirko <jiri@resnulli.us> wrote: > Sun, Jul 05, 2020 at 08:03:01PM CEST, stephen@networkplumber.org wrote: > >On Mon, 29 Jun 2020 13:13:04 +0530 > >Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: > > > >> Add support for reading board serial_number to devlink info > >> subcommand. Example: > >> > >> $ devlink dev info pci/0000:af:00.0 -jp > >> { > >> "info": { > >> "pci/0000:af:00.0": { > >> "driver": "bnxt_en", > >> "serial_number": "00-10-18-FF-FE-AD-1A-00", > >> "board.serial_number": "433551F+172300000", > >> "versions": { > >> "fixed": { > >> "board.id": "7339763 Rev 0.", > >> "asic.id": "16D7", > >> "asic.rev": "1" > >> }, > >> "running": { > >> "fw": "216.1.216.0", > >> "fw.psid": "0.0.0", > >> "fw.mgmt": "216.1.192.0", > >> "fw.mgmt.api": "1.10.1", > >> "fw.ncsi": "0.0.0.0", > >> "fw.roce": "216.1.16.0" > >> } > >> } > >> } > >> } > >> } > > > >Although this is valid JSON, many JSON style guides do not allow > >for periods in property names. This is done so libraries can use > >dot notation to reference objects. > > > >Also the encoding of PCI is problematic > > Well, besides board.serial_number, this is what we have right now... Could you investigate JSON usage and decide what style to use. The rest of iproute2 doesn't do it. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. 2020-07-05 18:03 ` [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand Stephen Hemminger 2020-07-06 6:34 ` Jiri Pirko @ 2020-07-08 9:40 ` Vasundhara Volam 2020-07-08 11:35 ` Jiri Pirko 1 sibling, 1 reply; 8+ messages in thread From: Vasundhara Volam @ 2020-07-08 9:40 UTC (permalink / raw) To: Stephen Hemminger Cc: Netdev, dsahern, David Miller, Jiri Pirko, Jakub Kicinski, Michael Chan On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger <stephen@networkplumber.org> wrote: > > On Mon, 29 Jun 2020 13:13:04 +0530 > Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: > > > Add support for reading board serial_number to devlink info > > subcommand. Example: > > > > $ devlink dev info pci/0000:af:00.0 -jp > > { > > "info": { > > "pci/0000:af:00.0": { > > "driver": "bnxt_en", > > "serial_number": "00-10-18-FF-FE-AD-1A-00", > > "board.serial_number": "433551F+172300000", > > "versions": { > > "fixed": { > > "board.id": "7339763 Rev 0.", > > "asic.id": "16D7", > > "asic.rev": "1" > > }, > > "running": { > > "fw": "216.1.216.0", > > "fw.psid": "0.0.0", > > "fw.mgmt": "216.1.192.0", > > "fw.mgmt.api": "1.10.1", > > "fw.ncsi": "0.0.0.0", > > "fw.roce": "216.1.16.0" > > } > > } > > } > > } > > } > > Although this is valid JSON, many JSON style guides do not allow > for periods in property names. This is done so libraries can use > dot notation to reference objects. Okay, I will modify the name to board_serial_number and resend the patch. Thanks. > > Also the encoding of PCI is problematic > > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. 2020-07-08 9:40 ` Vasundhara Volam @ 2020-07-08 11:35 ` Jiri Pirko 2020-07-08 15:04 ` Vasundhara Volam 0 siblings, 1 reply; 8+ messages in thread From: Jiri Pirko @ 2020-07-08 11:35 UTC (permalink / raw) To: Vasundhara Volam Cc: Stephen Hemminger, Netdev, dsahern, David Miller, Jiri Pirko, Jakub Kicinski, Michael Chan Wed, Jul 08, 2020 at 11:40:12AM CEST, vasundhara-v.volam@broadcom.com wrote: >On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger ><stephen@networkplumber.org> wrote: >> >> On Mon, 29 Jun 2020 13:13:04 +0530 >> Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: >> >> > Add support for reading board serial_number to devlink info >> > subcommand. Example: >> > >> > $ devlink dev info pci/0000:af:00.0 -jp >> > { >> > "info": { >> > "pci/0000:af:00.0": { >> > "driver": "bnxt_en", >> > "serial_number": "00-10-18-FF-FE-AD-1A-00", >> > "board.serial_number": "433551F+172300000", >> > "versions": { >> > "fixed": { >> > "board.id": "7339763 Rev 0.", >> > "asic.id": "16D7", >> > "asic.rev": "1" >> > }, >> > "running": { >> > "fw": "216.1.216.0", >> > "fw.psid": "0.0.0", >> > "fw.mgmt": "216.1.192.0", >> > "fw.mgmt.api": "1.10.1", >> > "fw.ncsi": "0.0.0.0", >> > "fw.roce": "216.1.16.0" >> > } >> > } >> > } >> > } >> > } >> >> Although this is valid JSON, many JSON style guides do not allow >> for periods in property names. This is done so libraries can use >> dot notation to reference objects. >Okay, I will modify the name to board_serial_number and resend the >patch. Thanks. Does not make sense. We have plenty of other items with ".". Having one without it does not resolve anything, only brings inconsistency. Please have ".". > >> >> Also the encoding of PCI is problematic >> >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. 2020-07-08 11:35 ` Jiri Pirko @ 2020-07-08 15:04 ` Vasundhara Volam 2020-07-08 15:26 ` Stephen Hemminger 0 siblings, 1 reply; 8+ messages in thread From: Vasundhara Volam @ 2020-07-08 15:04 UTC (permalink / raw) To: Jiri Pirko Cc: Stephen Hemminger, Netdev, dsahern, David Miller, Jiri Pirko, Jakub Kicinski, Michael Chan On Wed, Jul 8, 2020 at 5:05 PM Jiri Pirko <jiri@resnulli.us> wrote: > > Wed, Jul 08, 2020 at 11:40:12AM CEST, vasundhara-v.volam@broadcom.com wrote: > >On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger > ><stephen@networkplumber.org> wrote: > >> > >> On Mon, 29 Jun 2020 13:13:04 +0530 > >> Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: > >> > >> > Add support for reading board serial_number to devlink info > >> > subcommand. Example: > >> > > >> > $ devlink dev info pci/0000:af:00.0 -jp > >> > { > >> > "info": { > >> > "pci/0000:af:00.0": { > >> > "driver": "bnxt_en", > >> > "serial_number": "00-10-18-FF-FE-AD-1A-00", > >> > "board.serial_number": "433551F+172300000", > >> > "versions": { > >> > "fixed": { > >> > "board.id": "7339763 Rev 0.", > >> > "asic.id": "16D7", > >> > "asic.rev": "1" > >> > }, > >> > "running": { > >> > "fw": "216.1.216.0", > >> > "fw.psid": "0.0.0", > >> > "fw.mgmt": "216.1.192.0", > >> > "fw.mgmt.api": "1.10.1", > >> > "fw.ncsi": "0.0.0.0", > >> > "fw.roce": "216.1.16.0" > >> > } > >> > } > >> > } > >> > } > >> > } > >> > >> Although this is valid JSON, many JSON style guides do not allow > >> for periods in property names. This is done so libraries can use > >> dot notation to reference objects. > >Okay, I will modify the name to board_serial_number and resend the > >patch. Thanks. > > Does not make sense. We have plenty of other items with ".". Having one > without it does not resolve anything, only brings inconsistency. Please > have ".". Okay so keeping the patch as-is. > > > > > >> > >> Also the encoding of PCI is problematic > >> > >> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. 2020-07-08 15:04 ` Vasundhara Volam @ 2020-07-08 15:26 ` Stephen Hemminger 2020-07-08 16:00 ` David Ahern 0 siblings, 1 reply; 8+ messages in thread From: Stephen Hemminger @ 2020-07-08 15:26 UTC (permalink / raw) To: Vasundhara Volam Cc: Jiri Pirko, Netdev, dsahern, David Miller, Jiri Pirko, Jakub Kicinski, Michael Chan On Wed, 8 Jul 2020 20:34:50 +0530 Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: > On Wed, Jul 8, 2020 at 5:05 PM Jiri Pirko <jiri@resnulli.us> wrote: > > > > Wed, Jul 08, 2020 at 11:40:12AM CEST, vasundhara-v.volam@broadcom.com wrote: > > >On Sun, Jul 5, 2020 at 11:33 PM Stephen Hemminger > > ><stephen@networkplumber.org> wrote: > > >> > > >> On Mon, 29 Jun 2020 13:13:04 +0530 > > >> Vasundhara Volam <vasundhara-v.volam@broadcom.com> wrote: > > >> > > >> > Add support for reading board serial_number to devlink info > > >> > subcommand. Example: > > >> > > > >> > $ devlink dev info pci/0000:af:00.0 -jp > > >> > { > > >> > "info": { > > >> > "pci/0000:af:00.0": { > > >> > "driver": "bnxt_en", > > >> > "serial_number": "00-10-18-FF-FE-AD-1A-00", > > >> > "board.serial_number": "433551F+172300000", > > >> > "versions": { > > >> > "fixed": { > > >> > "board.id": "7339763 Rev 0.", > > >> > "asic.id": "16D7", > > >> > "asic.rev": "1" > > >> > }, > > >> > "running": { > > >> > "fw": "216.1.216.0", > > >> > "fw.psid": "0.0.0", > > >> > "fw.mgmt": "216.1.192.0", > > >> > "fw.mgmt.api": "1.10.1", > > >> > "fw.ncsi": "0.0.0.0", > > >> > "fw.roce": "216.1.16.0" > > >> > } > > >> > } > > >> > } > > >> > } > > >> > } > > >> > > >> Although this is valid JSON, many JSON style guides do not allow > > >> for periods in property names. This is done so libraries can use > > >> dot notation to reference objects. > > >Okay, I will modify the name to board_serial_number and resend the > > >patch. Thanks. > > > > Does not make sense. We have plenty of other items with ".". Having one > > without it does not resolve anything, only brings inconsistency. Please > > have ".". > Okay so keeping the patch as-is. For now yes the patch is ok as-is, but we should have a discussion about the best JSON style. The current free form style is getting out of hand. Resolving may mean doing more widespread changes across iproute ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand. 2020-07-08 15:26 ` Stephen Hemminger @ 2020-07-08 16:00 ` David Ahern 0 siblings, 0 replies; 8+ messages in thread From: David Ahern @ 2020-07-08 16:00 UTC (permalink / raw) To: Stephen Hemminger, Vasundhara Volam Cc: Jiri Pirko, Netdev, David Miller, Jiri Pirko, Jakub Kicinski, Michael Chan On 7/8/20 9:26 AM, Stephen Hemminger wrote: > Resolving may mean doing more widespread changes across iproute some of the devlink messages come from the driver, so it is not just iproute2. ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-07-08 16:00 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1593416584-24145-1-git-send-email-vasundhara-v.volam@broadcom.com>
2020-07-05 18:03 ` [PATCH v2 iproute2-next] devlink: Add board.serial_number to info subcommand Stephen Hemminger
2020-07-06 6:34 ` Jiri Pirko
2020-07-06 16:33 ` Stephen Hemminger
2020-07-08 9:40 ` Vasundhara Volam
2020-07-08 11:35 ` Jiri Pirko
2020-07-08 15:04 ` Vasundhara Volam
2020-07-08 15:26 ` Stephen Hemminger
2020-07-08 16:00 ` David Ahern
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.