All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Will Deacon <will@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Robin Murphy <robin.murphy@arm.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 0/3] arm64: perf: add support for Cortex-A55/A75/A76
Date: Mon, 6 Jul 2020 16:04:11 +0800	[thread overview]
Message-ID: <20200706160411.19d91904@xhacker.debian> (raw)
In-Reply-To: <20200703123346.GB18953@willie-the-truck>

Hi Will,

On Fri, 3 Jul 2020 13:33:47 +0100 Will Deacon wrote:

> 
> 
> On Fri, Jun 19, 2020 at 06:44:37PM +0800, Jisheng Zhang wrote:
> > The Cortex-A55/A75/A76 use some implementation defined perf events.
> > Add the support.
> >
> > Jisheng Zhang (3):
> >   arm64: perf: add support for Cortex-A55
> >   arm64: perf: add support for Cortex-A75
> >   arm64: perf: add support for Cortex-A76
> >
> >  arch/arm64/kernel/perf_event.c | 49 +++++++++++++++++++++++++++++++---
> >  1 file changed, 45 insertions(+), 4 deletions(-)  
> 
> Do we really need this? I'd prefer for this stuff to live in userspace

IMHO, this stuff is to add a relationship between linux standard
HW events and ARM PMU events, take CA55 for example:

w/o the stuff, perf -e PREFETCH_LINEFILL

w/ the stuff, perf -e L1-dcache-prefetch-misses

But indeed, we also need to add json descriptions in perf tool, I'll submit
patches.

Thanks

> now that the perf tool has supported JSON event descriptions for a while,
> and the in-kernel driver advertises the architected events advertised
> by PMCEID*.
> 
> Will


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Jisheng Zhang <Jisheng.Zhang@synaptics.com>
To: Will Deacon <will@kernel.org>
Cc: Robin Murphy <robin.murphy@arm.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] arm64: perf: add support for Cortex-A55/A75/A76
Date: Mon, 6 Jul 2020 16:04:11 +0800	[thread overview]
Message-ID: <20200706160411.19d91904@xhacker.debian> (raw)
In-Reply-To: <20200703123346.GB18953@willie-the-truck>

Hi Will,

On Fri, 3 Jul 2020 13:33:47 +0100 Will Deacon wrote:

> 
> 
> On Fri, Jun 19, 2020 at 06:44:37PM +0800, Jisheng Zhang wrote:
> > The Cortex-A55/A75/A76 use some implementation defined perf events.
> > Add the support.
> >
> > Jisheng Zhang (3):
> >   arm64: perf: add support for Cortex-A55
> >   arm64: perf: add support for Cortex-A75
> >   arm64: perf: add support for Cortex-A76
> >
> >  arch/arm64/kernel/perf_event.c | 49 +++++++++++++++++++++++++++++++---
> >  1 file changed, 45 insertions(+), 4 deletions(-)  
> 
> Do we really need this? I'd prefer for this stuff to live in userspace

IMHO, this stuff is to add a relationship between linux standard
HW events and ARM PMU events, take CA55 for example:

w/o the stuff, perf -e PREFETCH_LINEFILL

w/ the stuff, perf -e L1-dcache-prefetch-misses

But indeed, we also need to add json descriptions in perf tool, I'll submit
patches.

Thanks

> now that the perf tool has supported JSON event descriptions for a while,
> and the in-kernel driver advertises the architected events advertised
> by PMCEID*.
> 
> Will


  reply	other threads:[~2020-07-06  8:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-19 10:44 [PATCH 0/3] arm64: perf: add support for Cortex-A55/A75/A76 Jisheng Zhang
2020-06-19 10:44 ` Jisheng Zhang
2020-06-19 10:45 ` [PATCH 1/3] arm64: perf: add support for Cortex-A55 Jisheng Zhang
2020-06-19 10:45   ` Jisheng Zhang
2020-06-19 10:45 ` [PATCH 2/3] arm64: perf: add support for Cortex-A75 Jisheng Zhang
2020-06-19 10:45   ` Jisheng Zhang
2020-06-19 10:45 ` [PATCH 3/3] arm64: perf: add support for Cortex-A76 Jisheng Zhang
2020-06-19 10:45   ` Jisheng Zhang
2020-07-03 12:33 ` [PATCH 0/3] arm64: perf: add support for Cortex-A55/A75/A76 Will Deacon
2020-07-03 12:33   ` Will Deacon
2020-07-06  8:04   ` Jisheng Zhang [this message]
2020-07-06  8:04     ` Jisheng Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200706160411.19d91904@xhacker.debian \
    --to=jisheng.zhang@synaptics.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.