From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 15/23] drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.
Date: Tue, 07 Jul 2020 17:32:35 +0300 [thread overview]
Message-ID: <20200707143235.GF2549@kadam> (raw)
In-Reply-To: <20200703122221.591656-16-maarten.lankhorst@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 3907 bytes --]
Hi Maarten,
url: https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915-Use-ww-locking-in-execbuf-submission/20200703-202504
base: 7faedc4873dd257f4ed064ab4e0a28407690ea73
config: i386-randconfig-m021-20200701 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c:367 i915_gem_object_copy_blt() warn: passing a valid pointer to 'PTR_ERR'
Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 122)
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c:139 move_obj_to_gpu() warn: maybe use && instead of &
drivers/gpu/drm/i915/gem/i915_gem_context.h:205 i915_gem_context_get_engine() warn: inconsistent indenting
drivers/gpu/drm/i915/gem/i915_gem_context.h:207 i915_gem_context_get_engine() warn: inconsistent indenting
# https://github.com/0day-ci/linux/commit/db8aba4953b274f1a757ff6f92b15697fd5af58a
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout db8aba4953b274f1a757ff6f92b15697fd5af58a
vim +/PTR_ERR +367 drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
05f219d709ec57 Matthew Auld 2019-08-10 351 int i915_gem_object_copy_blt(struct drm_i915_gem_object *src,
05f219d709ec57 Matthew Auld 2019-08-10 352 struct drm_i915_gem_object *dst,
05f219d709ec57 Matthew Auld 2019-08-10 353 struct intel_context *ce)
05f219d709ec57 Matthew Auld 2019-08-10 354 {
05f219d709ec57 Matthew Auld 2019-08-10 355 struct i915_address_space *vm = ce->vm;
05f219d709ec57 Matthew Auld 2019-08-10 356 struct i915_vma *vma[2], *batch;
db8aba4953b274 Maarten Lankhorst 2020-07-03 357 struct i915_gem_ww_ctx ww;
05f219d709ec57 Matthew Auld 2019-08-10 358 struct i915_request *rq;
05f219d709ec57 Matthew Auld 2019-08-10 359 int err, i;
05f219d709ec57 Matthew Auld 2019-08-10 360
05f219d709ec57 Matthew Auld 2019-08-10 361 vma[0] = i915_vma_instance(src, vm, NULL);
05f219d709ec57 Matthew Auld 2019-08-10 362 if (IS_ERR(vma[0]))
05f219d709ec57 Matthew Auld 2019-08-10 363 return PTR_ERR(vma[0]);
05f219d709ec57 Matthew Auld 2019-08-10 364
05f219d709ec57 Matthew Auld 2019-08-10 365 vma[1] = i915_vma_instance(dst, vm, NULL);
05f219d709ec57 Matthew Auld 2019-08-10 366 if (IS_ERR(vma[1]))
db8aba4953b274 Maarten Lankhorst 2020-07-03 @367 return PTR_ERR(vma);
^^^
Should be "vma[1]".
05f219d709ec57 Matthew Auld 2019-08-10 368
db8aba4953b274 Maarten Lankhorst 2020-07-03 369 i915_gem_ww_ctx_init(&ww, true);
db8aba4953b274 Maarten Lankhorst 2020-07-03 370 intel_engine_pm_get(ce->engine);
db8aba4953b274 Maarten Lankhorst 2020-07-03 371 retry:
db8aba4953b274 Maarten Lankhorst 2020-07-03 372 err = i915_gem_object_lock(src, &ww);
db8aba4953b274 Maarten Lankhorst 2020-07-03 373 if (!err)
db8aba4953b274 Maarten Lankhorst 2020-07-03 374 err = i915_gem_object_lock(dst, &ww);
db8aba4953b274 Maarten Lankhorst 2020-07-03 375 if (!err)
db8aba4953b274 Maarten Lankhorst 2020-07-03 376 err = intel_context_pin_ww(ce, &ww);
db8aba4953b274 Maarten Lankhorst 2020-07-03 377 if (err)
db8aba4953b274 Maarten Lankhorst 2020-07-03 378 goto out;
db8aba4953b274 Maarten Lankhorst 2020-07-03 379
db8aba4953b274 Maarten Lankhorst 2020-07-03 380 err = i915_vma_pin_ww(vma[0], &ww, 0, 0, PIN_USER);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41957 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kbuild-all@lists.01.org
Subject: Re: [Intel-gfx] [PATCH 15/23] drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2.
Date: Tue, 07 Jul 2020 17:32:35 +0300 [thread overview]
Message-ID: <20200707143235.GF2549@kadam> (raw)
In-Reply-To: <20200703122221.591656-16-maarten.lankhorst@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 3907 bytes --]
Hi Maarten,
url: https://github.com/0day-ci/linux/commits/Maarten-Lankhorst/drm-i915-Use-ww-locking-in-execbuf-submission/20200703-202504
base: 7faedc4873dd257f4ed064ab4e0a28407690ea73
config: i386-randconfig-m021-20200701 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
New smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c:367 i915_gem_object_copy_blt() warn: passing a valid pointer to 'PTR_ERR'
Old smatch warnings:
drivers/gpu/drm/i915/gem/i915_gem_object.h:130 __i915_gem_object_lock() error: we previously assumed 'ww' could be null (see line 122)
drivers/gpu/drm/i915/gem/i915_gem_object_blt.c:139 move_obj_to_gpu() warn: maybe use && instead of &
drivers/gpu/drm/i915/gem/i915_gem_context.h:205 i915_gem_context_get_engine() warn: inconsistent indenting
drivers/gpu/drm/i915/gem/i915_gem_context.h:207 i915_gem_context_get_engine() warn: inconsistent indenting
# https://github.com/0day-ci/linux/commit/db8aba4953b274f1a757ff6f92b15697fd5af58a
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout db8aba4953b274f1a757ff6f92b15697fd5af58a
vim +/PTR_ERR +367 drivers/gpu/drm/i915/gem/i915_gem_object_blt.c
05f219d709ec57 Matthew Auld 2019-08-10 351 int i915_gem_object_copy_blt(struct drm_i915_gem_object *src,
05f219d709ec57 Matthew Auld 2019-08-10 352 struct drm_i915_gem_object *dst,
05f219d709ec57 Matthew Auld 2019-08-10 353 struct intel_context *ce)
05f219d709ec57 Matthew Auld 2019-08-10 354 {
05f219d709ec57 Matthew Auld 2019-08-10 355 struct i915_address_space *vm = ce->vm;
05f219d709ec57 Matthew Auld 2019-08-10 356 struct i915_vma *vma[2], *batch;
db8aba4953b274 Maarten Lankhorst 2020-07-03 357 struct i915_gem_ww_ctx ww;
05f219d709ec57 Matthew Auld 2019-08-10 358 struct i915_request *rq;
05f219d709ec57 Matthew Auld 2019-08-10 359 int err, i;
05f219d709ec57 Matthew Auld 2019-08-10 360
05f219d709ec57 Matthew Auld 2019-08-10 361 vma[0] = i915_vma_instance(src, vm, NULL);
05f219d709ec57 Matthew Auld 2019-08-10 362 if (IS_ERR(vma[0]))
05f219d709ec57 Matthew Auld 2019-08-10 363 return PTR_ERR(vma[0]);
05f219d709ec57 Matthew Auld 2019-08-10 364
05f219d709ec57 Matthew Auld 2019-08-10 365 vma[1] = i915_vma_instance(dst, vm, NULL);
05f219d709ec57 Matthew Auld 2019-08-10 366 if (IS_ERR(vma[1]))
db8aba4953b274 Maarten Lankhorst 2020-07-03 @367 return PTR_ERR(vma);
^^^
Should be "vma[1]".
05f219d709ec57 Matthew Auld 2019-08-10 368
db8aba4953b274 Maarten Lankhorst 2020-07-03 369 i915_gem_ww_ctx_init(&ww, true);
db8aba4953b274 Maarten Lankhorst 2020-07-03 370 intel_engine_pm_get(ce->engine);
db8aba4953b274 Maarten Lankhorst 2020-07-03 371 retry:
db8aba4953b274 Maarten Lankhorst 2020-07-03 372 err = i915_gem_object_lock(src, &ww);
db8aba4953b274 Maarten Lankhorst 2020-07-03 373 if (!err)
db8aba4953b274 Maarten Lankhorst 2020-07-03 374 err = i915_gem_object_lock(dst, &ww);
db8aba4953b274 Maarten Lankhorst 2020-07-03 375 if (!err)
db8aba4953b274 Maarten Lankhorst 2020-07-03 376 err = intel_context_pin_ww(ce, &ww);
db8aba4953b274 Maarten Lankhorst 2020-07-03 377 if (err)
db8aba4953b274 Maarten Lankhorst 2020-07-03 378 goto out;
db8aba4953b274 Maarten Lankhorst 2020-07-03 379
db8aba4953b274 Maarten Lankhorst 2020-07-03 380 err = i915_vma_pin_ww(vma[0], &ww, 0, 0, PIN_USER);
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 41957 bytes --]
next prev parent reply other threads:[~2020-07-07 14:32 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 12:21 [Intel-gfx] [PATCH 00/23] drm/i915: Use ww locking in execbuf submission Maarten Lankhorst
2020-07-03 12:21 ` [Intel-gfx] [PATCH 01/23] Revert "drm/i915/gem: Async GPU relocations only" Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 02/23] drm/i915: Revert relocation chaining commits Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 03/23] Revert "drm/i915/gem: Drop relocation slowpath" Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 04/23] drm/i915: Add an implementation for i915_gem_ww_ctx locking, v2 Maarten Lankhorst
2020-07-03 13:45 ` Tvrtko Ursulin
2020-07-03 12:22 ` [Intel-gfx] [PATCH 05/23] drm/i915: Remove locking from i915_gem_object_prepare_read/write Maarten Lankhorst
2020-07-03 13:43 ` Tvrtko Ursulin
2020-07-06 12:53 ` Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 06/23] drm/i915: Parse command buffer earlier in eb_relocate(slow) Maarten Lankhorst
2020-07-03 13:49 ` Tvrtko Ursulin
2020-07-06 12:53 ` Maarten Lankhorst
2020-07-06 15:47 ` Tvrtko Ursulin
2020-07-03 12:22 ` [Intel-gfx] [PATCH 07/23] Revert "drm/i915/gem: Split eb_vma into its own allocation" Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 08/23] drm/i915: Use per object locking in execbuf, v12 Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 09/23] drm/i915: Use ww locking in intel_renderstate Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 10/23] drm/i915: Add ww context handling to context_barrier_task Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 11/23] drm/i915: Nuke arguments to eb_pin_engine Maarten Lankhorst
2020-07-03 13:38 ` Tvrtko Ursulin
2020-07-03 12:22 ` [Intel-gfx] [PATCH 12/23] drm/i915: Pin engine before pinning all objects, v4 Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 13/23] drm/i915: Rework intel_context pinning to do everything outside of pin_mutex Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 14/23] drm/i915: Make sure execbuffer always passes ww state to i915_vma_pin Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 15/23] drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2 Maarten Lankhorst
2020-07-07 14:32 ` Dan Carpenter [this message]
2020-07-07 14:32 ` Dan Carpenter
2020-07-03 12:22 ` [Intel-gfx] [PATCH 16/23] drm/i915: Kill last user of intel_context_create_request outside of selftests Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 17/23] drm/i915: Convert i915_perf to ww locking as well Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 18/23] drm/i915: Dirty hack to fix selftests locking inversion Maarten Lankhorst
2020-07-03 13:48 ` Tvrtko Ursulin
2020-07-07 10:19 ` Maarten Lankhorst
2020-07-07 10:56 ` Tvrtko Ursulin
2020-07-07 11:00 ` Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 19/23] drm/i915/selftests: Fix locking inversion in lrc selftest Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 20/23] drm/i915: Use ww pinning for intel_context_create_request() Maarten Lankhorst
2020-07-07 14:35 ` Dan Carpenter
2020-07-07 14:35 ` Dan Carpenter
2020-07-03 12:22 ` [Intel-gfx] [PATCH 21/23] drm/i915: Move i915_vma_lock in the selftests to avoid lock inversion, v2 Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 22/23] drm/i915: Add ww locking to vm_fault_gtt Maarten Lankhorst
2020-07-03 12:22 ` [Intel-gfx] [PATCH 23/23] drm/i915: Add ww locking to pin_to_display_plane Maarten Lankhorst
2020-07-03 14:12 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use ww locking in execbuf submission Patchwork
2020-07-03 14:13 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork
2020-07-03 14:36 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2020-07-05 12:45 [Intel-gfx] [PATCH 15/23] drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2 kernel test robot
2020-07-14 11:44 [Intel-gfx] [PATCH 01/23] Revert "drm/i915/gem: Async GPU relocations only" Maarten Lankhorst
2020-07-14 11:45 ` [Intel-gfx] [PATCH 15/23] drm/i915: Convert i915_gem_object/client_blt.c to use ww locking as well, v2 Maarten Lankhorst
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707143235.GF2549@kadam \
--to=dan.carpenter@oracle.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.