From: Wei Wu <lazyparser@gmail.com>
To: qemu-devel@nongnu.org
Cc: Alistair.Francis@wdc.com, palmer@dabbelt.com,
Wei Wu <lazyparser@gmail.com>
Subject: [PATCH] disas/riscv: Fix incorrect disassembly for `imm20` operand.
Date: Tue, 7 Jul 2020 23:43:36 +0800 [thread overview]
Message-ID: <20200707154336.4963-1-lazyparser@gmail.com> (raw)
`imm20` operand type is used in LUI/AUIPC and other instructions.
The value should not be left shifted 12bits for disassembly output.
Signed-off-by: Wei Wu <lazyparser@gmail.com>
---
disas/riscv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/disas/riscv.c b/disas/riscv.c
index 278d9be924..a2b6472bd8 100644
--- a/disas/riscv.c
+++ b/disas/riscv.c
@@ -2083,7 +2083,7 @@ static int32_t operand_imm12(rv_inst inst)
static int32_t operand_imm20(rv_inst inst)
{
- return (((int64_t)inst << 32) >> 44) << 12;
+ return ((int64_t)inst << 32) >> 44;
}
static int32_t operand_jimm20(rv_inst inst)
--
2.17.1
next reply other threads:[~2020-07-07 15:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 15:43 Wei Wu [this message]
2020-07-10 18:30 ` [PATCH] disas/riscv: Fix incorrect disassembly for `imm20` operand Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2020-07-07 10:09 lazyparser
2020-07-07 15:15 ` Alistair Francis
2020-07-07 15:47 ` Wei Wu (吴伟)
2020-07-07 8:20 Wei Wu (吴伟)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200707154336.4963-1-lazyparser@gmail.com \
--to=lazyparser@gmail.com \
--cc=Alistair.Francis@wdc.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.