Re: [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings​ - part2

[Lee Jones <lee.jones@linaro.org>]

On Tue, 07 Jul 2020, Pierre-Louis Bossart wrote:

> Both Lee Jones and I submitted separate series, this is the second
> part of the merged result, for which no feedback was provided.
> 
> I picked Lee's patches for rt5659 and ak4458 and added the pxa and
> ux500 that I didn't fix. The rest is largely identical between our
> respective series, with the exception of the sunxi which I documented
> and Lee removed. I don't have any specific preference and will go with
> the flow on this.
> 
> Lee Jones (4):
>   ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header
>   ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and
>     'reg_val_TSTDR'
>   ASoC: codecs: rt5659: Remove many unused const variables
>   ASoC: codecs: ak4458: Remove set but never checked variable 'ret'
> 
> Pierre-Louis Bossart (6):
>   ASoC: qcom: q6asm: fix kernel-doc
>   ASoC: sunxi: sun4i-i2s: fix kernel-doc
>   ASoC: sunxi: sun4i-spdif: fix kernel-doc
>   ASoC: codecs: rt5631: fix kernel-doc
>   ASoC: codecs: tlv320aic26: fix kernel-doc warning

Would you mind elaborating on "fix kernel-doc".  Some tooling relies
on the fact that subject lines are, at least for the most part, pretty
unique, and if we have to fix another kerneldoc issue in the future
with the same thirst for simpleness, I'm afraid there might be
clashes.

Take a look at my patches, if you require inspiration.

>   ASoC: sti: uniperif: fix 'defined by not used' warning
> 
>  sound/soc/codecs/ak4458.c       |  6 +++---
>  sound/soc/codecs/rt5631.c       |  8 +++++--
>  sound/soc/codecs/rt5659.c       | 37 ---------------------------------
>  sound/soc/codecs/tlv320aic26.c  |  2 +-
>  sound/soc/pxa/pxa-ssp.c         |  2 +-
>  sound/soc/qcom/qdsp6/q6asm.c    |  2 +-
>  sound/soc/sti/uniperif.h        |  2 +-
>  sound/soc/sunxi/sun4i-i2s.c     | 10 ++++++++-
>  sound/soc/sunxi/sun4i-spdif.c   |  2 +-
>  sound/soc/ux500/ux500_msp_i2s.c |  8 +++----
>  10 files changed, 27 insertions(+), 52 deletions(-)
> 

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog