All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Subject: Re: [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings​ - part2
Date: Wed, 8 Jul 2020 14:50:16 +0100	[thread overview]
Message-ID: <20200708135016.GX3500@dell> (raw)
In-Reply-To: <20200708133833.GQ4655@sirena.org.uk>

On Wed, 08 Jul 2020, Mark Brown wrote:

> On Wed, Jul 08, 2020 at 02:06:06PM +0100, Lee Jones wrote:
> > On Wed, 08 Jul 2020, Pierre-Louis Bossart wrote:
> 
> > > > >    ASoC: sunxi: sun4i-i2s: fix kernel-doc
> > > > >    ASoC: sunxi: sun4i-spdif: fix kernel-doc
> > > > >    ASoC: codecs: rt5631: fix kernel-doc
> 
> > > which tools? seems pretty bad to me to rely on string uniqueness, isn't
> > > uniqueness defined by SHA1s?
> 
> > SHAs don't work across rebases/cherry-picks.
> 
> > Sometimes subject lines are the most reliable way to 'match'.
> 
> Note that all these patches have unique subjects due to the prefixes
> saying what they're modifying, this is a common pattern for these sorts
> of repetitive serieses doing broad cleanups.

Yes, they're unique within *this* set.  The fun starts when you
conduct another pass a few months/years down the line and have the
same lack of imagination. :)

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

  reply	other threads:[~2020-07-08 13:51 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-07 19:16 [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings​ - part2 Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 01/10] ASoC: qcom: q6asm: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 02/10] ASoC: sunxi: sun4i-i2s: " Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  8:11   ` Maxime Ripard
2020-07-08  8:11     ` Maxime Ripard
2020-07-08  8:11     ` Maxime Ripard
2020-07-07 19:16 ` [PATCH v3 03/10] ASoC: sunxi: sun4i-spdif: " Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  8:12   ` Maxime Ripard
2020-07-08  8:12     ` Maxime Ripard
2020-07-08  8:12     ` Maxime Ripard
2020-07-07 19:16 ` [PATCH v3 04/10] ASoC: pxa: pxa-ssp: Demote seemingly unintentional kerneldoc header Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 05/10] ASoC: ux500: ux500_msp_i2s: Remove unused variables 'reg_val_DR' and 'reg_val_TSTDR' Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 06/10] ASoC: sti: uniperif: fix 'defined by not used' warning Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  9:11   ` Arnaud POULIQUEN
2020-07-08  9:11     ` Arnaud POULIQUEN
2020-07-08 12:55     ` Pierre-Louis Bossart
2020-07-08 12:55       ` Pierre-Louis Bossart
2020-07-08 13:33       ` Arnaud POULIQUEN
2020-07-08 13:33         ` Arnaud POULIQUEN
2020-07-07 19:16 ` [PATCH v3 07/10] ASoC: codecs: rt5631: fix kernel-doc Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 08/10] ASoC: codecs: rt5659: Remove many unused const variables Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 09/10] ASoC: codecs: tlv320aic26: fix kernel-doc warning Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-07 19:16 ` [PATCH v3 10/10] ASoC: codecs: ak4458: Remove set but never checked variable 'ret' Pierre-Louis Bossart
2020-07-07 19:16   ` Pierre-Louis Bossart
2020-07-08  6:39 ` [PATCH v3 00/10] ASoC: Clean-up W=1 build warnings​ - part2 Lee Jones
2020-07-08 12:59   ` Pierre-Louis Bossart
2020-07-08 13:06     ` Lee Jones
2020-07-08 13:38       ` Mark Brown
2020-07-08 13:50         ` Lee Jones [this message]
2020-07-08 14:42           ` Mark Brown
2020-07-10 15:39 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708135016.GX3500@dell \
    --to=lee.jones@linaro.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.