From: Dmitry Osipenko <digetx@gmail.com>
To: Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Laxman Dewangan <ldewangan@nvidia.com>,
Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-tegra@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v1 4/5] gpio: max77620: Don't handle disabled interrupts
Date: Wed, 8 Jul 2020 11:26:33 +0300 [thread overview]
Message-ID: <20200708082634.30191-5-digetx@gmail.com> (raw)
In-Reply-To: <20200708082634.30191-1-digetx@gmail.com>
Check whether GPIO IRQ is enabled before proceeding with handling the
interrupt request. The interrupt handler now returns IRQ_NONE if none
of interrupts were handled, which is usually a sign of a problem.
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/gpio/gpio-max77620.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index dd83c16a1ec6..8d54bc4307c2 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -37,7 +37,9 @@ static irqreturn_t max77620_gpio_irqhandler(int irq, void *data)
return IRQ_NONE;
}
- pending = value;
+ pending = value & gpio->irq_enb_mask;
+ if (!pending)
+ return IRQ_NONE;
for_each_set_bit(offset, &pending, MAX77620_GPIO_NR) {
unsigned int virq;
--
2.26.0
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Thierry Reding
<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jonathan Hunter
<jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Laxman Dewangan
<ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>,
Bartosz Golaszewski
<bgolaszewski-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Linus Walleij
<linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH v1 4/5] gpio: max77620: Don't handle disabled interrupts
Date: Wed, 8 Jul 2020 11:26:33 +0300 [thread overview]
Message-ID: <20200708082634.30191-5-digetx@gmail.com> (raw)
In-Reply-To: <20200708082634.30191-1-digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Check whether GPIO IRQ is enabled before proceeding with handling the
interrupt request. The interrupt handler now returns IRQ_NONE if none
of interrupts were handled, which is usually a sign of a problem.
Signed-off-by: Dmitry Osipenko <digetx-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
drivers/gpio/gpio-max77620.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-max77620.c b/drivers/gpio/gpio-max77620.c
index dd83c16a1ec6..8d54bc4307c2 100644
--- a/drivers/gpio/gpio-max77620.c
+++ b/drivers/gpio/gpio-max77620.c
@@ -37,7 +37,9 @@ static irqreturn_t max77620_gpio_irqhandler(int irq, void *data)
return IRQ_NONE;
}
- pending = value;
+ pending = value & gpio->irq_enb_mask;
+ if (!pending)
+ return IRQ_NONE;
for_each_set_bit(offset, &pending, MAX77620_GPIO_NR) {
unsigned int virq;
--
2.26.0
next prev parent reply other threads:[~2020-07-08 8:28 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-08 8:26 [PATCH v1 0/5] Improvements for MAX77620 GPIO driver Dmitry Osipenko
2020-07-08 8:26 ` Dmitry Osipenko
2020-07-08 8:26 ` [PATCH v1 1/5] gpio: max77620: Initialize interrupts state Dmitry Osipenko
2020-07-08 8:51 ` Andy Shevchenko
2020-07-08 8:51 ` Andy Shevchenko
2020-07-08 8:53 ` Andy Shevchenko
2020-07-08 8:53 ` Andy Shevchenko
2020-07-08 9:09 ` Dmitry Osipenko
2020-07-08 9:09 ` Dmitry Osipenko
2020-07-08 9:41 ` Dmitry Osipenko
2020-07-08 9:41 ` Dmitry Osipenko
2020-07-08 8:26 ` [PATCH v1 2/5] gpio: max77620: Replace 8 with MAX77620_GPIO_NR Dmitry Osipenko
2020-07-08 8:26 ` [PATCH v1 3/5] gpio: max77620: Replace interrupt-enable array with bitmap Dmitry Osipenko
2020-07-08 8:44 ` Andy Shevchenko
2020-07-08 8:44 ` Andy Shevchenko
2020-07-08 9:08 ` Dmitry Osipenko
2020-07-08 8:26 ` Dmitry Osipenko [this message]
2020-07-08 8:26 ` [PATCH v1 4/5] gpio: max77620: Don't handle disabled interrupts Dmitry Osipenko
2020-07-08 8:46 ` Andy Shevchenko
2020-07-08 9:19 ` Dmitry Osipenko
2020-07-08 9:19 ` Dmitry Osipenko
2020-07-08 10:11 ` Andy Shevchenko
2020-07-08 10:54 ` Dmitry Osipenko
2020-07-08 15:31 ` Andy Shevchenko
2020-07-08 15:31 ` Andy Shevchenko
2020-07-08 8:26 ` [PATCH v1 5/5] gpio: max77620: Move variable declaration Dmitry Osipenko
2020-07-08 8:26 ` Dmitry Osipenko
2020-07-08 8:47 ` Andy Shevchenko
2020-07-08 9:24 ` Dmitry Osipenko
2020-07-08 9:24 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200708082634.30191-5-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=jonathanh@nvidia.com \
--cc=ldewangan@nvidia.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.