All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: linux-kernel@vger.kernel.org, jeremy.linton@arm.com,
	iommu@lists.linux-foundation.org,
	linux-rpi-kernel@lists.infradead.org,
	David Rientjes <rientjes@google.com>,
	Robin Murphy <robin.murphy@arm.com>,
	Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA
Date: Wed, 8 Jul 2020 18:58:02 +0200	[thread overview]
Message-ID: <20200708165802.GA1131@lst.de> (raw)
In-Reply-To: <20200708164936.9340-1-nsaenzjulienne@suse.de>

On Wed, Jul 08, 2020 at 06:49:39PM +0200, Nicolas Saenz Julienne wrote:
> There is no guarantee to CMA's placement, so allocating a zone specific
> atomic pool from CMA might return memory from a completely different
> memory zone. So stop using it.
> 
> Fixes: c84dc6e68a1d ("dma-pool: add additional coherent pools to map to gfp mask")
> Reported-by: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> 
> An more costly alternative would be adding an option to
> dma_alloc_from_contiguous() so it fails when the allocation doesn't fall
> in a specific zone.

Which seems like the right thing to do.  But then again for 5.8 I think
something less invasive like your patch might be better.  Waiting for
a few more opinions for now.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu

WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Cc: Christoph Hellwig <hch@lst.de>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Robin Murphy <robin.murphy@arm.com>,
	David Rientjes <rientjes@google.com>,
	linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com,
	iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dma-pool: Do not allocate pool memory from CMA
Date: Wed, 8 Jul 2020 18:58:02 +0200	[thread overview]
Message-ID: <20200708165802.GA1131@lst.de> (raw)
In-Reply-To: <20200708164936.9340-1-nsaenzjulienne@suse.de>

On Wed, Jul 08, 2020 at 06:49:39PM +0200, Nicolas Saenz Julienne wrote:
> There is no guarantee to CMA's placement, so allocating a zone specific
> atomic pool from CMA might return memory from a completely different
> memory zone. So stop using it.
> 
> Fixes: c84dc6e68a1d ("dma-pool: add additional coherent pools to map to gfp mask")
> Reported-by: Jeremy Linton <jeremy.linton@arm.com>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
> ---
> 
> An more costly alternative would be adding an option to
> dma_alloc_from_contiguous() so it fails when the allocation doesn't fall
> in a specific zone.

Which seems like the right thing to do.  But then again for 5.8 I think
something less invasive like your patch might be better.  Waiting for
a few more opinions for now.

  reply	other threads:[~2020-07-08 16:58 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08 16:49 [PATCH] dma-pool: Do not allocate pool memory from CMA Nicolas Saenz Julienne
2020-07-08 16:49 ` Nicolas Saenz Julienne
2020-07-08 16:58 ` Christoph Hellwig [this message]
2020-07-08 16:58   ` Christoph Hellwig
2020-07-08 23:14 ` Jeremy Linton
2020-07-08 23:14   ` Jeremy Linton
2020-07-09 21:47 ` David Rientjes via iommu
2020-07-09 21:47   ` David Rientjes
2020-07-21  7:21 ` Amit Pundir
2020-07-21  7:21   ` Amit Pundir
2020-07-21  8:39   ` Nicolas Saenz Julienne
2020-07-21  8:39     ` Nicolas Saenz Julienne
2020-07-21  8:54     ` Amit Pundir
2020-07-21  8:54       ` Amit Pundir
2020-07-21 11:15       ` Nicolas Saenz Julienne
2020-07-21 11:15         ` Nicolas Saenz Julienne
2020-07-21 11:28         ` Christoph Hellwig
2020-07-21 11:28           ` Christoph Hellwig
2020-07-21 11:37           ` Nicolas Saenz Julienne
2020-07-21 11:37             ` Nicolas Saenz Julienne
2020-07-21 12:16             ` Amit Pundir
2020-07-21 12:16               ` Amit Pundir
2020-07-21 12:15         ` Amit Pundir
2020-07-21 12:15           ` Amit Pundir
2020-07-21 12:45           ` Nicolas Saenz Julienne
2020-07-21 12:45             ` Nicolas Saenz Julienne
2020-07-21 15:22             ` Amit Pundir
2020-07-21 15:22               ` Amit Pundir
2020-07-21 16:27               ` Nicolas Saenz Julienne
2020-07-21 16:27                 ` Nicolas Saenz Julienne
2020-07-23  5:14                 ` Amit Pundir
2020-07-23  5:14                   ` Amit Pundir
2020-07-24  9:36                   ` Nicolas Saenz Julienne
2020-07-24  9:36                     ` Nicolas Saenz Julienne
2020-07-24 11:06                     ` Amit Pundir
2020-07-24 11:06                       ` Amit Pundir
2020-07-24 13:41                       ` Christoph Hellwig
2020-07-24 13:41                         ` Christoph Hellwig
2020-07-24 16:19                         ` Amit Pundir
2020-07-24 16:19                           ` Amit Pundir
2020-07-24 16:27                           ` Christoph Hellwig
2020-07-24 16:27                             ` Christoph Hellwig
2020-07-27 17:56                         ` Nicolas Saenz Julienne
2020-07-27 17:56                           ` Nicolas Saenz Julienne
2020-07-28  9:13                           ` Christoph Hellwig
2020-07-28  9:13                             ` Christoph Hellwig
2020-07-28  9:30                             ` Nicolas Saenz Julienne
2020-07-28  9:30                               ` Nicolas Saenz Julienne
2020-07-28 10:09                               ` Christoph Hellwig
2020-07-28 10:09                                 ` Christoph Hellwig
2020-07-31  1:10                                 ` Nathan Chancellor
2020-07-31  1:10                                   ` Nathan Chancellor
2020-07-31  7:19                                   ` Amit Pundir
2020-07-31  7:19                                     ` Amit Pundir
2020-07-31 10:09                                   ` Nicolas Saenz Julienne
2020-07-31 10:09                                     ` Nicolas Saenz Julienne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200708165802.GA1131@lst.de \
    --to=hch@lst.de \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jeremy.linton@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=nsaenzjulienne@suse.de \
    --cc=rientjes@google.com \
    --cc=robin.murphy@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.