From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, Vignesh Raghavendra <vigneshr@ti.com>,
Tudor Ambarus <Tudor.Ambarus@microchip.com>,
juliensu@mxic.com.tw, Richard Weinberger <richard@nod.at>,
Rob Herring <robh+dt@kernel.org>,
linux-mtd@lists.infradead.org,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
masonccyang@mxic.com.tw
Subject: Re: [PATCH v12 2/2] dt-bindings: mtd: Document boolean NAND ECC properties
Date: Thu, 9 Jul 2020 14:03:19 -0600 [thread overview]
Message-ID: <20200709200319.GA799550@bogus> (raw)
In-Reply-To: <20200630072822.26828-3-miquel.raynal@bootlin.com>
On Tue, 30 Jun 2020 09:28:22 +0200, Miquel Raynal wrote:
> Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties.
> The former is here to force software correction, the latter prevents
> any correction to happen.
>
> These properties (along with nand-ecc-engine) are supposed to be more
> accurate than the current nand-ecc-modes wich is very misleading and
> very often people think it is mandatory while the core should be
> relied upon to decide which correction to handle.
>
> nand-ecc-mode was already inacurate, but it becomes totally
> problematic with setups where there are several hardware engines.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../devicetree/bindings/mtd/nand-controller.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Rob Herring <robh@kernel.org>
To: Miquel Raynal <miquel.raynal@bootlin.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Mark Rutland <mark.rutland@arm.com>,
Boris Brezillon <boris.brezillon@collabora.com>,
juliensu@mxic.com.tw, Tudor Ambarus <Tudor.Ambarus@microchip.com>,
masonccyang@mxic.com.tw, devicetree@vger.kernel.org,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v12 2/2] dt-bindings: mtd: Document boolean NAND ECC properties
Date: Thu, 9 Jul 2020 14:03:19 -0600 [thread overview]
Message-ID: <20200709200319.GA799550@bogus> (raw)
In-Reply-To: <20200630072822.26828-3-miquel.raynal@bootlin.com>
On Tue, 30 Jun 2020 09:28:22 +0200, Miquel Raynal wrote:
> Document nand-use-soft-ecc-engine and nand-no-ecc-engine properties.
> The former is here to force software correction, the latter prevents
> any correction to happen.
>
> These properties (along with nand-ecc-engine) are supposed to be more
> accurate than the current nand-ecc-modes wich is very misleading and
> very often people think it is mandatory while the core should be
> relied upon to decide which correction to handle.
>
> nand-ecc-mode was already inacurate, but it becomes totally
> problematic with setups where there are several hardware engines.
>
> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
> ---
> .../devicetree/bindings/mtd/nand-controller.yaml | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-07-09 20:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-30 7:28 [PATCH v12 0/2] NAND ECC engine binding changes Miquel Raynal
2020-06-30 7:28 ` Miquel Raynal
2020-06-30 7:28 ` [PATCH v12 1/2] dt-bindings: mtd: Document nand-ecc-engine Miquel Raynal
2020-06-30 7:28 ` Miquel Raynal
2020-07-09 20:02 ` Rob Herring
2020-07-09 20:02 ` Rob Herring
2020-06-30 7:28 ` [PATCH v12 2/2] dt-bindings: mtd: Document boolean NAND ECC properties Miquel Raynal
2020-06-30 7:28 ` Miquel Raynal
2020-07-09 20:03 ` Rob Herring [this message]
2020-07-09 20:03 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200709200319.GA799550@bogus \
--to=robh@kernel.org \
--cc=Tudor.Ambarus@microchip.com \
--cc=boris.brezillon@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=juliensu@mxic.com.tw \
--cc=linux-mtd@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=masonccyang@mxic.com.tw \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.