From: Christoph Hellwig <hch@lst.de>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel@vger.kernel.org, jeremy.linton@arm.com,
iommu@lists.linux-foundation.org,
linux-rpi-kernel@lists.infradead.org,
Robin Murphy <robin.murphy@arm.com>,
hch@lst.de
Subject: Re: [PATCH 2/4] dma-pool: Get rid of dma_in_atomic_pool()
Date: Fri, 10 Jul 2020 08:50:54 +0200 [thread overview]
Message-ID: <20200710065054.GA19416@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.23.453.2007091449540.972523@chino.kir.corp.google.com>
On Thu, Jul 09, 2020 at 02:51:13PM -0700, David Rientjes wrote:
> On Thu, 9 Jul 2020, Nicolas Saenz Julienne wrote:
>
> > The function is only used once and can be simplified to a one-liner.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> I'll leave this one to Christoph to decide on. One thing I really liked
> about hacking around in kernel/dma is the coding style, it really follows
> "one function does one thing and does it well" even if there is only one
> caller. dma_in_atomic_pool() was an attempt to follow in those footsteps.
While I like the helper aswell, I don't see how it could work nicely
with the changes in patch 4.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@lst.de>
To: David Rientjes <rientjes@google.com>
Cc: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
hch@lst.de, Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux-foundation.org,
Marek Szyprowski <m.szyprowski@samsung.com>,
linux-rpi-kernel@lists.infradead.org, jeremy.linton@arm.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] dma-pool: Get rid of dma_in_atomic_pool()
Date: Fri, 10 Jul 2020 08:50:54 +0200 [thread overview]
Message-ID: <20200710065054.GA19416@lst.de> (raw)
In-Reply-To: <alpine.DEB.2.23.453.2007091449540.972523@chino.kir.corp.google.com>
On Thu, Jul 09, 2020 at 02:51:13PM -0700, David Rientjes wrote:
> On Thu, 9 Jul 2020, Nicolas Saenz Julienne wrote:
>
> > The function is only used once and can be simplified to a one-liner.
> >
> > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>
> I'll leave this one to Christoph to decide on. One thing I really liked
> about hacking around in kernel/dma is the coding style, it really follows
> "one function does one thing and does it well" even if there is only one
> caller. dma_in_atomic_pool() was an attempt to follow in those footsteps.
While I like the helper aswell, I don't see how it could work nicely
with the changes in patch 4.
next prev parent reply other threads:[~2020-07-10 6:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 16:19 [PATCH 0/4] dma-pool: Fix atomic pool selection Nicolas Saenz Julienne
2020-07-09 16:19 ` Nicolas Saenz Julienne
2020-07-09 16:19 ` [PATCH 1/4] dma-direct: Provide function to check physical memory area validity Nicolas Saenz Julienne
2020-07-09 16:19 ` Nicolas Saenz Julienne
2020-07-09 16:19 ` [PATCH 2/4] dma-pool: Get rid of dma_in_atomic_pool() Nicolas Saenz Julienne
2020-07-09 16:19 ` Nicolas Saenz Julienne
2020-07-09 21:51 ` David Rientjes via iommu
2020-07-09 21:51 ` David Rientjes
2020-07-10 6:50 ` Christoph Hellwig [this message]
2020-07-10 6:50 ` Christoph Hellwig
2020-07-09 16:19 ` [PATCH 3/4] dma-pool: Introduce dma_guess_pool() Nicolas Saenz Julienne
2020-07-09 16:19 ` Nicolas Saenz Julienne
2020-07-14 11:22 ` Christoph Hellwig
2020-07-14 11:22 ` Christoph Hellwig
2020-07-14 11:40 ` Nicolas Saenz Julienne
2020-07-14 11:40 ` Nicolas Saenz Julienne
2020-07-09 16:19 ` [PATCH 4/4] dma-pool: Make sure atomic pool suits device Nicolas Saenz Julienne
2020-07-09 16:19 ` Nicolas Saenz Julienne
2020-07-10 18:52 ` [PATCH 0/4] dma-pool: Fix atomic pool selection Jeremy Linton
2020-07-10 18:52 ` Jeremy Linton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710065054.GA19416@lst.de \
--to=hch@lst.de \
--cc=iommu@lists.linux-foundation.org \
--cc=jeremy.linton@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=rientjes@google.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.