[PATCH v3] netbase: use git fetcher

[PATCH v3] netbase: use git fetcher

[Yu, Mingli]

From: Mingli Yu <mingli.yu@windriver.com>

Use git repo as the the previous URL only stores the latest
source file and fails to locate the source tar file if we
don't upgrade timely.
---
 meta/recipes-core/netbase/netbase_6.1.bb | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/meta/recipes-core/netbase/netbase_6.1.bb b/meta/recipes-core/netbase/netbase_6.1.bb
index bc0049c0201..491e6bf4cbf 100644
--- a/meta/recipes-core/netbase/netbase_6.1.bb
+++ b/meta/recipes-core/netbase/netbase_6.1.bb
@@ -6,10 +6,10 @@ LICENSE = "GPLv2"
 LIC_FILES_CHKSUM = "file://debian/copyright;md5=3dd6192d306f582dee7687da3d8748ab"
 PE = "1"
 
-SRC_URI = "${DEBIAN_MIRROR}/main/n/${BPN}/${BPN}_${PV}.tar.xz"
+SRC_URI = "git://salsa.debian.org/md/netbase.git;protocol=https"
+SRCREV = "0fc1e4ce39328f7388badace0aaf7b7294d5ed61"
 
-SRC_URI[md5sum] = "e5871a3a5c8390557b8033cf19316a55"
-SRC_URI[sha256sum] = "084d743bd84d4d9380bac4c71c51e57406dce44f5a69289bb823c903e9b035d8"
+S = "${WORKDIR}/git"
 
 UPSTREAM_CHECK_URI = "${DEBIAN_MIRROR}/main/n/netbase/"
 do_install () {
@@ -18,3 +18,16 @@ do_install () {
 	install -m 0644 ${S}/etc/protocols ${D}${sysconfdir}/protocols
 	install -m 0644 ${S}/etc/services ${D}${sysconfdir}/services
 }
+
+# The reproducible test failed in autobuilder env as
+# https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20200630-_jn1koza/packages/diff-html/
+# But I didn't reproduce it locally when run "oe-selftest -r reproducible.ReproducibleTests.test_reproducible_builds"
+# Per the logic in meta/classes/reproducible_build.bbclass, it should use
+# get_source_date_epoch_from_git to get the SOURCE_DATE_EPOCH after we
+# switch to use git fetcher, don't understand why the SOURCE_DATE_EPOCH
+# is different between reproducibleA and reproducibleB during reproducible
+# test in autobuilder env. The only difference is reproducibleA use sstate
+# but reproducibleB not. Maybe the sstate in autobuilder env has some problem?
+# Anyway, use the default value for SOURCE_DATE_EPOCH from meta/classes/reproducible_build_simple.bbclass
+# to fix the gap as a workaround.
+export SOURCE_DATE_EPOCH = "1520598896"
-- 
2.26.2

✗ patchtest: failure for netbase: use git fetcher (rev3)

[Patchwork]

== Series Details ==

Series: netbase: use git fetcher (rev3)
Revision: 3
URL   : https://patchwork.openembedded.org/series/23255/
State : failure

== Summary ==


Thank you for submitting this patch series to OpenEmbedded Core. This is
an automated response. Several tests have been executed on the proposed
series by patchtest resulting in the following failures:



* Patch            [v3] netbase: use git fetcher
 Issue             Patch is missing Signed-off-by [test_signed_off_by_presence] 
  Suggested fix    Sign off the patch (either manually or with "git commit --amend -s")



If you believe any of these test results are incorrect, please reply to the
mailing list (openembedded-core@lists.openembedded.org) raising your concerns.
Otherwise we would appreciate you correcting the issues and submitting a new
version of the patchset if applicable. Please ensure you add/increment the
version number when sending the new version (i.e. [PATCH] -> [PATCH v2] ->
[PATCH v3] -> ...).

---
Guidelines:     https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
Test framework: http://git.yoctoproject.org/cgit/cgit.cgi/patchtest
Test suite:     http://git.yoctoproject.org/cgit/cgit.cgi/patchtest-oe

Re: [OE-core] [PATCH v3] netbase: use git fetcher

[Yu, Mingli]

Please ignore this patch.

Thanks,

On 7/10/20 3:01 PM, Yu, Mingli wrote:
> From: Mingli Yu <mingli.yu@windriver.com>
> 
> Use git repo as the the previous URL only stores the latest
> source file and fails to locate the source tar file if we
> don't upgrade timely.
> ---
>   meta/recipes-core/netbase/netbase_6.1.bb | 19 ++++++++++++++++---
>   1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/meta/recipes-core/netbase/netbase_6.1.bb b/meta/recipes-core/netbase/netbase_6.1.bb
> index bc0049c0201..491e6bf4cbf 100644
> --- a/meta/recipes-core/netbase/netbase_6.1.bb
> +++ b/meta/recipes-core/netbase/netbase_6.1.bb
> @@ -6,10 +6,10 @@ LICENSE = "GPLv2"
>   LIC_FILES_CHKSUM = "file://debian/copyright;md5=3dd6192d306f582dee7687da3d8748ab"
>   PE = "1"
>   
> -SRC_URI = "${DEBIAN_MIRROR}/main/n/${BPN}/${BPN}_${PV}.tar.xz"
> +SRC_URI = "git://salsa.debian.org/md/netbase.git;protocol=https"
> +SRCREV = "0fc1e4ce39328f7388badace0aaf7b7294d5ed61"
>   
> -SRC_URI[md5sum] = "e5871a3a5c8390557b8033cf19316a55"
> -SRC_URI[sha256sum] = "084d743bd84d4d9380bac4c71c51e57406dce44f5a69289bb823c903e9b035d8"
> +S = "${WORKDIR}/git"
>   
>   UPSTREAM_CHECK_URI = "${DEBIAN_MIRROR}/main/n/netbase/"
>   do_install () {
> @@ -18,3 +18,16 @@ do_install () {
>   	install -m 0644 ${S}/etc/protocols ${D}${sysconfdir}/protocols
>   	install -m 0644 ${S}/etc/services ${D}${sysconfdir}/services
>   }
> +
> +# The reproducible test failed in autobuilder env as
> +# https://autobuilder.yocto.io/pub/repro-fail/oe-reproducible-20200630-_jn1koza/packages/diff-html/
> +# But I didn't reproduce it locally when run "oe-selftest -r reproducible.ReproducibleTests.test_reproducible_builds"
> +# Per the logic in meta/classes/reproducible_build.bbclass, it should use
> +# get_source_date_epoch_from_git to get the SOURCE_DATE_EPOCH after we
> +# switch to use git fetcher, don't understand why the SOURCE_DATE_EPOCH
> +# is different between reproducibleA and reproducibleB during reproducible
> +# test in autobuilder env. The only difference is reproducibleA use sstate
> +# but reproducibleB not. Maybe the sstate in autobuilder env has some problem?
> +# Anyway, use the default value for SOURCE_DATE_EPOCH from meta/classes/reproducible_build_simple.bbclass
> +# to fix the gap as a workaround.
> +export SOURCE_DATE_EPOCH = "1520598896"
> 
> 
> 
>