[MPTCP] Re: [PATCH net-next 0/9] mptcp: cope better with mp_join storm

[MPTCP] Re: [PATCH net-next 0/9] mptcp: cope better with mp_join storm

[Christoph Paasch]

[-- Attachment #1: Type: text/plain, Size: 1398 bytes --]

On 07/10/20 - 11:31, Mat Martineau wrote:
> 
> On Fri, 10 Jul 2020, Paolo Abeni wrote:
> 
> > This is a rebase of the RFC, dropping old 5/5 and including a few somewhat
> > related bugfixes - all targeting net-next because the fixed commit is only
> > there or the buggy behavior can be triggered only enabling non backup subflows
> > 
> > Paolo Abeni (9):
> >  subflow: always init 'rel_write_seq'
> >  mptcp: avoid data corruption on reinsert
> >  mptcp: mark as fallback even early ones
> >  mptcp: zero token hash at creation time.
> >  mptcp: make msk established at remote key reception time
> >  mptcp: cleanup subflow_finish_connect()
> >  subflow: explicitly check for plain tcp rsk
> >  subflow: use rsk_ops->send_reset()
> >  subflow: introduce and use mptcp_can_accept_new_subflow()
> > 
> > net/mptcp/options.c  |  4 +-
> > net/mptcp/protocol.c | 20 +++++++---
> > net/mptcp/protocol.h |  2 +
> > net/mptcp/subflow.c  | 87 +++++++++++++++++++++++++-------------------
> > net/mptcp/token.c    |  2 +-
> > 5 files changed, 69 insertions(+), 46 deletions(-)
> > 
> > -- 
> > 2.26.2
> 
> Thanks Paolo, the changes look good. Should these go in mptcp_net-next for a
> testing pass before upstreaming?

I picked these patches on top of export and am running syzkaller on top of
it. I will try to do an mptcp.org-interop run later or Monday.


Christoph

[MPTCP] Re: [PATCH net-next 0/9] mptcp: cope better with mp_join storm

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 1742 bytes --]

Hi,

On Fri, 2020-07-10 at 11:31 -0700, Mat Martineau wrote:
> On Fri, 10 Jul 2020, Paolo Abeni wrote:
> 
> > This is a rebase of the RFC, dropping old 5/5 and including a few somewhat
> > related bugfixes - all targeting net-next because the fixed commit is only
> > there or the buggy behavior can be triggered only enabling non backup subflows
> > 
> > Paolo Abeni (9):
> >  subflow: always init 'rel_write_seq'
> >  mptcp: avoid data corruption on reinsert
> >  mptcp: mark as fallback even early ones
> >  mptcp: zero token hash at creation time.
> >  mptcp: make msk established at remote key reception time
> >  mptcp: cleanup subflow_finish_connect()
> >  subflow: explicitly check for plain tcp rsk
> >  subflow: use rsk_ops->send_reset()
> >  subflow: introduce and use mptcp_can_accept_new_subflow()
> > 
> > net/mptcp/options.c  |  4 +-
> > net/mptcp/protocol.c | 20 +++++++---
> > net/mptcp/protocol.h |  2 +
> > net/mptcp/subflow.c  | 87 +++++++++++++++++++++++++-------------------
> > net/mptcp/token.c    |  2 +-
> > 5 files changed, 69 insertions(+), 46 deletions(-)
> > 
> > -- 
> > 2.26.2
> 
> Thanks Paolo, the changes look good. Should these go in mptcp_net-next for 
> a testing pass before upstreaming?

Sorry for lagging behind. This whole week I'll be half off, so expect
added latency.

Yes, the idea is staging this changes a bit in the export branch before
pushing them upstream.

Additional note: the fixes commits included here have been found using
a staging local self-test using multiple concurrent xmit subflows. I
tried to spool them as I expect/fear to found some/many more before
obtaining somewhat stable results in the mentioned scenario.

Cheers,

Paolo

[MPTCP] Re: [PATCH net-next 0/9] mptcp: cope better with mp_join storm

[Matthieu Baerts]

[-- Attachment #1: Type: text/plain, Size: 1011 bytes --]

Hi Paolo, Mat, Christoph,

On 10/07/2020 23:35, Christoph Paasch wrote:
> On 07/10/20 - 11:31, Mat Martineau wrote:
>>
>> On Fri, 10 Jul 2020, Paolo Abeni wrote:
>>
>>> This is a rebase of the RFC, dropping old 5/5 and including a few somewhat
>>> related bugfixes - all targeting net-next because the fixed commit is only
>>> there or the buggy behavior can be triggered only enabling non backup subflows

...

>> Thanks Paolo, the changes look good. Should these go in mptcp_net-next for a
>> testing pass before upstreaming?
> 
> I picked these patches on top of export and am running syzkaller on top of
> it. I will try to do an mptcp.org-interop run later or Monday.
These patches are in the "export" branches with these tags:

   Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
   Tested-by: Christoph Paasch <cpaasch(a)apple.com>

Please tell me if you wish me to change this.

Cheers,
Matt
-- 
Tessares | Belgium | Hybrid Access Solutions
www.tessares.net

[MPTCP] Re: [PATCH net-next 0/9] mptcp: cope better with mp_join storm

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 1162 bytes --]


On Fri, 10 Jul 2020, Paolo Abeni wrote:

> This is a rebase of the RFC, dropping old 5/5 and including a few somewhat
> related bugfixes - all targeting net-next because the fixed commit is only
> there or the buggy behavior can be triggered only enabling non backup subflows
>
> Paolo Abeni (9):
>  subflow: always init 'rel_write_seq'
>  mptcp: avoid data corruption on reinsert
>  mptcp: mark as fallback even early ones
>  mptcp: zero token hash at creation time.
>  mptcp: make msk established at remote key reception time
>  mptcp: cleanup subflow_finish_connect()
>  subflow: explicitly check for plain tcp rsk
>  subflow: use rsk_ops->send_reset()
>  subflow: introduce and use mptcp_can_accept_new_subflow()
>
> net/mptcp/options.c  |  4 +-
> net/mptcp/protocol.c | 20 +++++++---
> net/mptcp/protocol.h |  2 +
> net/mptcp/subflow.c  | 87 +++++++++++++++++++++++++-------------------
> net/mptcp/token.c    |  2 +-
> 5 files changed, 69 insertions(+), 46 deletions(-)
>
> -- 
> 2.26.2

Thanks Paolo, the changes look good. Should these go in mptcp_net-next for 
a testing pass before upstreaming?

--
Mat Martineau
Intel