From: Corey Minyard <minyard@acm.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: "Corey Minyard" <cminyard@mvista.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
"Cédric Le Goater" <clg@kaod.org>,
"Jan Kiszka" <jan.kiszka@web.de>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Joel Stanley" <joel@jms.id.au>
Subject: Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation
Date: Fri, 10 Jul 2020 18:50:18 -0500 [thread overview]
Message-ID: <20200710235018.GC3235@minyard.net> (raw)
In-Reply-To: <c287bb80-7057-b5f9-5263-84b7a12790bb@amsat.org>
On Fri, Jul 10, 2020 at 11:53:13AM +0200, Philippe Mathieu-Daudé wrote:
> Corey, this series is now fully reviewed :)
Ok, I've pulled this in and added the extra reviews that came in. I'll
work on getting it out Monday.
Thanks,
-corey
>
> On 7/6/20 12:41 AM, Philippe Mathieu-Daudé wrote:
> > In commit d88c42ff2c we added 2 methods: i2c_try_create_slave()
> > and i2c_realize_and_unref().
> > Markus noted their name could be improved for consistency [1],
> > and Peter reported the lack of documentation [2]. Fix that now.
> >
> > Since v1:
> > - Addressed Markus review comments
> > - Added Markus/Corey R-b tags
> >
> > [1] https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg07060.html
> > [2] https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg08997.html
> >
> > $ git backport-diff -u -v1
> > Key:
> > [----] : patches are identical
> > [####] : number of functional differences between upstream/downstream patch
> > [down] : patch is downstream-only
> > The flags [FC] indicate (F)unctional and (C)ontextual differences, respectively
> >
> > 001/5:[----] [--] 'hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()'
> > 002/5:[0006] [FC] 'hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new()'
> > 003/5:[0004] [FC] 'hw/i2c: Rename i2c_realize_and_unref() as i2c_slave_realize_and_unref()'
> > 004/5:[0006] [FC] 'hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple()'
> > 005/5:[0012] [FC] 'hw/i2c: Document the I2C qdev helpers'
>
prev parent reply other threads:[~2020-07-10 23:51 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-05 22:41 [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation Philippe Mathieu-Daudé
2020-07-05 22:41 ` Philippe Mathieu-Daudé
2020-07-05 22:41 ` [PATCH v2 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus() Philippe Mathieu-Daudé
2020-07-06 1:39 ` Andrew Jeffery
2020-07-06 1:39 ` Andrew Jeffery
2020-07-05 22:41 ` [PATCH v2 2/5] hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new() Philippe Mathieu-Daudé
2020-07-05 22:41 ` [PATCH v2 3/5] hw/i2c: Rename i2c_realize_and_unref() as i2c_slave_realize_and_unref() Philippe Mathieu-Daudé
2020-07-05 22:41 ` [PATCH v2 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple() Philippe Mathieu-Daudé
2020-07-05 22:41 ` Philippe Mathieu-Daudé
2020-07-05 22:41 ` [PATCH v2 5/5] hw/i2c: Document the I2C qdev helpers Philippe Mathieu-Daudé
2020-07-05 22:41 ` Philippe Mathieu-Daudé
2020-07-09 18:49 ` Peter Maydell
2020-07-09 18:49 ` Peter Maydell
2020-07-10 9:53 ` [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation Philippe Mathieu-Daudé
2020-07-10 9:53 ` Philippe Mathieu-Daudé
2020-07-10 23:50 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200710235018.GC3235@minyard.net \
--to=minyard@acm.org \
--cc=andrew@aj.id.au \
--cc=armbru@redhat.com \
--cc=clg@kaod.org \
--cc=cminyard@mvista.com \
--cc=david@gibson.dropbear.id.au \
--cc=f4bug@amsat.org \
--cc=jan.kiszka@web.de \
--cc=joel@jms.id.au \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.