All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [PATCH] mt6625l: fix itnull.cocci warnings
Date: Sun, 12 Jul 2020 20:19:10 +0800	[thread overview]
Message-ID: <20200712121910.GA72436@f669aaa75a90> (raw)
In-Reply-To: <202007122043.encHIg4V%lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1677 bytes --]

From: kernel test robot <lkp@intel.com>

drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c:414:7-15: ERROR: iterator variable bound on line 412 cannot be NULL

 Many iterators have the property that the first argument is always bound
 to a real list element, never NULL.

Semantic patch information:
 False positives arise for some iterators that do not have this property,
 or in cases when the loop cursor is reassigned.  The latter should only
 happen when the matched code is on the way to a loop exit (break, goto,
 or return).

Generated by: scripts/coccinelle/iterators/itnull.cocci

Fixes: 9a72d145abe4 ("mt6625l: include wifi-folder")
Signed-off-by: kernel test robot <lkp@intel.com>
---

tree:   https://github.com/frank-w/BPI-R2-4.14 5.8-rc
head:   ca0d6f7786586ca7ba424d5967d780dd3c75748b
commit: 9a72d145abe49d9cb1e16d479b0b18caa20cdd71 [5/38] mt6625l: include wifi-folder

Please take the patch only if it's a positive warning. Thanks!

 p2p_rlm.c |    4 ----
 1 file changed, 4 deletions(-)

--- a/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c
+++ b/drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/p2p_rlm.c
@@ -411,10 +411,6 @@ VOID rlmUpdateParamsForAP(P_ADAPTER_T pr
 
 	LINK_FOR_EACH_ENTRY(prStaRec, prStaList, rLinkEntry, STA_RECORD_T) {
 		/* ASSERT(prStaRec); */
-		if (!prStaRec) {
-			DBGLOG(P2P, TRACE, "prStaRec is NULL in rlmUpdateParamsForAP()\n");
-			break;
-		}
 		if (prStaRec->fgIsInUse && prStaRec->ucStaState == STA_STATE_3 &&
 		    prStaRec->ucNetTypeIndex == prBssInfo->ucNetTypeIndex) {
 			if (!(prStaRec->ucPhyTypeSet & (PHY_TYPE_SET_802_11GN | PHY_TYPE_SET_802_11A))) {

  parent reply	other threads:[~2020-07-12 12:19 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-12 12:19 [frank-w-bpi-r2-4.14:5.8-rc 5/38] drivers/misc/mediatek/connectivity/wlan/gen2/mgmt/assoc.c:1549:44-45: WARNING: Use ARRAY_SIZE kernel test robot
2020-07-12 12:19 ` [PATCH] mt6625l: fix badzero.cocci warnings kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` [PATCH] mt6625l: fix boolconv.cocci warnings kernel test robot
2020-07-12 12:19 ` kernel test robot [this message]
2020-07-12 12:19 ` [PATCH] mt6625l: fix returnvar.cocci warnings kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` [PATCH] mt6625l: fix semicolon.cocci warnings kernel test robot
2020-07-12 12:19 ` kernel test robot
2020-07-12 12:19 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200712121910.GA72436@f669aaa75a90 \
    --to=lkp@intel.com \
    --cc=kbuild-all@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.