From: Lee Jones <lee.jones@linaro.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org,
cy_huang@richtek.com, benjamin.chao@mediatek.com,
linux-mediatek@lists.infradead.org,
Gene Chen <gene.chen.richtek@gmail.com>,
linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com
Subject: Re: [PATCH 1/4] mfd: mt6360: Refactor and fix code style
Date: Mon, 13 Jul 2020 07:51:10 +0100 [thread overview]
Message-ID: <20200713065110.GB3500@dell> (raw)
In-Reply-To: <b9540dc6-4d43-45e4-8878-15d2df24a268@gmail.com>
On Fri, 10 Jul 2020, Matthias Brugger wrote:
>
>
> On 07/07/2020 12:30, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Rearrange include file.
> > Remove brackets around raw numbers.
> > Indicate sub-dev compatible name by using "-"
> > Combine mt6360 pmic/ldo resouces into mt6360 regulator resources.
> > Rename mt6360_pmu_data by mt6360_data.
> > Rename mt6360_pmu by mt6360.
>
> That seems like a lot of cosmetics. Why is this needed?
> If you think that's needed it should be split up in different commits, each
> explaining in the commit message why you do that.
Agreed. This set is still not broken up enough.
Please place each logical change into its own patch for review.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: gene_chen@richtek.com, linux-kernel@vger.kernel.org,
cy_huang@richtek.com, benjamin.chao@mediatek.com,
linux-mediatek@lists.infradead.org,
Gene Chen <gene.chen.richtek@gmail.com>,
linux-arm-kernel@lists.infradead.org, shufan_lee@richtek.com
Subject: Re: [PATCH 1/4] mfd: mt6360: Refactor and fix code style
Date: Mon, 13 Jul 2020 07:51:10 +0100 [thread overview]
Message-ID: <20200713065110.GB3500@dell> (raw)
In-Reply-To: <b9540dc6-4d43-45e4-8878-15d2df24a268@gmail.com>
On Fri, 10 Jul 2020, Matthias Brugger wrote:
>
>
> On 07/07/2020 12:30, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Rearrange include file.
> > Remove brackets around raw numbers.
> > Indicate sub-dev compatible name by using "-"
> > Combine mt6360 pmic/ldo resouces into mt6360 regulator resources.
> > Rename mt6360_pmu_data by mt6360_data.
> > Rename mt6360_pmu by mt6360.
>
> That seems like a lot of cosmetics. Why is this needed?
> If you think that's needed it should be split up in different commits, each
> explaining in the commit message why you do that.
Agreed. This set is still not broken up enough.
Please place each logical change into its own patch for review.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Gene Chen <gene.chen.richtek@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, shufan_lee@richtek.com,
cy_huang@richtek.com, benjamin.chao@mediatek.com
Subject: Re: [PATCH 1/4] mfd: mt6360: Refactor and fix code style
Date: Mon, 13 Jul 2020 07:51:10 +0100 [thread overview]
Message-ID: <20200713065110.GB3500@dell> (raw)
In-Reply-To: <b9540dc6-4d43-45e4-8878-15d2df24a268@gmail.com>
On Fri, 10 Jul 2020, Matthias Brugger wrote:
>
>
> On 07/07/2020 12:30, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Rearrange include file.
> > Remove brackets around raw numbers.
> > Indicate sub-dev compatible name by using "-"
> > Combine mt6360 pmic/ldo resouces into mt6360 regulator resources.
> > Rename mt6360_pmu_data by mt6360_data.
> > Rename mt6360_pmu by mt6360.
>
> That seems like a lot of cosmetics. Why is this needed?
> If you think that's needed it should be split up in different commits, each
> explaining in the commit message why you do that.
Agreed. This set is still not broken up enough.
Please place each logical change into its own patch for review.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-07-13 6:51 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 10:30 [PATCH 0/4] mfd: mt6360: Merge different sub-devices i2c read/write Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-07 10:30 ` [PATCH 1/4] mfd: mt6360: Refactor and fix code style Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-10 14:06 ` Matthias Brugger
2020-07-10 14:06 ` Matthias Brugger
2020-07-10 14:06 ` Matthias Brugger
2020-07-13 6:51 ` Lee Jones [this message]
2020-07-13 6:51 ` Lee Jones
2020-07-13 6:51 ` Lee Jones
2020-07-13 10:35 ` Gene Chen
2020-07-13 10:35 ` Gene Chen
2020-07-13 10:35 ` Gene Chen
2020-07-13 10:48 ` Lee Jones
2020-07-13 10:48 ` Lee Jones
2020-07-13 10:48 ` Lee Jones
2020-07-16 10:12 ` Gene Chen
2020-07-16 10:12 ` Gene Chen
2020-07-16 10:12 ` Gene Chen
2020-07-16 13:44 ` Lee Jones
2020-07-16 13:44 ` Lee Jones
2020-07-16 13:44 ` Lee Jones
2020-07-07 10:30 ` [PATCH 2/4] mfd: mt6360: Remove handle_post_irq callback function Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-10 14:22 ` Matthias Brugger
2020-07-10 14:22 ` Matthias Brugger
2020-07-10 14:22 ` Matthias Brugger
2020-07-17 9:35 ` Gene Chen
2020-07-17 9:35 ` Gene Chen
2020-07-17 9:35 ` Gene Chen
2020-07-07 10:30 ` [PATCH 3/4] mfd: mt6360: Fix flow which is used to check ic exist Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-10 14:25 ` Matthias Brugger
2020-07-10 14:25 ` Matthias Brugger
2020-07-10 14:25 ` Matthias Brugger
2020-07-16 9:53 ` Gene Chen
2020-07-16 9:53 ` Gene Chen
2020-07-16 9:53 ` Gene Chen
2020-07-07 10:30 ` [PATCH 4/4] mfd: mt6360: Merge different sub-devices i2c read/write into one regmap Gene Chen
2020-07-07 10:30 ` Gene Chen
2020-07-07 10:30 ` Gene Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713065110.GB3500@dell \
--to=lee.jones@linaro.org \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=shufan_lee@richtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.