All of lore.kernel.org
 help / color / mirror / Atom feed
From: Shawn Guo <shawnguo@kernel.org>
To: Chris Healy <cphealy@gmail.com>
Cc: devicetree@vger.kernel.org, andrew@lunn.ch,
	s.hauer@pengutronix.de, linux-kernel@vger.kernel.org,
	stefan@agner.ch, robh+dt@kernel.org, linux-imx@nxp.com,
	festevam@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble
Date: Mon, 13 Jul 2020 15:34:22 +0800	[thread overview]
Message-ID: <20200713071957.GL12113@dragon> (raw)
In-Reply-To: <20200708002500.4563-1-cphealy@gmail.com>

On Tue, Jul 07, 2020 at 05:25:00PM -0700, Chris Healy wrote:
> Update MDIO configuration with ZII devices to fully utilize
> MDIO endpoint capabilities.  All devices support 12.5MHz clock and
> don't require MDIO preable.
> 
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> v2:
> - Fix subject line to reference ZII:
> - Get rid of "=<1>;" from suppress-preamble lines
> 
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi   | 2 ++
>  arch/arm/boot/dts/vf610-zii-cfu1.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-dev.dtsi      | 2 ++
>  arch/arm/boot/dts/vf610-zii-spb4.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts  | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 2 ++
>  6 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 20350e803377..58cc421042e1 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -720,6 +720,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;

We usually have 'status' at end of property list, so please move them
up.

Shawn

>  
>  		switch: switch@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> index ce1920c052fc..c27cacbe6a73 100644
> --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> @@ -159,6 +159,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-dev.dtsi b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> index 95d0060fb56c..9694d3b53607 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev.dtsi
> +++ b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> @@ -138,6 +138,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  	};
>  };
>  
> diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
> index 55b4201e27f6..d2ad07ed5318 100644
> --- a/arch/arm/boot/dts/vf610-zii-spb4.dts
> +++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
> @@ -120,6 +120,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> index a6c22a79779e..0bb3dcff0b79 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> @@ -106,6 +106,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> index 3d05c894bdc0..e12e11805b71 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> @@ -134,6 +134,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> -- 
> 2.21.3
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Chris Healy <cphealy@gmail.com>
Cc: robh+dt@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	linux-imx@nxp.com, stefan@agner.ch, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, andrew@lunn.ch
Subject: Re: [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble
Date: Mon, 13 Jul 2020 15:34:22 +0800	[thread overview]
Message-ID: <20200713071957.GL12113@dragon> (raw)
In-Reply-To: <20200708002500.4563-1-cphealy@gmail.com>

On Tue, Jul 07, 2020 at 05:25:00PM -0700, Chris Healy wrote:
> Update MDIO configuration with ZII devices to fully utilize
> MDIO endpoint capabilities.  All devices support 12.5MHz clock and
> don't require MDIO preable.
> 
> Signed-off-by: Chris Healy <cphealy@gmail.com>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> v2:
> - Fix subject line to reference ZII:
> - Get rid of "=<1>;" from suppress-preamble lines
> 
>  arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi   | 2 ++
>  arch/arm/boot/dts/vf610-zii-cfu1.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-dev.dtsi      | 2 ++
>  arch/arm/boot/dts/vf610-zii-spb4.dts      | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts  | 2 ++
>  arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts | 2 ++
>  6 files changed, 12 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> index 20350e803377..58cc421042e1 100644
> --- a/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-zii-rdu2.dtsi
> @@ -720,6 +720,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;

We usually have 'status' at end of property list, so please move them
up.

Shawn

>  
>  		switch: switch@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-cfu1.dts b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> index ce1920c052fc..c27cacbe6a73 100644
> --- a/arch/arm/boot/dts/vf610-zii-cfu1.dts
> +++ b/arch/arm/boot/dts/vf610-zii-cfu1.dts
> @@ -159,6 +159,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6085";
> diff --git a/arch/arm/boot/dts/vf610-zii-dev.dtsi b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> index 95d0060fb56c..9694d3b53607 100644
> --- a/arch/arm/boot/dts/vf610-zii-dev.dtsi
> +++ b/arch/arm/boot/dts/vf610-zii-dev.dtsi
> @@ -138,6 +138,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  	};
>  };
>  
> diff --git a/arch/arm/boot/dts/vf610-zii-spb4.dts b/arch/arm/boot/dts/vf610-zii-spb4.dts
> index 55b4201e27f6..d2ad07ed5318 100644
> --- a/arch/arm/boot/dts/vf610-zii-spb4.dts
> +++ b/arch/arm/boot/dts/vf610-zii-spb4.dts
> @@ -120,6 +120,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> index a6c22a79779e..0bb3dcff0b79 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-dtu.dts
> @@ -106,6 +106,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> diff --git a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> index 3d05c894bdc0..e12e11805b71 100644
> --- a/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> +++ b/arch/arm/boot/dts/vf610-zii-ssmb-spu3.dts
> @@ -134,6 +134,8 @@
>  		#address-cells = <1>;
>  		#size-cells = <0>;
>  		status = "okay";
> +		suppress-preamble;
> +		clock-frequency = <12500000>;
>  
>  		switch0: switch0@0 {
>  			compatible = "marvell,mv88e6190";
> -- 
> 2.21.3
> 

  reply	other threads:[~2020-07-13  7:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-08  0:25 [PATCH v2] ARM: dts: ZII: update MDIO speed and preamble Chris Healy
2020-07-08  0:25 ` Chris Healy
2020-07-13  7:34 ` Shawn Guo [this message]
2020-07-13  7:34   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200713071957.GL12113@dragon \
    --to=shawnguo@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=cphealy@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=stefan@agner.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.