From: Shawn Guo <shawnguo@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@pengutronix.de, devicetree@vger.kernel.org,
fabio.estevam@nxp.com, linux-imx@nxp.com,
linux-usb@vger.kernel.org, jun.li@nxp.com
Subject: Re: [PATCH 3/4] ARM64: dts: fsl: imx8mm-evk: add two parameters for picophy tuning
Date: Mon, 13 Jul 2020 16:36:01 +0800 [thread overview]
Message-ID: <20200713083600.GD15718@dragon> (raw)
In-Reply-To: <20200709105902.23165-3-peter.chen@nxp.com>
On Thu, Jul 09, 2020 at 06:59:01PM +0800, Peter Chen wrote:
> With these two parameters tuning, it can pass USB eye diagram at evk board.
>
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
It's not so consistent, but idiomatically we prefix arm i.MX
platform/dts patches like 'ARM: ...', but 'arm64: ...' for arm64 ones.
Also with 'imx8mm-evk' in prefix, it's good enough to know this is
fsl/imx patch, so I suggest prefix like:
'arm64: dts: imx8mm-evk: ...'
Shawn
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index 0f1d7f8aeac4..c432b628e1ed 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -324,6 +324,8 @@
> srp-disable;
> adp-disable;
> usb-role-switch;
> + picophy,pre-emp-curr-control = <3>;
> + picophy,dc-vol-level-adjust = <7>;
> status = "okay";
>
> port {
> --
> 2.17.1
>
WARNING: multiple messages have this Message-ID (diff)
From: Shawn Guo <shawnguo@kernel.org>
To: Peter Chen <peter.chen@nxp.com>
Cc: devicetree@vger.kernel.org, linux-usb@vger.kernel.org,
robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de,
fabio.estevam@nxp.com, linux-arm-kernel@lists.infradead.org,
jun.li@nxp.com
Subject: Re: [PATCH 3/4] ARM64: dts: fsl: imx8mm-evk: add two parameters for picophy tuning
Date: Mon, 13 Jul 2020 16:36:01 +0800 [thread overview]
Message-ID: <20200713083600.GD15718@dragon> (raw)
In-Reply-To: <20200709105902.23165-3-peter.chen@nxp.com>
On Thu, Jul 09, 2020 at 06:59:01PM +0800, Peter Chen wrote:
> With these two parameters tuning, it can pass USB eye diagram at evk board.
>
> Reviewed-by: Jun Li <jun.li@nxp.com>
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
It's not so consistent, but idiomatically we prefix arm i.MX
platform/dts patches like 'ARM: ...', but 'arm64: ...' for arm64 ones.
Also with 'imx8mm-evk' in prefix, it's good enough to know this is
fsl/imx patch, so I suggest prefix like:
'arm64: dts: imx8mm-evk: ...'
Shawn
> ---
> arch/arm64/boot/dts/freescale/imx8mm-evk.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> index 0f1d7f8aeac4..c432b628e1ed 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mm-evk.dts
> @@ -324,6 +324,8 @@
> srp-disable;
> adp-disable;
> usb-role-switch;
> + picophy,pre-emp-curr-control = <3>;
> + picophy,dc-vol-level-adjust = <7>;
> status = "okay";
>
> port {
> --
> 2.17.1
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 8:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 10:58 [PATCH 1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy Peter Chen
2020-07-09 10:58 ` Peter Chen
2020-07-09 10:59 ` [PATCH 2/4] usb: chipidea: imx: add two picophy parameters tuning implementation Peter Chen
2020-07-09 10:59 ` Peter Chen
2020-07-09 10:59 ` [PATCH 3/4] ARM64: dts: fsl: imx8mm-evk: add two parameters for picophy tuning Peter Chen
2020-07-09 10:59 ` Peter Chen
2020-07-13 8:36 ` Shawn Guo [this message]
2020-07-13 8:36 ` Shawn Guo
2020-07-13 8:40 ` Peter Chen
2020-07-13 8:40 ` Peter Chen
2020-07-09 10:59 ` [PATCH 4/4] ARM64: dts: fsl: imx8mn-evk: " Peter Chen
2020-07-09 10:59 ` Peter Chen
2020-07-13 8:31 ` [PATCH 1/4] doc: dt-binding: ci-hdrc-usb2: add property for imx picophy Shawn Guo
2020-07-13 8:31 ` Shawn Guo
2020-07-13 8:38 ` Peter Chen
2020-07-13 8:38 ` Peter Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713083600.GD15718@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=jun.li@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.