From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org,
Baidyanath Kundu <kundubaidya99@gmail.com>,
linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] Staging: vc04_services: Fix code indent error
Date: Mon, 13 Jul 2020 16:38:21 +0300 [thread overview]
Message-ID: <20200713133821.GS2549@kadam> (raw)
In-Reply-To: <20200713133527.GB3122574@kroah.com>
On Mon, Jul 13, 2020 at 03:35:27PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 13, 2020 at 12:52:24PM +0530, Baidyanath Kundu wrote:
> > This patch fixes the checkpatch.pl error:
> >
> > ERROR: code indent should use tabs where possible
> >
> > Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
> > ---
> > .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > index a075cd63da7f..86c00b68f099 100644
> > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > @@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
> > /* queue the bulk submission */
> > vchiq_use_service(instance->service_handle);
> > ret = vchiq_bulk_receive(instance->service_handle,
> > - msg_context->u.bulk.buffer->buffer,
> > - /* Actual receive needs to be a multiple
> > - * of 4 bytes
> > - */
> > - (len + 3) & ~3,
> > - msg_context,
> > - VCHIQ_BULK_MODE_CALLBACK);
> > + msg_context->u.bulk.buffer->buffer,
> > + /* Actual receive needs to be a multiple
> > + * of 4 bytes
> > + */
> > + (len + 3) & ~3,
> > + msg_context,
> > + VCHIQ_BULK_MODE_CALLBACK);
>
> Close, you need one more space for these lines, right?
>
Yeah. The original has the space and looks correct.
regards,
dan carpenter
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Baidyanath Kundu <kundubaidya99@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] Staging: vc04_services: Fix code indent error
Date: Mon, 13 Jul 2020 16:38:21 +0300 [thread overview]
Message-ID: <20200713133821.GS2549@kadam> (raw)
In-Reply-To: <20200713133527.GB3122574@kroah.com>
On Mon, Jul 13, 2020 at 03:35:27PM +0200, Greg Kroah-Hartman wrote:
> On Mon, Jul 13, 2020 at 12:52:24PM +0530, Baidyanath Kundu wrote:
> > This patch fixes the checkpatch.pl error:
> >
> > ERROR: code indent should use tabs where possible
> >
> > Signed-off-by: Baidyanath Kundu <kundubaidya99@gmail.com>
> > ---
> > .../staging/vc04_services/vchiq-mmal/mmal-vchiq.c | 14 +++++++-------
> > 1 file changed, 7 insertions(+), 7 deletions(-)
> >
> > diff --git a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > index a075cd63da7f..86c00b68f099 100644
> > --- a/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > +++ b/drivers/staging/vc04_services/vchiq-mmal/mmal-vchiq.c
> > @@ -294,13 +294,13 @@ static void buffer_to_host_work_cb(struct work_struct *work)
> > /* queue the bulk submission */
> > vchiq_use_service(instance->service_handle);
> > ret = vchiq_bulk_receive(instance->service_handle,
> > - msg_context->u.bulk.buffer->buffer,
> > - /* Actual receive needs to be a multiple
> > - * of 4 bytes
> > - */
> > - (len + 3) & ~3,
> > - msg_context,
> > - VCHIQ_BULK_MODE_CALLBACK);
> > + msg_context->u.bulk.buffer->buffer,
> > + /* Actual receive needs to be a multiple
> > + * of 4 bytes
> > + */
> > + (len + 3) & ~3,
> > + msg_context,
> > + VCHIQ_BULK_MODE_CALLBACK);
>
> Close, you need one more space for these lines, right?
>
Yeah. The original has the space and looks correct.
regards,
dan carpenter
next prev parent reply other threads:[~2020-07-13 13:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 7:22 [PATCH] Staging: vc04_services: Fix code indent error Baidyanath Kundu
2020-07-13 7:22 ` Baidyanath Kundu
2020-07-13 13:35 ` Greg Kroah-Hartman
2020-07-13 13:35 ` Greg Kroah-Hartman
2020-07-13 13:38 ` Dan Carpenter [this message]
2020-07-13 13:38 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713133821.GS2549@kadam \
--to=dan.carpenter@oracle.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kundubaidya99@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=nsaenzjulienne@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.