From: Varun Prakash <varun@chelsio.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Austin Kim <austindh.kim@gmail.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
varun@chelsio.com
Subject: Re: [PATCH] scsi: cxgb4i: clean up a debug printk
Date: Mon, 13 Jul 2020 16:25:37 +0000 [thread overview]
Message-ID: <20200713161336.GA1780@chelsio.com> (raw)
In-Reply-To: <20200713105100.GA251988@mwanda>
On Mon, Jul 13, 2020 at 10:51:00AM +0000, Dan Carpenter wrote:
> The pr_fmt() at the top of the file already includes the __func__ so we
> can remove the duplicative "cxgbi_conn_init_pdu:" from the string here.
> Now it all fits on one line as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index 1fb101c616b7..ba1593be626c 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -2182,8 +2182,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,
> }
>
> log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX,
> - "cxgbi_conn_init_pdu: tdata->total_count %u, "
> - "tdata->total_offset %u\n",
> + "data->total_count %u, tdata->total_offset %u\n",
> tdata->total_count, tdata->total_offset);
>
> expected_count = tdata->total_count;
Acked-by: Varun Prakash <varun@chelsio.com>
WARNING: multiple messages have this Message-ID (diff)
From: Varun Prakash <varun@chelsio.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Austin Kim <austindh.kim@gmail.com>,
linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org,
varun@chelsio.com
Subject: Re: [PATCH] scsi: cxgb4i: clean up a debug printk
Date: Mon, 13 Jul 2020 21:43:37 +0530 [thread overview]
Message-ID: <20200713161336.GA1780@chelsio.com> (raw)
In-Reply-To: <20200713105100.GA251988@mwanda>
On Mon, Jul 13, 2020 at 10:51:00AM +0000, Dan Carpenter wrote:
> The pr_fmt() at the top of the file already includes the __func__ so we
> can remove the duplicative "cxgbi_conn_init_pdu:" from the string here.
> Now it all fits on one line as well.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/scsi/cxgbi/libcxgbi.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/cxgbi/libcxgbi.c b/drivers/scsi/cxgbi/libcxgbi.c
> index 1fb101c616b7..ba1593be626c 100644
> --- a/drivers/scsi/cxgbi/libcxgbi.c
> +++ b/drivers/scsi/cxgbi/libcxgbi.c
> @@ -2182,8 +2182,7 @@ int cxgbi_conn_init_pdu(struct iscsi_task *task, unsigned int offset,
> }
>
> log_debug(1 << CXGBI_DBG_ISCSI | 1 << CXGBI_DBG_PDU_TX,
> - "cxgbi_conn_init_pdu: tdata->total_count %u, "
> - "tdata->total_offset %u\n",
> + "data->total_count %u, tdata->total_offset %u\n",
> tdata->total_count, tdata->total_offset);
>
> expected_count = tdata->total_count;
Acked-by: Varun Prakash <varun@chelsio.com>
next prev parent reply other threads:[~2020-07-13 16:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 10:51 [PATCH] scsi: cxgb4i: clean up a debug printk Dan Carpenter
2020-07-13 10:51 ` Dan Carpenter
2020-07-13 16:13 ` Varun Prakash [this message]
2020-07-13 16:25 ` Varun Prakash
2020-07-14 4:58 ` Martin K. Petersen
2020-07-14 4:58 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200713161336.GA1780@chelsio.com \
--to=varun@chelsio.com \
--cc=austindh.kim@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=jejb@linux.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.