All of lore.kernel.org
 help / color / mirror / Atom feed
From: Suraj Upadhyay <usuraj35@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
	gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.
Date: Tue, 14 Jul 2020 12:10:22 +0530	[thread overview]
Message-ID: <20200714064022.GA12651@blackclown> (raw)
In-Reply-To: <20200713141235.GT2549@kadam>


[-- Attachment #1.1: Type: text/plain, Size: 599 bytes --]

On Mon, Jul 13, 2020 at 05:12:35PM +0300, Dan Carpenter wrote:
> On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote:
> > Simplify while loops into more readable and simple for loops.
> > 
> 
> I don't think either is more clear that the other.  Walter Harms hates
> count down loops and he's not entirely wrong...
> 
> regards,
> dan carpenter

Hi Dan,
	Thanks for your response.
Should I send a v2 of this patch or not ??
Also do you have any problems with the other two patches doing the same
thing in different files ??
I am all ears.

Thanks,

Suraj Upadhyay.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Suraj Upadhyay <usuraj35@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
	manishc@marvell.com, GR-Linux-NIC-Dev@marvell.com,
	gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/6] staging: qlge: qlge_main: Simplify while statements.
Date: Tue, 14 Jul 2020 12:10:22 +0530	[thread overview]
Message-ID: <20200714064022.GA12651@blackclown> (raw)
In-Reply-To: <20200713141235.GT2549@kadam>

[-- Attachment #1: Type: text/plain, Size: 599 bytes --]

On Mon, Jul 13, 2020 at 05:12:35PM +0300, Dan Carpenter wrote:
> On Mon, Jul 13, 2020 at 05:50:14PM +0530, Suraj Upadhyay wrote:
> > Simplify while loops into more readable and simple for loops.
> > 
> 
> I don't think either is more clear that the other.  Walter Harms hates
> count down loops and he's not entirely wrong...
> 
> regards,
> dan carpenter

Hi Dan,
	Thanks for your response.
Should I send a v2 of this patch or not ??
Also do you have any problems with the other two patches doing the same
thing in different files ??
I am all ears.

Thanks,

Suraj Upadhyay.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-07-14  7:03 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-13 12:14 [PATCH 0/6] staging: qlge: General cleanup and refactor Suraj Upadhyay
2020-07-13 12:15 ` [PATCH 1/6] staging: qlge: qlge.h: Function definition arguments should have names Suraj Upadhyay
2020-07-13 12:15 ` [PATCH 2/6] staging: qlge: qlge.h: Insert line after declaration Suraj Upadhyay
2020-07-13 12:16 ` [PATCH 3/6] staging: qlge: qlge_dbg: Simplify while statements Suraj Upadhyay
2020-07-13 12:20 ` [PATCH 4/6] staging: qlge: qlge_main: " Suraj Upadhyay
2020-07-13 13:38   ` Greg KH
2020-07-13 14:12   ` Dan Carpenter
2020-07-14  6:40     ` Suraj Upadhyay [this message]
2020-07-14  6:40       ` Suraj Upadhyay
2020-07-14  8:28       ` Dan Carpenter
2020-07-14  8:28         ` Dan Carpenter
2020-07-14  5:41   ` Benjamin Poirier
2020-07-14  6:43     ` Suraj Upadhyay
2020-07-14  6:43       ` Suraj Upadhyay
2020-07-13 12:21 ` [PATCH 5/6] staging: qlge: qlge_mpi: " Suraj Upadhyay
2020-07-13 12:22 ` [PATCH 6/6] staging: qlge: qlge_ethtool: Remove one byte memset Suraj Upadhyay
2020-07-13 14:17   ` Dan Carpenter
2020-07-14 18:57     ` Joe Perches
2020-07-14 19:06       ` Suraj Upadhyay
2020-07-14 19:22         ` Joe Perches
2020-07-14 19:54           ` Suraj Upadhyay

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200714064022.GA12651@blackclown \
    --to=usuraj35@gmail.com \
    --cc=GR-Linux-NIC-Dev@marvell.com \
    --cc=dan.carpenter@oracle.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manishc@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.